-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix root certificate updater #55681
Conversation
Determine the NSS version from actual Firefox releases, instead of attempting to parse a wiki page (which is sensitive to formatting changes and relies on the page being up to date).
This is the certdata.txt[0] from NSS 3.104. This is the version of NSS that shipped in Firefox 131.0 on 2024-10-01. Certificates added: - FIRMAPROFESIONAL CA ROOT-A WEB - TWCA CYBER Root CA - SecureSign Root CA12 - SecureSign Root CA14 - SecureSign Root CA15 [0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_104_RTM/lib/ckfw/builtins/certdata.txt
Review requested:
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55681 +/- ##
==========================================
- Coverage 88.43% 88.40% -0.03%
==========================================
Files 654 654
Lines 187720 187594 -126
Branches 36140 36097 -43
==========================================
- Hits 166004 165838 -166
- Misses 14953 14998 +45
+ Partials 6763 6758 -5 |
Co-authored-by: Michaël Zasso <targos@protonmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Landed in 8dd0819...32ff100 |
Determine the NSS version from actual Firefox releases, instead of attempting to parse a wiki page (which is sensitive to formatting changes and relies on the page being up to date). PR-URL: #55681 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This is the certdata.txt[0] from NSS 3.104. This is the version of NSS that shipped in Firefox 131.0 on 2024-10-01. Certificates added: - FIRMAPROFESIONAL CA ROOT-A WEB - TWCA CYBER Root CA - SecureSign Root CA12 - SecureSign Root CA14 - SecureSign Root CA15 [0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_104_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #55681 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Determine the NSS version from actual Firefox releases, instead of attempting to parse a wiki page (which is sensitive to formatting changes and relies on the page being up to date). PR-URL: #55681 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This is the certdata.txt[0] from NSS 3.104. This is the version of NSS that shipped in Firefox 131.0 on 2024-10-01. Certificates added: - FIRMAPROFESIONAL CA ROOT-A WEB - TWCA CYBER Root CA - SecureSign Root CA12 - SecureSign Root CA14 - SecureSign Root CA15 [0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_104_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #55681 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Determine the NSS version from actual Firefox releases, instead of attempting to parse a wiki page (which is sensitive to formatting changes and relies on the page being up to date).
Refs: #54680 (comment)
Second commit is the result of running the script to update to Firefox 131 which picks up NSS 3.104.
Running the script again without specifying the version shows the script picking up Firefox 132 and NSS 3.105 but there are no certdata changes from NSS 3.104 which would correctly prevent
.github/workflows/tools.yml
from creating a new pull request as no files would change:For the release notes, the notable change is