Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add diagnostic channel http.client.request.created #55586

Merged
merged 1 commit into from
Oct 31, 2024
Merged

http: add diagnostic channel http.client.request.created #55586

merged 1 commit into from
Oct 31, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #55352

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Oct 29, 2024
@marco-ippolito marco-ippolito force-pushed the diagnostic-channel-request-created branch from 2a2da26 to 693825d Compare October 29, 2024 12:50
@marco-ippolito marco-ippolito changed the title http: add diagnostic channel http: add diagnostic channel http.client.request.created Oct 29, 2024
@richardlau richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 29, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (53b1050) to head (693825d).
Report is 32 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #55586    +/-   ##
========================================
  Coverage   88.42%   88.43%            
========================================
  Files         654      654            
  Lines      187552   187680   +128     
  Branches    36087    36126    +39     
========================================
+ Hits       165839   165970   +131     
- Misses      14950    14957     +7     
+ Partials     6763     6753    -10
Files with missing lines Coverage Δ
lib/_http_client.js 97.97% <100.00%> (+0.01%) ⬆️

... and 35 files with indirect coverage changes

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63341/

ShogunPanda
ShogunPanda approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShogunPanda
Copy link
Contributor

It would be great to have http.server.response.created as well, emitted before the first byte is sent to the client. Would you be able to do that?

@marco-ippolito
Copy link
Member Author

It would be great to have http.server.response.created as well, emitted before the first byte is sent to the client. Would you be able to do that?

I will do in a followup PR

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 30, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4379dfb into nodejs:main Oct 31, 2024
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4379dfb

@marco-ippolito marco-ippolito mentioned this pull request Oct 31, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
@marco-ippolito @RafaelGSS
http: add diagnostic channel http.client.request.created
25b1422 
PR-URL: #55586
Fixes: #55352
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Nov 1, 2024
@RafaelGSS
2024-11-01, Version 23.2.0 (Current)
736f2f1 
Notable changes:

doc:
  * move typescript support to active development (Marco Ippolito) nodejs#55536
  * add jazelly to collaborators (Jason Zhang) nodejs#55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412
  * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) nodejs#55282

PR-URL: TODO
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@marco-ippolito @louwers
http: add diagnostic channel http.client.request.created
e91169a 
PR-URL: nodejs#55586
Fixes: nodejs#55352
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
b40f681 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) #55282
tools:
  * fix root certificate updater (Richard Lau) #55681

PR-URL: TODO
@aduh95 aduh95 mentioned this pull request Nov 6, 2024
Merged
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
2c07f86 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
69c6bf2 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 9, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
f2bac99 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
a83fbdb 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
c52c670 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@marco-ippolito @tpoisseau
http: add diagnostic channel http.client.request.created
04bf62d 
PR-URL: nodejs#55586
Fixes: nodejs#55352
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95 @tpoisseau
2024-11-11, Version 23.2.0 (Current)
f802d96 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) nodejs#55681
doc:
  * move typescript support to active development (Marco Ippolito) nodejs#55536
  * add jazelly to collaborators (Jason Zhang) nodejs#55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) nodejs#55282

PR-URL: nodejs#55741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@theanarkh theanarkh theanarkh approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: http.client.request.created Event in diagnostics_channel
6 participants
@marco-ippolito @nodejs-github-bot @ShogunPanda @theanarkh @jakecastelli @richardlau