test_runner: require --enable-source-maps for sourcemap coverage
#55359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
RedYetiDev
added
coverage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55359 +/- ##
==========================================
- Coverage 88.40% 88.40% -0.01%
==========================================
Files 652 652
Lines 186778 186786 +8
Branches 36049 36046 -3
==========================================
- Hits 165127 165125 -2
- Misses 14903 14912 +9
- Partials 6748 6749 +1
|
cjihrig
reviewed
Oct 11, 2024
RedYetiDev
force-pushed
the
sourcemap-flag-coverage
branch
from
2cc8c10
to
0d356bb
Compare
cjihrig
approved these changes
Oct 12, 2024
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Oct 14, 2024
pmarchini
approved these changes
Oct 14, 2024
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 10addb0 |
aduh95
pushed a commit
that referenced
this pull request
Oct 19, 2024
PR-URL: #55359 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55359 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #54753 (comment) / #54753 (comment)
This is not semver-major, as both code coverage and source maps experimental features.
The coverage constructer was changed to accept a
globalOptionsbecause of how cluttered it got from all the additional features.Previously, there were some issues with coverage (See #55039), however, other test runner changes have resolved those issues.