src,lib: introduce `util.getSystemErrorMessage(err)` #54075

juanarbol · 2024-07-28T03:55:42Z

This patch adds a new utility function which provides human-readable string description of the given system error code.

nodejs-github-bot · 2024-07-28T04:02:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60682/

codecov · 2024-07-28T11:02:42Z

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (8ed50bc) to head (f42721b).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/uv.cc	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54075      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.01%     
==========================================
  Files         653      653              
  Lines      187485   187513      +28     
  Branches    36095    36100       +5     
==========================================
+ Hits       165764   165774      +10     
- Misses      14966    14977      +11     
- Partials     6755     6762       +7

Files with missing lines	Coverage Δ
lib/internal/util.js	`96.96% <100.00%> (-0.10%)`	⬇️
lib/util.js	`97.29% <100.00%> (+0.09%)`	⬆️
src/uv.cc	`90.62% <90.00%> (+1.53%)`	⬆️

... and 21 files with indirect coverage changes

anonrig · 2024-07-28T21:36:32Z

src/uv.cc

+  int err;
+  if (!args[0]->Int32Value(env->context()).To(&err)) return;
+  CHECK_LT(err, 0);
+  char message[50];


Why 50? Can you add a comment?

Same as the name getter

https://github.com/juanarbol/node/blob/cf6d05950d991b0cbeb06aa10d5bcf79c485c81f/src/uv.cc#L86

Can you add a comment?

src/uv.cc

anonrig · 2024-07-28T21:39:28Z

lib/util.js

+ * @returns {string}
+ */
+function getSystemErrorMessage(err) {
+  validateNumber(err, 'err');


Why do we need to call validateNumber since in the next line we check for SafeNumber?

Same as name getter

https://github.com/juanarbol/node/blob/cf6d05950d991b0cbeb06aa10d5bcf79c485c81f/lib/util.js#L250

This more about the current codebase.

nodejs-github-bot · 2024-07-30T11:23:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60748/

nodejs-github-bot · 2024-07-31T19:41:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60780/

nodejs-github-bot · 2024-08-01T16:52:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60802/

nodejs-github-bot · 2024-08-02T19:40:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60839/

nodejs-github-bot · 2024-08-02T23:34:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60841/

nodejs-github-bot · 2024-08-08T06:45:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60969/

doc/api/util.md

nodejs-github-bot · 2024-08-19T02:57:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61215/

nodejs-github-bot · 2024-08-19T08:59:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61224/

nodejs-github-bot · 2024-08-19T22:35:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61251/

nodejs-github-bot · 2024-08-20T16:38:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61289/

This patch adds a new utility function which provides human-readable string description of the given system error code. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>

nodejs-github-bot · 2024-10-19T20:11:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63204/

juanarbol · 2024-10-19T23:05:02Z

Ping to @nodejs/libuv

nodejs-github-bot · 2024-10-19T23:15:18Z

Landed in 61e52c8

This patch adds a new utility function which provides human-readable string description of the given system error code. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #54075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This patch adds a new utility function which provides human-readable string description of the given system error code. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs#54075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 28, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024

anonrig reviewed Jul 28, 2024

View reviewed changes

jasnell approved these changes Jul 29, 2024

View reviewed changes

juanarbol force-pushed the juan/uv-err-message branch from cf6d059 to 972c30e Compare July 30, 2024 10:29

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 1, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024

lpinca approved these changes Aug 16, 2024

View reviewed changes

doc/api/util.md Outdated Show resolved Hide resolved

juanarbol force-pushed the juan/uv-err-message branch from 972c30e to 3eac60e Compare August 19, 2024 02:48

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2024

juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

src,lib: introduce util.getSystemErrorMessage(err)

f42721b

This patch adds a new utility function which provides human-readable string description of the given system error code. Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>

juanarbol force-pushed the juan/uv-err-message branch from 3eac60e to f42721b Compare October 19, 2024 20:10

anonrig approved these changes Oct 19, 2024

View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2024

nodejs-github-bot merged commit 61e52c8 into nodejs:main Oct 19, 2024
55 checks passed

aduh95 mentioned this pull request Oct 24, 2024

V23.1.0 proposal #55513

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src,lib: introduce `util.getSystemErrorMessage(err)` #54075

src,lib: introduce `util.getSystemErrorMessage(err)` #54075

juanarbol commented Jul 28, 2024

nodejs-github-bot commented Jul 28, 2024

codecov bot commented Jul 28, 2024 •

edited

Loading

anonrig Jul 28, 2024

juanarbol Jul 30, 2024

anonrig Jul 31, 2024

anonrig Jul 28, 2024

juanarbol Jul 30, 2024

nodejs-github-bot commented Jul 30, 2024

nodejs-github-bot commented Jul 31, 2024

nodejs-github-bot commented Aug 1, 2024

nodejs-github-bot commented Aug 2, 2024

nodejs-github-bot commented Aug 2, 2024

nodejs-github-bot commented Aug 8, 2024

nodejs-github-bot commented Aug 19, 2024

nodejs-github-bot commented Aug 19, 2024

nodejs-github-bot commented Aug 19, 2024

nodejs-github-bot commented Aug 20, 2024

nodejs-github-bot commented Oct 19, 2024

juanarbol commented Oct 19, 2024

nodejs-github-bot commented Oct 19, 2024

src,lib: introduce util.getSystemErrorMessage(err) #54075

src,lib: introduce util.getSystemErrorMessage(err) #54075

Conversation

juanarbol commented Jul 28, 2024

nodejs-github-bot commented Jul 28, 2024

codecov bot commented Jul 28, 2024 • edited Loading

Codecov Report

anonrig Jul 28, 2024

Choose a reason for hiding this comment

juanarbol Jul 30, 2024

Choose a reason for hiding this comment

anonrig Jul 31, 2024

Choose a reason for hiding this comment

anonrig Jul 28, 2024

Choose a reason for hiding this comment

juanarbol Jul 30, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 30, 2024

nodejs-github-bot commented Jul 31, 2024

nodejs-github-bot commented Aug 1, 2024

nodejs-github-bot commented Aug 2, 2024

nodejs-github-bot commented Aug 2, 2024

nodejs-github-bot commented Aug 8, 2024

nodejs-github-bot commented Aug 19, 2024

nodejs-github-bot commented Aug 19, 2024

nodejs-github-bot commented Aug 19, 2024

nodejs-github-bot commented Aug 20, 2024

nodejs-github-bot commented Oct 19, 2024

juanarbol commented Oct 19, 2024

nodejs-github-bot commented Oct 19, 2024

src,lib: introduce `util.getSystemErrorMessage(err)` #54075

src,lib: introduce `util.getSystemErrorMessage(err)` #54075

codecov bot commented Jul 28, 2024 •

edited

Loading