url: handle "unsafe" characters properly in `pathToFileURL` #54545

aduh95 · 2024-08-24T19:50:24Z

Given the number of characters to cover, I leaning towards using one regex to deal with them all rather than adding more special cases. Let's check what the benchmark says.

FWIW According to RFC1738, they should be encoded (see the bold):

Characters can be unsafe for a number of reasons. The space
character is unsafe because significant spaces may disappear and
insignificant spaces may be introduced when URLs are transcribed or
typeset or subjected to the treatment of word-processing programs.
The characters "<" and ">" are unsafe because they are used as the
delimiters around URLs in free text; the quote mark (""") is used to
delimit URLs in some systems. The character "#" is unsafe and should
always be encoded because it is used in World Wide Web and in other
systems to delimit a URL from a fragment/anchor identifier that might
follow it. The character "%" is unsafe because it is used for
encodings of other characters. Other characters are unsafe because
gateways and other transport agents are known to sometimes modify
such characters. These characters are "{", "}", "|", "", "^", "~",
"[", "]", and "`".

All unsafe characters must always be encoded within a URL. For
example, the character "#" must be encoded within URLs even in
systems that do not normally deal with fragment or anchor
identifiers, so that if the URL is copied into another system that
does use them, it will not be necessary to change the URL encoding.

Originally posted by @RedYetiDev in #54515 (comment)

I took the tests from #54516, so I added @EarlyRiser42 as co-author.

nodejs-github-bot · 2024-08-24T19:50:29Z

Review requested:

@nodejs/loaders
@nodejs/url

codecov · 2024-08-24T21:24:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (be4babb) to head (dcb75fa).
Report is 290 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54545   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         652      652           
  Lines      183761   183817   +56     
  Branches    35863    35873   +10     
=======================================
+ Hits       161765   161816   +51     
- Misses      15229    15241   +12     
+ Partials     6767     6760    -7

Files with missing lines	Coverage Δ
lib/internal/process/execution.js	`98.79% <100.00%> (ø)`
lib/internal/url.js	`97.92% <100.00%> (+0.02%)`	⬆️

... and 24 files with indirect coverage changes

targos · 2024-08-25T07:51:53Z

How does it have an impact on fileURLToPath ?

EarlyRiser42 · 2024-08-25T08:36:13Z

There was a typo in the current benchmark causing only pathToFileURL to run. The typo fileUrlOrPath instead of fileUrlToPath in main led to this issue, even though both functions were passed as inputs in createbenchmark. I submitted a PR to fix this (#54190).

aduh95 · 2024-08-25T18:05:24Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1618/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***    -15.54 %       ±0.23% ±0.31% ±0.40%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***    -14.31 %       ±0.31% ±0.42% ±0.55%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***     -7.84 %       ±0.37% ±0.49% ±0.63%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'                     -0.17 %       ±0.44% ±0.58% ±0.76%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***    -11.61 %       ±0.61% ±0.81% ±1.06%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                -0.35 %       ±0.40% ±0.54% ±0.70%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***    -14.09 %       ±0.49% ±0.66% ±0.86%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                     0.02 %       ±0.40% ±0.54% ±0.70%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***     -7.37 %       ±0.45% ±0.60% ±0.78%

aduh95 · 2024-08-25T22:24:17Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1619/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***    -11.39 %       ±0.32% ±0.43% ±0.56%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***     -7.01 %       ±0.40% ±0.53% ±0.69%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***     -7.76 %       ±0.31% ±0.42% ±0.55%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'                     -0.09 %       ±0.27% ±0.36% ±0.47%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***     -8.94 %       ±0.73% ±0.98% ±1.30%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                -0.18 %       ±0.35% ±0.47% ±0.61%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***     -9.00 %       ±0.43% ±0.57% ±0.75%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                    -0.33 %       ±1.10% ±1.47% ±1.94%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***     -6.85 %       ±0.42% ±0.56% ±0.74%

anonrig

I think we shouldn't land this PR with this much impact on almost all Node.js operations.

aduh95 · 2024-08-25T23:18:02Z

V8 performance lesson of the day: multiple regexes are better than a single one apparently 🤷‍♂️

aduh95 · 2024-08-26T22:25:51Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1620/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***     -8.38 %       ±0.43% ±0.58% ±0.75%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***     -9.95 %       ±0.50% ±0.66% ±0.87%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***    -15.48 %       ±0.52% ±0.70% ±0.91%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'                      0.35 %       ±0.37% ±0.50% ±0.65%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***     -7.29 %       ±0.49% ±0.66% ±0.86%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                 0.50 %       ±0.81% ±1.09% ±1.43%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***    -10.97 %       ±0.36% ±0.48% ±0.62%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                     0.11 %       ±0.69% ±0.92% ±1.19%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***     -9.62 %       ±0.42% ±0.55% ±0.72%

lib/internal/url.js

aduh95 · 2024-08-26T23:15:55Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1621/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***     -9.09 %       ±0.39% ±0.53% ±0.69%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***    -10.66 %       ±0.45% ±0.60% ±0.78%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***    -15.32 %       ±0.29% ±0.39% ±0.51%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'                     -0.06 %       ±0.43% ±0.57% ±0.74%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***     -8.11 %       ±0.67% ±0.91% ±1.20%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                -0.07 %       ±0.46% ±0.61% ±0.79%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***    -10.64 %       ±0.52% ±0.69% ±0.91%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                     0.69 %       ±0.82% ±1.10% ±1.44%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***     -7.96 %       ±0.31% ±0.41% ±0.54%

lib/internal/url.js

aduh95 · 2024-08-27T08:26:46Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1622/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***    -22.93 %       ±0.46% ±0.62% ±0.82%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***    -24.39 %       ±0.29% ±0.39% ±0.51%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***    -33.14 %       ±0.40% ±0.54% ±0.70%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'                     -0.51 %       ±0.86% ±1.16% ±1.54%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***    -18.79 %       ±0.51% ±0.68% ±0.89%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                 0.19 %       ±0.30% ±0.40% ±0.52%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***    -22.45 %       ±0.39% ±0.52% ±0.68%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                     0.11 %       ±0.38% ±0.50% ±0.65%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***    -22.06 %       ±0.46% ±0.62% ±0.80%

aduh95 · 2024-08-27T09:01:25Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1623/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***    -35.89 %       ±0.47% ±0.63% ±0.84%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***    -32.21 %       ±0.33% ±0.44% ±0.58%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***    -51.54 %       ±0.53% ±0.71% ±0.94%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'                     -0.23 %       ±0.33% ±0.44% ±0.58%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***    -29.42 %       ±0.60% ±0.80% ±1.04%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                -0.20 %       ±0.31% ±0.41% ±0.53%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***    -28.38 %       ±0.55% ±0.74% ±0.98%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                    -0.59 %       ±1.29% ±1.73% ±2.27%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***    -38.36 %       ±0.29% ±0.39% ±0.51%

aduh95 · 2024-08-27T09:44:24Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1624/

                                                                                                                 confidence improvement accuracy (*)   (**)  (***)
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool' method='pathToFileURL'                    ***    -12.29 %       ±0.58% ±0.78% ±1.01%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null?key=param&bool#hash' method='pathToFileURL'               ***    -15.91 %       ±0.46% ±0.61% ±0.79%
url/whatwg-url-to-and-from-path.js n=5000000 input='/dev/null' method='pathToFileURL'                                   ***    -15.43 %       ±0.26% ±0.35% ±0.45%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='fileURLToPath'               *     -0.38 %       ±0.37% ±0.50% ±0.66%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool' method='pathToFileURL'             ***     -9.85 %       ±0.66% ±0.89% ±1.17%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='fileURLToPath'                 0.06 %       ±0.17% ±0.22% ±0.29%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null?key=param&bool#hash' method='pathToFileURL'        ***    -14.37 %       ±0.69% ±0.93% ±1.21%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='fileURLToPath'                                     0.14 %       ±0.49% ±0.65% ±0.85%
url/whatwg-url-to-and-from-path.js n=5000000 input='file:///dev/null' method='pathToFileURL'                            ***     -9.18 %       ±0.34% ±0.45% ±0.59%

EarlyRiser42 · 2024-08-27T09:53:49Z

As @RedYetiDev originally mentioned in #54515, both | and ~ need to be encoded. However, I noticed that on my local machines (Windows and Linux), they are not encoded when used in a file URL, which has caused some confusion. Additionally, since { and } are encoded by the URL constructor (bindingurl.parse), perhaps we don't need to include them in the regex. Feel free to ignore..

replaceAll

fastest alternative

…URL`

nodejs-github-bot · 2024-09-19T11:13:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62560/

joyeecheung · 2024-09-19T13:28:59Z

I don't think pathToFileURL is used in any hot path (I had a quick look at the 53 occurrences of it in the lib/ folder), I'd be surprised if it had any significant impact on the other parts of the codebase. It's rather rare than we need to convert a path to a file URL, but when we do, I think we want to generate a URL with those "unsafe" char correctly encoded.

Heads up that this would affect nodejs/loaders#198 because the hooks are exposing URLs, even though for CJS, they are always paths, so there needs to be one extra pathToFileURL per module. I think this would be almost inevitable as we try to improve CommonJS/ESM interop, when CommonJS always uses paths (which are require.cache keys, sigh), and ESM uses URLs, so the conversion will always end up on a hot path one day, no matter if it's for universal hooks or other purposes.

joyeecheung · 2024-09-19T14:00:17Z

Actually it seems pathToFileURL is already invoked per-ESM in

node/lib/internal/modules/esm/resolve.js

Lines 266 to 267 in 00c0644

    
           resolved = 
        
               pathToFileURL(real + (StringPrototypeEndsWith(path, sep) ? '/' : ''));

, and per-package.json in

node/lib/internal/modules/esm/resolve.js

Line 794 in 00c0644

const packageJSONUrl = pathToFileURL(packageConfig.pjsonPath);

It's invoked 16 times when loading npm CLI, even though the npm CLI is mostly CommonJS (but it does load several package.json and uses dynamic import to load chalk)

aduh95 · 2024-09-19T15:00:00Z

I think as Yagiz mentioned, we should probably move the implementation to C++ (we need to call the URL constructor anyway, so given we have to cross into native land anyway, it would only makes sense to use C++ rather than JS regexes to do the string manipulation). I don't know if I'm the right person to work on this, but I can certainly try – I first need to fix the current implementation, as it looks like it's failing on Windows.

nodejs-github-bot · 2024-09-20T10:30:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62594/

jasnell · 2024-09-21T16:31:43Z

There are relevant test failures on windows

mcollina

RLGTM

nodejs-github-bot · 2024-10-15T16:54:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63125/

nodejs-github-bot · 2024-10-17T11:07:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63158/

nodejs-github-bot · 2024-10-18T07:20:44Z

Landed in 7ae193d

Co-authored-by: EarlyRiser42 <tkfydtls464@gmail.com> PR-URL: nodejs#54545 Fixes: nodejs#54515 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Co-authored-by: EarlyRiser42 <tkfydtls464@gmail.com> PR-URL: #54545 Fixes: #54515 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Co-authored-by: EarlyRiser42 <tkfydtls464@gmail.com> PR-URL: nodejs#54545 Fixes: nodejs#54515 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

aduh95 added the needs-benchmark-ci PR that need a benchmark CI run. label Aug 24, 2024

nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 24, 2024

benjamingr approved these changes Aug 24, 2024

View reviewed changes

jasnell approved these changes Aug 24, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

anonrig reviewed Aug 25, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

ljharb reviewed Aug 26, 2024

View reviewed changes

lib/internal/url.js Outdated Show resolved Hide resolved

RedYetiDev reviewed Aug 26, 2024

View reviewed changes

lib/internal/url.js Show resolved Hide resolved

This comment was marked as duplicate.

Sign in to view

aduh95 added 3 commits September 19, 2024 13:04

fixup! url: handle "unsafe" characters properly in pathToFileURL

27b6477

replaceAll

fixup! url: handle "unsafe" characters properly in pathToFileURL

fcfd1f7

fastest alternative

fixup! fixup! url: handle "unsafe" characters properly in `pathToFile…

94ce4a2

…URL`

aduh95 force-pushed the path2fileURL-unsafe-chars branch from 4aa41b2 to 94ce4a2 Compare September 19, 2024 11:06

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024

fixup! url: handle "unsafe" characters properly in pathToFileURL

8e2ebb9

fixup! url: handle "unsafe" characters properly in pathToFileURL

dcb75fa

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024

mcollina approved these changes Oct 15, 2024

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 18, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2024

nodejs-github-bot merged commit 7ae193d into nodejs:main Oct 18, 2024
63 checks passed

This was referenced Oct 20, 2024

url: refactor pathToFileURL to native #55476

Merged

V23.1.0 proposal #55513

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

url: handle "unsafe" characters properly in `pathToFileURL` #54545

url: handle "unsafe" characters properly in `pathToFileURL` #54545

aduh95 commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

codecov bot commented Aug 24, 2024 •

edited

Loading

This comment was marked as outdated.

targos commented Aug 25, 2024

EarlyRiser42 commented Aug 25, 2024 •

edited

Loading

This comment was marked as outdated.

aduh95 commented Aug 25, 2024 •

edited

Loading

aduh95 commented Aug 25, 2024 •

edited

Loading

anonrig left a comment

aduh95 commented Aug 25, 2024

This comment was marked as duplicate.

aduh95 commented Aug 26, 2024 •

edited

Loading

aduh95 commented Aug 26, 2024 •

edited

Loading

This comment was marked as duplicate.

aduh95 commented Aug 27, 2024 •

edited

Loading

aduh95 commented Aug 27, 2024 •

edited

Loading

aduh95 commented Aug 27, 2024 •

edited

Loading

EarlyRiser42 commented Aug 27, 2024

nodejs-github-bot commented Sep 19, 2024

joyeecheung commented Sep 19, 2024 •

edited

Loading

joyeecheung commented Sep 19, 2024 •

edited

Loading

aduh95 commented Sep 19, 2024

nodejs-github-bot commented Sep 20, 2024

jasnell commented Sep 21, 2024

mcollina left a comment

nodejs-github-bot commented Oct 15, 2024

nodejs-github-bot commented Oct 17, 2024

nodejs-github-bot commented Oct 18, 2024

url: handle "unsafe" characters properly in pathToFileURL #54545

url: handle "unsafe" characters properly in pathToFileURL #54545

Conversation

aduh95 commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

codecov bot commented Aug 24, 2024 • edited Loading

Codecov Report

This comment was marked as outdated.

targos commented Aug 25, 2024

EarlyRiser42 commented Aug 25, 2024 • edited Loading

This comment was marked as outdated.

aduh95 commented Aug 25, 2024 • edited Loading

aduh95 commented Aug 25, 2024 • edited Loading

anonrig left a comment

Choose a reason for hiding this comment

aduh95 commented Aug 25, 2024

This comment was marked as duplicate.

aduh95 commented Aug 26, 2024 • edited Loading

aduh95 commented Aug 26, 2024 • edited Loading

This comment was marked as duplicate.

aduh95 commented Aug 27, 2024 • edited Loading

aduh95 commented Aug 27, 2024 • edited Loading

aduh95 commented Aug 27, 2024 • edited Loading

EarlyRiser42 commented Aug 27, 2024

nodejs-github-bot commented Sep 19, 2024

joyeecheung commented Sep 19, 2024 • edited Loading

joyeecheung commented Sep 19, 2024 • edited Loading

aduh95 commented Sep 19, 2024

nodejs-github-bot commented Sep 20, 2024

jasnell commented Sep 21, 2024

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 15, 2024

nodejs-github-bot commented Oct 17, 2024

nodejs-github-bot commented Oct 18, 2024

url: handle "unsafe" characters properly in `pathToFileURL` #54545

url: handle "unsafe" characters properly in `pathToFileURL` #54545

codecov bot commented Aug 24, 2024 •

edited

Loading

EarlyRiser42 commented Aug 25, 2024 •

edited

Loading

aduh95 commented Aug 25, 2024 •

edited

Loading

aduh95 commented Aug 25, 2024 •

edited

Loading

aduh95 commented Aug 26, 2024 •

edited

Loading

aduh95 commented Aug 26, 2024 •

edited

Loading

aduh95 commented Aug 27, 2024 •

edited

Loading

aduh95 commented Aug 27, 2024 •

edited

Loading

aduh95 commented Aug 27, 2024 •

edited

Loading

joyeecheung commented Sep 19, 2024 •

edited

Loading

joyeecheung commented Sep 19, 2024 •

edited

Loading