test_runner: add mock timers for nodeTimers.promises.scheduler.wait #55244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ErickWendel
force-pushed
the
test-runner/mock-timers-add-scheduler-wait
branch
2 times, most recently
from
559ff1f
to
c240668
Compare
RedYetiDev
added
the
timers
|
@ErickWendel I've unassigned you from the PR as there's really no need for assignments, you're the author. |
ErickWendel
force-pushed
the
test-runner/mock-timers-add-scheduler-wait
branch
from
c240668
to
efbe21f
Compare
benjamingr
approved these changes
Oct 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55244 +/- ##
==========================================
+ Coverage 88.39% 88.41% +0.02%
==========================================
Files 652 652
Lines 186565 186881 +316
Branches 36046 36065 +19
==========================================
+ Hits 164916 165237 +321
+ Misses 14908 14891 -17
- Partials 6741 6753 +12
|
atlowChemi
approved these changes
Oct 13, 2024
|
Does this need docs? |
github-actions
bot
removed
the
request-ci
I don't think so. In the current docs just say that all timers from node:timers are covered (in my initial code I put the list, but it was updated after removing it) |
jasnell
approved these changes
Oct 13, 2024
This adds support for nodetimers.promises.scheduler.wait on Mocktimers Refs: nodejs#55244
ErickWendel
force-pushed
the
test-runner/mock-timers-add-scheduler-wait
branch
from
efbe21f
to
231f650
Compare
|
just renamed the commit according to the standards |
ErickWendel
added
request-ci
github-actions
bot
removed
the
request-ci
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55244 ✔ Done loading data for nodejs/node/pull/55244 ----------------------------------- PR info ------------------------------------ Title test_runner: add mock timers for nodeTimers.promises.scheduler.wait (#55244) Author Erick Wendel <erick.workspace@gmail.com> (@ErickWendel) Branch ErickWendel:test-runner/mock-timers-add-scheduler-wait -> nodejs:main Labels timers, needs-ci, test_runner Commits 1 - test_runner: add support for scheduler.wait on mock timers Committers 1 - Erick Wendel <erick.workspace@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55244 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55244 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: add support for scheduler.wait on mock timers ℹ This PR was created on Thu, 03 Oct 2024 01:05:28 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55244#pullrequestreview-2364320039 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55244#pullrequestreview-2364963382 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55244#pullrequestreview-2364971775 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-10-14T19:24:25Z: https://ci.nodejs.org/job/node-test-pull-request/63102/ - Querying data for job/node-test-pull-request/63102/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11344079867 |
github-actions
bot
removed
the
request-ci
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/55244 ✔ Done loading data for nodejs/node/pull/55244 ----------------------------------- PR info ------------------------------------ Title test_runner: add mock timers for nodeTimers.promises.scheduler.wait (#55244) Author Erick Wendel <erick.workspace@gmail.com> (@ErickWendel) Branch ErickWendel:test-runner/mock-timers-add-scheduler-wait -> nodejs:main Labels timers, needs-ci, test_runner Commits 1 - test_runner: add support for scheduler.wait on mock timers Committers 1 - Erick Wendel <erick.workspace@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55244 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55244 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: add support for scheduler.wait on mock timers ℹ This PR was created on Thu, 03 Oct 2024 01:05:28 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/55244#pullrequestreview-2364320039 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55244#pullrequestreview-2364963382 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55244#pullrequestreview-2364971775 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-15T15:33:07Z: https://ci.nodejs.org/job/node-test-pull-request/63118/ - Querying data for job/node-test-pull-request/63118/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11350662769 |
nodejs-github-bot
added
the
commit-queue-failed
RafaelGSS
approved these changes
Oct 15, 2024
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2545b9e |
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This adds support for nodetimers.promises.scheduler.wait on Mocktimers Refs: nodejs#55244 PR-URL: nodejs#55244 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mock timers for nodeTimers.promises.scheduler.wait