-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: deflake test-cluster-shared-handle-bind-privileged-port
#55378
Merged
nodejs-github-bot
merged 3 commits into
nodejs:main
from
RedYetiDev:deflake-test-cluster-shared-handle
Oct 22, 2024
Merged
test: deflake test-cluster-shared-handle-bind-privileged-port
#55378
nodejs-github-bot
merged 3 commits into
nodejs:main
from
RedYetiDev:deflake-test-cluster-shared-handle
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Oct 13, 2024
RedYetiDev
added
cluster
Issues and PRs related to the cluster subsystem.
linux
Issues and PRs related to the Linux platform.
labels
Oct 13, 2024
jasnell
reviewed
Oct 13, 2024
jasnell
approved these changes
Oct 13, 2024
RedYetiDev
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Oct 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55378 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 652 652
Lines 186792 186878 +86
Branches 36052 36064 +12
=======================================
+ Hits 165146 165235 +89
+ Misses 14898 14889 -9
- Partials 6748 6754 +6 |
gireeshpunathil
approved these changes
Oct 14, 2024
lpinca
approved these changes
Oct 14, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 14, 2024
anonrig
reviewed
Oct 14, 2024
test/parallel/test-cluster-shared-handle-bind-privileged-port.js
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 15, 2024
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 20, 2024
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Oct 20, 2024
Commit Queue failed- Loading data for nodejs/node/pull/55378 ✔ Done loading data for nodejs/node/pull/55378 ----------------------------------- PR info ------------------------------------ Title test: deflake `test-cluster-shared-handle-bind-privileged-port` (#55378) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:deflake-test-cluster-shared-handle -> nodejs:main Labels cluster, test, author ready, needs-ci, linux, commit-queue-squash Commits 3 - test: deflake `test-cluster-shared-handle-bind-privileged-port` - fixup! add comments - fixup! fixup! add comments Committers 2 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/55378 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55378 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! fixup! add comments ℹ This PR was created on Sun, 13 Oct 2024 18:13:43 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55378#pullrequestreview-2364972050 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/55378#pullrequestreview-2365220639 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55378#pullrequestreview-2367305674 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-16T19:40:57Z: https://ci.nodejs.org/job/node-test-pull-request/63146/ - Querying data for job/node-test-pull-request/63146/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11423871231 |
RedYetiDev
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Oct 20, 2024
aduh95
approved these changes
Oct 22, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 22, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 22, 2024
Landed in d3526af |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55378 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55378 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
cluster
Issues and PRs related to the cluster subsystem.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
linux
Issues and PRs related to the Linux platform.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Linux systems (not reproducible in CI, but reproducible locally), this test will fail because the port 42 is not priviledged. For example, on my Kali Linux installation: