Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake test-cluster-shared-handle-bind-privileged-port #55378

Merged

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Oct 13, 2024

On some Linux systems (not reproducible in CI, but reproducible locally), this test will fail because the port 42 is not priviledged. For example, on my Kali Linux installation:

└─$ out/Release/node test/parallel/test-cluster-shared-handle-bind-privileged-port.js
node:assert:137
  throw err;
  ^

AssertionError [ERR_ASSERTION]: listen should have failed at test/parallel/test-cluster-shared-handle-bind-privileged-port.js:51
    at Server.mustNotCall (test/common/index.js:557:12)
    at Object.onceWrapper (node:events:621:28)
    at Server.emit (node:events:519:35)
    at emitListeningNT (node:net:1948:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:89:21) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: undefined,
  operator: 'fail'
}

Node.js v23.0.0-pre
node:assert:90
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at Worker.<anonymous> (test/parallel/test-cluster-shared-handle-bind-privileged-port.js:47:12)
    at Worker.<anonymous> (test/common/index.js:491:15)
    at Worker.emit (node:events:507:28)
    at ChildProcess.<anonymous> (node:internal/cluster/primary:187:12)
    at Object.onceWrapper (node:events:622:26)
    at ChildProcess.emit (node:events:507:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}

Node.js v23.0.0-pre

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 13, 2024
@RedYetiDev RedYetiDev added cluster Issues and PRs related to the cluster subsystem. linux Issues and PRs related to the Linux platform. labels Oct 13, 2024
@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (ac49b20) to head (4da9010).
Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55378   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         652      652           
  Lines      186792   186878   +86     
  Branches    36052    36064   +12     
=======================================
+ Hits       165146   165235   +89     
+ Misses      14898    14889    -9     
- Partials     6748     6754    +6     

see 34 files with indirect coverage changes

@RedYetiDev RedYetiDev added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2024
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63146/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 20, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/55378
✔  Done loading data for nodejs/node/pull/55378
----------------------------------- PR info ------------------------------------
Title      test: deflake `test-cluster-shared-handle-bind-privileged-port` (#55378)
Author     Aviv Keller <redyetidev@gmail.com> (@RedYetiDev)
Branch     RedYetiDev:deflake-test-cluster-shared-handle -> nodejs:main
Labels     cluster, test, author ready, needs-ci, linux, commit-queue-squash
Commits    3
 - test: deflake `test-cluster-shared-handle-bind-privileged-port`
 - fixup! add comments
 - fixup! fixup! add comments
Committers 2
 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/55378
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55378
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fixup! fixup! add comments
   ℹ  This PR was created on Sun, 13 Oct 2024 18:13:43 GMT
   ✔  Approvals: 3
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55378#pullrequestreview-2364972050
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/55378#pullrequestreview-2365220639
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55378#pullrequestreview-2367305674
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-16T19:40:57Z: https://ci.nodejs.org/job/node-test-pull-request/63146/
- Querying data for job/node-test-pull-request/63146/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11423871231

@RedYetiDev RedYetiDev removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 20, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit d3526af into nodejs:main Oct 22, 2024
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d3526af

aduh95 pushed a commit that referenced this pull request Oct 23, 2024
PR-URL: #55378
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55378
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55378
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. linux Issues and PRs related to the Linux platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants