esm: fix inconsistency with importAssertion in resolve hook #55365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
yesmeck
force-pushed
the
alias-import-assertion-for-resolve-hook
branch
from
8530577
to
b923ecb
Compare
aduh95
approved these changes
Oct 13, 2024
yesmeck
force-pushed
the
alias-import-assertion-for-resolve-hook
branch
from
b923ecb
to
213c6eb
Compare
|
Updated the commit message and fixed the lint issue. |
yesmeck
force-pushed
the
alias-import-assertion-for-resolve-hook
branch
from
213c6eb
to
0a3ceda
Compare
|
Fixed |
As the [documentation](https://nodejs.org/docs/latest/api/module.html#customization-hooks:~:text=The%20property%20context.importAssertions%20is%20replaced%20with%20context.importAttributes.%20Using%20the%20old%20name%20is%20still%20supported%20and%20will%20emit%20an%20experimental%20warning.) says, the `context.importAssertion` should be still supported and emit a warning. This is true for the load hook, but not correct for context of the resolve hook. This PR is tring to fix the inconsistency.
yesmeck
force-pushed
the
alias-import-assertion-for-resolve-hook
branch
from
0a3ceda
to
78cfeef
Compare
|
Made a minor change to the test of the load hook to make it consistent with the test of the resolve hook. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55365 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 652 652
Lines 186777 186889 +112
Branches 36029 36067 +38
==========================================
+ Hits 165114 165243 +129
+ Misses 14919 14886 -33
- Partials 6744 6760 +16
|
yesmeck
changed the title
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Oct 15, 2024
|
Landed in c0aebed |
yesmeck
changed the title
aduh95
pushed a commit
that referenced
this pull request
Oct 19, 2024
As the documentation states, the `context.importAssertion` should be still supported and emit a warning. This is true for the `load` hook, but not correct for context of the `resolve` hook. This commit fixes the inconsistency. PR-URL: #55365 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
As the documentation states, the `context.importAssertion` should be still supported and emit a warning. This is true for the `load` hook, but not correct for context of the `resolve` hook. This commit fixes the inconsistency. PR-URL: nodejs#55365 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the documentation says, the
context.importAssertionsshould be still supported and emit a warning. This is true for the load hook, but not correct for context of the resolve hook.This PR is tring to fix the inconsistency.