-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: switch from Get/SetPrototype
to Get/SetPrototypeV2
#55453
src: switch from Get/SetPrototype
to Get/SetPrototypeV2
#55453
Conversation
Review requested:
|
3c386ed
to
d624c19
Compare
GetPrototype
to GetPrototypeV2
Get/SetPrototype
to Get/SetPrototypeV2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55453 +/- ##
=======================================
Coverage 88.40% 88.41%
=======================================
Files 653 653
Lines 187600 187507 -93
Branches 36117 36104 -13
=======================================
- Hits 165854 165784 -70
+ Misses 14974 14959 -15
+ Partials 6772 6764 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be noted that v8 may end up renaming this back to SetPrototype
and GetPrototype
later once the original version is removed.
Landed in e4ca097 |
PR-URL: #55453 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55453 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Ref #55452
GetPrototype
has been deprecated in favor ofGetPrototypeV2
. See https://issues.chromium.org/issues/333672197