Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix typos #55061

Merged
merged 8 commits into from
Oct 15, 2024
Merged

tools: fix typos #55061

merged 8 commits into from
Oct 15, 2024

Conversation

NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • exected
  • middelware
  • suppresions
  • taget
  • paraghraph
  • overlayed
  • configuation
  • collapsable
  • curren
  • eror
  • fiter
  • reponsible
  • seperator
  • varible
  • vertial

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Sep 22, 2024
aduh95
aduh95 reviewed Sep 22, 2024
View reviewed changes
tools/cpplint.py Outdated
@@ -1040,7 +1040,7 @@ def ParseNolintSuppressions(filename, raw_line, linenum, error):
'Unknown NOLINT error category: %s' % category)


def ProcessGlobalSuppresions(lines):
def ProcessGlobalSuppressions(lines):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be upstreamed https://github.com/cpplint/cpplint/blob/b29d3ee08e5ba1585506f220e588e2d2907f3bf7/cpplint.py#L1114

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the upstream, it looks like they redirect the typo to the correct function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok approving the PR if the update to tools/cpplint.py was removed. I think that one should be in a separate PR which would be to sync the file with the current ccplint upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, FWIW those typos are already fixed upstream and were released just two days ago in cpplint v2.0.0.

RedYetiDev
RedYetiDev reviewed Sep 22, 2024
View reviewed changes
tools/github_reporter/index.js Outdated Show resolved Hide resolved
tools/gyp/docs/Hacking.md Outdated Show resolved Hide resolved
@NathanBaulch NathanBaulch mentioned this pull request Sep 22, 2024
Merged
RedYetiDev
RedYetiDev reviewed Sep 23, 2024
View reviewed changes
tools/icu/patches/75/source/tools/genccode/genccode.c Outdated Show resolved Hide resolved
tools/inspector_protocol/code_generator.py Outdated Show resolved Hide resolved
tools/lint-md/lint-md.mjs Outdated Show resolved Hide resolved
@NathanBaulch NathanBaulch force-pushed the typos-tools branch 2 times, most recently from f8d35d0 to a0e1c0d Compare September 23, 2024 21:53
@RedYetiDev RedYetiDev added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed i18n-api Issues and PRs related to the i18n implementation. gyp Issues and PRs related to the GYP tool and .gyp build files icu Issues and PRs related to the ICU dependency. labels Sep 23, 2024
targos
targos approved these changes Oct 9, 2024
View reviewed changes
tools/gen_node_def.cc Outdated Show resolved Hide resolved
@NathanBaulch @targos
Update tools/gen_node_def.cc
4f32733 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63109/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63111/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0f375db into nodejs:main Oct 15, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0f375db

@NathanBaulch NathanBaulch deleted the typos-tools branch October 15, 2024 20:27
aduh95 pushed a commit that referenced this pull request Oct 19, 2024
@NathanBaulch @aduh95
tools: fix typos
3b2b3a8 
PR-URL: #55061
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@NathanBaulch @louwers
tools: fix typos
06fa705 
PR-URL: nodejs#55061
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@aduh95 aduh95 aduh95 left review comments

@RedYetiDev RedYetiDev RedYetiDev left review comments

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NathanBaulch @nodejs-github-bot @lpinca @targos @mhdawson @aduh95 @RedYetiDev