-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: migrate process.binding to internalBinding for misc. #24952
test: migrate process.binding to internalBinding for misc. #24952
Conversation
Thanks for the insight. Reverted back to |
test/parallel/test-child-process-spawnsync-validation-errors.js
Outdated
Show resolved
Hide resolved
Thanks for the feedback, @joyeecheung. Updated per suggestions. Please review again at convenience. |
Hi reviewer(s), Following up on this PR w. a rebase, and ran into "make lint" error:
The source of
Is there any suggestion how to resolve this (The error shows "Unused", which seems to be a removal. But want to confirm w. your help. Thank you in advance!) |
@BeniCheni I think you'll need #25395. |
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: nodejs#24952 PR-URL: nodejs#25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Hi reviewer(s), friendly reminder rebased after #25395, and CI is “green” again to further review. Thanks! |
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: #24952 PR-URL: #25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: nodejs#24952 PR-URL: nodejs#25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Hello, reviewer(s), Trying to follow up with this pending PR by rebasing & passing the CI by the commit to bring the PR up-to-date. Please review at convenience, or let me that if this PR is not needed. I'll be happy to close it as well. |
test/parallel/test-child-process-spawnsync-validation-errors.js
Outdated
Show resolved
Hide resolved
Per @BridgeAR’s comment ☝️, removed the unused flag. Thanks. |
test/parallel/test-process-binding-internalbinding-whitelist.js
Outdated
Show resolved
Hide resolved
Looks like there is one failing test now when compiling with |
The fixup is pretty simple, doing the same we already do for |
(The without ssl variant build (nodejs/build#1574) was only enabled in the last few days which is why it didn't show up in previous CI runs. This is exactly the kind of thing it's designed to catch.) |
Landed in 53d4e04 🎉 |
Migrate various modules from using process.binding to internalBinding. PR-URL: nodejs#24952 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
I updated the commit message while landing. |
Migrate various modules from using process.binding to internalBinding. PR-URL: nodejs#24952 Refs: nodejs#22160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Hi, bit unrelated but does this mean there won't be a way anymore to access |
@davalapar Eventually, yes. There shouldn’t be anything on that object that isn’t available through public APIs, and there are no stability guarantess about the contents of |
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: #24952 PR-URL: #25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: #24952 PR-URL: #25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: #24952 PR-URL: #25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Refs #22160
For the migrated modules from the checklist of #22160, this PR identifies the places of source code & tests with "legacy"
process.binding
, and follows up to migrate tointernalBinding
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes