Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove usage of process.binding() #26304

Closed
wants to merge 2 commits into from
Closed

test: remove usage of process.binding() #26304

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

This paves the way for adding --pending-deprecation support for process.binding(), see e.g. addaleax/node@8e6577d (which could land after this, but would likely be semver-major).

Prefer internalBinding or other equivalents over process.binding()
(except in tests checking process.binding() itself).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Feb 25, 2019
Trott
Trott approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RS-ish LGTM

BridgeAR
BridgeAR approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. AFAIK there is a conflicting PR open for a while.

@BridgeAR
Copy link
Member

Refs: #24952

@addaleax
Copy link
Member Author

@BridgeAR Yeah, thanks. I’ll try to land that one first.

@addaleax addaleax added blocked PRs that are blocked by other issues or PRs. and removed async_hooks Issues and PRs related to the async hooks subsystem. labels Feb 26, 2019
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label Mar 7, 2019
@addaleax
test: remove usage of process.binding()
8c99173 
Prefer `internalBinding` or other equivalents over `process.binding()`
(except in tests checking `process.binding()` itself).
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

Rebased, new CI: https://ci.nodejs.org/job/node-test-pull-request/21296/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

Fixed one more error that just (?) showed up, CI: https://ci.nodejs.org/job/node-test-pull-request/21297/

@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21305/

@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

Landed in aec3447

@addaleax addaleax closed this Mar 7, 2019
@addaleax addaleax deleted the no-process-binding-tests branch March 7, 2019 16:50
pull bot pushed a commit to SimenB/node that referenced this pull request Mar 7, 2019
@addaleax
test: remove usage of process.binding()
aec3447 
Prefer `internalBinding` or other equivalents over `process.binding()`
(except in tests checking `process.binding()` itself).

PR-URL: nodejs#26304
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@addaleax @BridgeAR
test: remove usage of process.binding()
8c087d2 
Prefer `internalBinding` or other equivalents over `process.binding()`
(except in tests checking `process.binding()` itself).

PR-URL: nodejs#26304
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@addaleax @BridgeAR
test: remove usage of process.binding()
71a4b24 
Prefer `internalBinding` or other equivalents over `process.binding()`
(except in tests checking `process.binding()` itself).

PR-URL: #26304
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zelaznogydna91 zelaznogydna91 zelaznogydna91 approved these changes

@asarmiento13315 asarmiento13315 asarmiento13315 approved these changes

@Puzzle9900 Puzzle9900 Puzzle9900 approved these changes

@alejunco alejunco alejunco approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.