test: add PASS to outcomes in debug mode #25698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
added
tools
|
I'll take a look at the code to see if it makes sense to make this change in code and not in configuration... |
addaleax
approved these changes
Jan 28, 2019
|
Thank you, I just stumbled over this myself :) |
jasnell
approved these changes
Jan 29, 2019
Currently, when configuring with --debug there is a lot of output from tests that use console.log. I believe that this was not the case prior to commit deaddd2 ("tools,test: add list of slow tests"). The motivation for this commit is that I find it difficult to distinguish real errors from tests that log errors when running in debug mode. This commit updates test/root.status to also include a PASS status so that this output is not displayed. If a tests fails then running the test directly will show the output.
danbev
added
the
author ready
|
@refack Did you get a chance to look at a code change for this? If not, could we land this and perhaps you could follow up separate PR? |
|
@richardlau Thanks, closing this favour of #25868 |
|
H/T to @hashseed to following up (while reading my mind) |
refack
added
superseded
and removed
author ready
|
Ran into this while testing my gn build :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when configuring with
--debugthere is a lot of output fromtests that use console.log. I believe that this was not the case prior
to commit deaddd2 ("tools,test: add list of slow tests").
The motivation for this commit is that I find it difficult to
distinguish real errors from tests that log errors when running in debug
mode. This commit updates test/root.status to also include a PASS status
so that this output is not displayed. If a tests fails then running the
test directly will show the output.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes