Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: do not fail SLOW tests if they are not slow #25868

Closed
wants to merge 1 commit into from
Closed

test: do not fail SLOW tests if they are not slow #25868

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented Feb 1, 2019

Make SLOW imply PASS.

Refs: #25867

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@hashseed hashseed requested review from refack and addaleax February 1, 2019 12:33
@nodejs-github-bot
Copy link
Collaborator

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2481/pipeline

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Feb 1, 2019
@richardlau richardlau mentioned this pull request Feb 1, 2019
Closed
2 tasks
@addaleax
Copy link
Member

addaleax commented Feb 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20546/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2019
@hashseed
Copy link
Member Author

hashseed commented Feb 4, 2019

Looks like some Jenkins related issue?

@refack
Copy link
Contributor

refack commented Feb 4, 2019 •
edited
Loading

Looks like some Jenkins related issue?

Should be solved.
Resume: https://ci.nodejs.org/job/node-test-pull-request/20562/ ✔️

@refack refack added landed and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 4, 2019
@refack
Copy link
Contributor

refack commented Feb 4, 2019

Landed in dfe5f8f

@refack refack closed this Feb 4, 2019
refack pushed a commit that referenced this pull request Feb 4, 2019
@hashseed @refack
test: do not fail SLOW tests if they are not slow
dfe5f8f 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@hashseed @addaleax
test: do not fail SLOW tests if they are not slow
025a7c3 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@hashseed hashseed deleted the slowtests branch February 15, 2019 12:49
@richardlau richardlau mentioned this pull request Dec 2, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Dec 4, 2019
@hashseed @BethGriggs
test: do not fail SLOW tests if they are not slow
fabbc76 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@hashseed @MylesBorins
test: do not fail SLOW tests if they are not slow
7e941eb 
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggs BethGriggs mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hashseed @nodejs-github-bot @addaleax @refack @danbev @richardlau @devsnek @BethGriggs