modules: do not share the internal require function with public loaders #26549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes
NativeModule.require
andNativeModule.requireWithFallbackInDeps
. The public loaders nowhave to use a special method
NativeModule.prototype.compileForPublicLoader()
to compile nativemodules. In addition this patch moves the decisions of proxifying
exports and throwing unknown builtin errors entirely to public
loaders, and skip those during internal use - therefore
loaders.js
,which is compiled during bootstrap, no longer needs to be aware of
the value of
--experimental-modules
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes