Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: do not share the internal require function with public loaders #26549

Closed
wants to merge 1 commit into from
Closed

modules: do not share the internal require function with public loaders #26549

wants to merge 1 commit into from

Commits on Mar 18, 2019

  1. modules: do not share the internal require function with public loaders 

    This patch removes `NativeModule.require` and
`NativeModule.requireWithFallbackInDeps`. The public loaders now
have to use a special method
`NativeModule.prototype.compileForPublicLoader()` to compile native
modules. In addition this patch moves the decisions of proxifying
exports and throwing unknown builtin errors entirely to public
loaders, and skip those during internal use - therefore `loaders.js`,
which is compiled during bootstrap, no longer needs to be aware of
the value of `--experimental-modules`.
    @joyeecheung
    joyeecheung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    df42c60 View commit details
    Browse the repository at this point in the history