process: deprecate toStringTag assignment

[guybedford]

As a follow-on to #26488 this makes writing to process[Symbol.toStringTag] a full deprecation in Node.js.

Most intrinsics with Symbol.toStringTag set (eg Promise.prototype), have this as non-writeable, so it seems to make sense that process should do the same.

I'm not strongly set on this by any means either if anyone has reasons against it (perhaps the warnings will turn out more annoying than the strict error previously!).

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@guybedford build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2943/pipeline

[addaleax]

perhaps the warnings will turn out more annoying than the strict error previously!

Yeah, that’s what I’d expect. If we do want to change this, I’d prefer a clean break.

[targos]

I'm a bit reluctant to land this before Node 12. This will break a lot of projects that are not using the latest version of Jest.

[vsemozhetbyt]

1. This seems to break other deprecation section without adding its own description.
2. We usually assign a placeholder DEP0XXX till landing.
3. PR URL should be https://github.com/nodejs/node/pull/26717

[guybedford]

I'm a bit reluctant to land this before Node 12. This will break a lot of projects that are not using the latest version of Jest.

It would just warn them unless they update Jest yes.

[BridgeAR]

This does not seem something urgent, so I suggest to postpone landing this after v12. I am fine with a deprecation warning or a clean break, what ever others feel like is best in this case.

[guybedford]

@BridgeAR agreed, that makes sense.

I won't continue to push this - shall we leave it open for anyone to pick up in future, or shall I just close?

[BridgeAR]

The release is not that far, so I just marked this as blocked.

[antsmartian]

@guybedford @BridgeAR Looks like this is something that we can unblock now and get it to a closure?

[BridgeAR]

@guybedford is this something you would like to continue pursuing? This is definitely unblocked by now. It needs a rebase though.

[HarshithaKP]

@guybedford, This need a rebase and can you progress on this now ? are you able to make progress ?

[guybedford]

This one has dropped off my radar, closing but someone else is welcome to pick it up.