Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-fs-writeFileSync-invalid-windows #28569

Merged
merged 1 commit into from
Jul 11, 2019
Merged

test: add test-fs-writeFileSync-invalid-windows #28569

merged 1 commit into from
Jul 11, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 5, 2019

Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the fs
module when an invalid path is used.

Refs: #8987

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 5, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24293/

@lpinca
Copy link
Member

lpinca commented Jul 9, 2019

Why it fails when skipped?

@Trott
Copy link
Member Author

Trott commented Jul 10, 2019

Why it fails when skipped?

Because known_issues tests are expected to fail. At least one other test uses assert.fail() instead of common.skip() and includes a comment that says to change it to common.skip() when the issue is resolved and the test is moved out of known_issues. So I'll probably do that with this test.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24357/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 10, 2019
@Trott
test: add test-fs-writeFileSync-invalid-windows
b6e301a 
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the `fs`
module when an invalid path is used.

Refs: nodejs#8987

PR-URL: nodejs#28569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member Author

Trott commented Jul 11, 2019

Landed in b6e301a

@Trott Trott merged commit b6e301a into nodejs:master Jul 11, 2019
@Trott Trott deleted the known-8987 branch July 11, 2019 17:30
targos pushed a commit that referenced this pull request Jul 20, 2019
@Trott @targos
test: add test-fs-writeFileSync-invalid-windows
b4643dd 
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the `fs`
module when an invalid path is used.

Refs: #8987

PR-URL: #28569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Closed
Merged
@vtjnash vtjnash mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @lpinca @cjihrig @BridgeAR