v12.7.0 release proposal #28816
Closed
v12.7.0 release proposal #28816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #28189 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #28189 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The closing paren was missing. Move to using commas instead. PR-URL: #28483 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
If a top level module is listed as Stable, there is no need to call out individual components of that module as Stable. The extra text is just distracting. PR-URL: #28485 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #28481 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #28504 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The pointer used to hold an incoming dynamically loaded module's `node::node_module` structure needs to be thread-local. So far this was done with `uv_key_set()` and `uv_key_get()`. The language now supports the `thread_local` keyword which makes implementing this a lot cleaner. PR-URL: #28456 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit adds an assertion checking the exact field names returned by process.resourceUsage(). This ensures that no new fields accidentally slip into the returned object in the future. PR-URL: #28498 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This change adds the ability to set the memory ceiling for a Node.js process according to a memory limit set by cgroups (via uv_get_constrained_memory), which is used by docker containers to set resource constraints. Previously we would use the physical memory size to estimate the necessary V8 heap sizes, but the physical memory size is not necessarily the correct limit, e.g. if the process is running inside a docker container or is otherwise constrained. Non-Linux systems shouldn't be affected. PR-URL: #27508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
The implementation of _getDisplayPos, used to compute the cursor position and to find out how many lines to clear up when re-rendering the readline output, was counting each line (except the last one) from the input as one row, even if they were wraping. This caused some rendering issues when the 'prompt' have at least one wide line ending with a newline char, duplicating the lines at the top of the prompt when calling _refreshLine (ex: when the user hits backspace). This patch fixes the issue by computing the real rows count for each new line in the input string. PR-URL: #28272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #28395 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
PR-URL: #28383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Provided a small example along its output using fs.stat() to check the stats on two different paths, one a directory and the other a txt file. PR-URL: #28381 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28365 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #28356 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit removes the now obsolete option. PR-URL: #28446 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add SKIP status for more tests in stringbytes-external-exceed-max that are failing on AIX. PR-URL: #28516 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
See: nodejs/build#1820 PR-URL: #28541 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merge options list with its description to reduce redundancy (some possible typos were also fixed and some periods added). PR-URL: #28499 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The test has not failed on FreeBSD in the last 100 runs and appears to perhaps not be an issue anymore. Closes: #23089 test-gc-http-client-onerror: PASS,FLAKY PR-URL: #28429 Fixes: #23089 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This test currently fails if run as root:
npm ERR! makeDirectory homeless?
npm WARN install-dir No description
npm WARN install-dir No repository field.
npm WARN install-dir No license field.
npm ERR! path /root/node/test/.tmp.0/npm-sandbox/home
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall stat
npm ERR! enoent ENOENT:
no such file or directory,
stat '/root/node/test/.tmp.0/npm-sandbox/home'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
assert.js:89
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: npm install got error code 254
at handleExit (/root/node/test/parallel/test-npm-install.js:60:10)
at /root/node/test/common/index.js:371:15
at ChildProcess.exithandler (child_process.js:304:5)
at ChildProcess.emit (events.js:203:13)
at maybeClose (internal/child_process.js:1028:16)
at Process.ChildProcess._handle.onexit
(internal/child_process.js:283:5) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: 254,
expected: 0,
operator: 'strictEqual'
}
The home directory will be created as expected by npm in the npmSandbox
when run as non-root, but when run as root this directory has to exist.
This commit creates the home directory to allow the test to pass also
when run as the root user.
Refs:https://github.com/npm/cli/blob/
31718e72cb5a03cee7127fc36843e4b55c868d93/
lib/utils/correct-mkdir.js#L82-L105
PR-URL: #28510
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #28506 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
`crypto.fips` was deprecated in commit 6e7992e ("crypto: docs-only deprecate crypto.fips, replace") but its usage in `common.hasFipsCrypto` seems to have been overlooked. PR-URL: #28509 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #28521 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Include the library-provided reason in the Error’s `message`. Fixes: #28468 PR-URL: #28487 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
My node distribution uses a shared openssl library with some ciphers disabled, including RC2. These tests (which use `rsa_cert.pfx`) fail with `unknown cipher`: - parallel/test-crypto-binary-default - parallel/test-https-pfx - parallel/test-crypto The other fixture .pfx's use the `-descert` option, I don't know if rsa_cert.pfx was generated without `-descert` intentionally or not but none of the tests reference RC2, and the tests pass with a des cert. I'm not an ssl/crypto expert, so I would appreciate any insight. Old key: ``` openssl pkcs12 -info -in test/fixtures/keys/rsa_cert.pfx -noout -passin pass:sample MAC Iteration 2048 MAC verified OK PKCS7 Encrypted data: pbeWithSHA1And40BitRC2-CBC, Iteration 2048 Certificate bag PKCS7 Data Shrouded Keybag: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048 ``` New ``` openssl pkcs12 -info -in test/fixtures/keys/rsa_cert.pfx -noout -passin pass:sample MAC Iteration 2048 MAC verified OK PKCS7 Encrypted data: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048 Certificate bag PKCS7 Data Shrouded Keybag: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048 ``` PR-URL: #28471 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #28433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #28433 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #28372 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
As KVStore has derived classes, it is essential to declare a public virtual destructor in the base KVStore class. Otherwise, deleting derived class instances using base class pointers would potentially cause undefined behaviour. Additionally, since we are implementing a non-default destructor, the special member functions have also been implemented in order to abide by the rule of five. PR-URL: #28737 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28627 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This method blocks current node process until a client sends Runtime.runifWaitingForDebugger. It can be useful when we need to report inspector.url() before waiting for connection: ``` inspector.open(0, undefined, false); fs.writeFileSync(someFileName, inspector.url()); inspector.waitForDebugger(); ``` PR-URL: #28453 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
when the readable side of a transform ends any for await loop on that transform stream should also complete. This fix prevents for await loop on a transform stream from hanging indefinitely. PR-URL: #28566 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28474 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
As node requires a tracing controller to be initialized embedders need access to the TraceEventHelper so that we can actually set the tracing controller. Refs: https://github.com/electron/electron/commit/0e5b6f93000e4718c9e35332ddbd0f6b76cdd585/#diff-89b287b2edd0a02dddae60cb26157f47 PR-URL: #28724 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28448 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit fixes the following warning: warning: missing field 'exports' initializer PR-URL: #28764 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #28776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
The pkgsrc Makefile target was removed in 2015 Refs: #1938 PR-URL: #28783 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #28774 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Original commit message:
[api] Get ScriptOrModule from CompileFunctionInContext
Adds a new out param which allows accessing the ScriptOrModule
of a function, which allows an embedder such as Node.js to use
the function's i::Script lifetime.
Refs: nodejs/node-v8#111
Change-Id: I34346d94d76e8f9b8377c97d948673f4b95eb9d5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1699698
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62830}
Refs: v8/v8@b33af60
Backport-PR-URL: #28779
PR-URL: #28671
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
In particular: - Move the class definition to the relevant header file, i.e. `node_contextify.h`. - Make sure that class instances are destroyed on `Environment` teardown. - Make instances of the key object traceable in heap dumps. This is particularly relevant here because our C++ script → map key mapping could introduce memory leaks when the import function metadata refers back to the script in some way. Refs: #28671 PR-URL: #28782 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com>
Heap dumps can be taken either through the inspector or the public API for it during an async_hooks init() hook, but at that point the AsyncWrap in question is not done initializing yet and virtual methods cannot be called on it. Address this issue (somewhat hackily) by excluding `AsyncWrap` instances which have not yet executed their `init()` hook fully from heap dumps. Fixes: #28786 PR-URL: #28789 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Update ESLint to 6.1.0 PR-URL: #28793 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-github-bot
added
build
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-07-23, Version 12.7.0 (Current), @targos
Notable changes
"exports"field canbe added to a module's
package.jsonfile to provide custom subpathaliasing. See proposal-pkg-exports
for more information (Guy Bedford) #28568.
response.writableFinished(Robert Nagy) #28681.headers,rawHeadersand other fields on anhttp.ClientRequest"information"event (Austin Wright) #28459.inspector.waitForDebugger()(Aleksei Koziatinskii) #28453.--policy-integrity=sriCLI option to mitigate policy tampering. If apolicy integrity is specified and the policy does not have that integrity,
Node.js will error prior to running any code (Bradley Farias) #28734.
#28721.
we would use the physical memory size (from libuv) to estimate the necessary V8 heap sizes. The physical memory size
is not necessarily the correct limit, e.g. if the process is running inside a docker container or is otherwise
constrained. This change adds the ability to get a memory limit set by linux cgroups, which is used by
docker containers to set resource constraints
(Kelvin Jin) #27508.
Commits
632d7d5839] - build: skip test-ci doc targets if no crypto (Rod Vagg) #287475d09c15c5b] - build: update of the large page option error (David Carlier) #28729be32becb67] - build: fix building with d8 (Michaël Zasso) #2873372f92293c8] - build: specify Python version once for all tests (cclauss) #28694b4aa7d3570] - build: remove broken intel vtune support (Ben Noordhuis) #28522171c8f44b6] - build: do not always build the default V8 snapshot (Michaël Zasso) #28467608d6ed090] - build: update Windows icon to Feb 2016 rebrand (Mike MacCana) #285247d3ddfe6b8] - build: remove --code-cache-path help option (Daniel Bevenius) #28446e4fae24b62] - build: change ASM compiler url to https (gengjiawen) #28189209b353ff4] - build,v8: support IBM i (Xu Meng) #28607674d33cb8c] - deps: V8: backport b33af60 (Gus Caplan) #286719f47242e19] - deps: update nghttp2 to 1.39.1 (gengjiawen) #284481ce2b5e828] - deps: upgrade npm to 6.10.0 (isaacs) #28525312f94916c] - deps: V8: backport d2ccc59 (Joyee Cheung) #28648df0f42ab7f] - deps: cherry-pick 91744bf from node-gyp upstream (Jon Kunkee) #286047fa982ee89] - deps: cherry-pick 721dc7d from node-gyp upstream (Jon Kunkee) #286049e9bfb65c7] - deps: cherry-pick 13a04aba from V8 upstream (Jon Kunkee) #28602c7cb70ce5e] - deps: update acorn to 6.2.0 (Michaël Zasso) #286490ee1298056] - dns: fix unsigned record values (Brian White) #287928586294670] - doc: claim NODE_MODULE_VERSION=75 for Electron 7 (Samuel Attard) #287742a82d54d9d] - doc: update env default on child_process functions (h3knix) #28776cf811ecd47] - doc: add code example to subprocess.stdout (Juan José Arboleda) #2840206991cd902] - doc: add information for heap snapshot flag (Tanner Stirrat) #287548fe9ca416d] - doc: amplify warning for execute callback (Michael Dawson) #28738ca83b2736e] - doc: add example for beforeExit event (Vickodev) #2843044acec5386] - doc: add example for zlib.createGzip() (Alex Ramirez) #281364a78fe5ab0] - doc: improve os.homedir() docs (Juan José Arboleda) #284013f78a51b5e] - doc: add examples at assert.strictEqual (himself65) #280923a4a236b51] - doc: fix minor typo (Shajan Jacob) #281484321cb2cf3] - doc: update js-native-api example (Gabriel Schulhof) #286578ddf86b3d4] - doc: add missing version metadata for Readable.from (Anna Henningsen) #28695638c8a394c] - doc: small grammar correction (cjihrig) #286695614e08f34] - doc: add documentation for createDiffieHellmanGroup (Ojasvi Monga) #28585aee86940f9] - doc: mark N-API thread-safe function stable (Gabriel Schulhof) #286437a4062ab88] - doc: mark process.report as experimental (cjihrig) #286533f65b91eb9] - doc: remove superfluous MDN link in assert.md (Rich Trott) #28246f688122dff] - doc: drop 'for more details' in deprecations (cjihrig) #28617d7c7023503] - doc: add example on how to create __filename, __dirname for esm (Walle Cyril) #28282ebc3876754] - doc: add missing types (Luigi Pinca) #28623f7a13e5034] - doc: relax requirements for setAAD in CCM mode (Tobias Nießen) #28624bf2d5a75f8] - doc: add a link to the throw-deprecations flag (Lucas Holmquist) #28625871a60cd12] - doc: fix nits in stream.md (Vse Mozhet Byt) #285910380a558af] - doc: edit stream module introduction (Rich Trott) #28595729b232d11] - doc: change 'unix' to 'Unix' in ninja guide (Rich Trott) #2861974af944de1] - doc: add line for inspect host:port invocation (Tim Baverstock) #284050aca527263] - doc: mention unit for event loop delay measurements (Jan Krems) #28629ac9908fe37] - doc: update stream.md "Organization of this Document" (Rich Trott) #286019be1111179] - doc: move Usage and Example to same header level (Rich Trott) #2857070c3116783] - doc: mention markdown linting in BUILDING.md (Tariq Ramlall) #28578f0e4bf990e] - doc: remove URLs from zlib docs (cjihrig) #28580a6d50a7562] - doc: make tls links more readable (cjihrig) #285806f3ebb8787] - doc: clarify http2 server.close() behavior (cjihrig) #285812205818cca] - doc: format Unix consistently (cjihrig) #28576643d09961b] - doc: document family:0 behavior in socket.connect (cjihrig) #28574d2ba4547aa] - doc: fix link in build instructions (Gautham B A) #2857224a77ae19a] - doc: add description for the listener argument (Luigi Pinca) #285000777e090b4] - doc: fix family default value in socket.connect (Kirill Fomichev) #2852129d2076ac7] - doc: simplifyprocess.resourceUsage()section (Vse Mozhet Byt) #28499e83b256306] - doc: add example for chmod in fs.md (Juan Roa) #28365c177a68c7f] - doc: provide an example to fs.stat() (Felipe) #2838168ed32f71d] - doc: fix link from bootstrap README to BUILDING (Rod Vagg) #2850459aaee4295] - doc: format try...catch consistently (cjihrig) #28481ec9ba4b803] - doc: remove unnecessary stability specifiers (cjihrig) #284850a0832fb52] - doc: address missing paren (cjihrig) #28483b379c0e8b6] - (SEMVER-MINOR) esm: implement "pkg-exports" proposal (Guy Bedford) #28568d630cc0ec5] - gyp: cherrypick more Python3 changes from node-gyp (cclauss) #28563b1db810d50] - gyp: pull Python 3 changes from node/node-gyp (cclauss) #28573ed8504388e] - http: avoid extra listener (Robert Nagy) #2870506d0abea0d] - (SEMVER-MINOR) http: add response.writableFinished (Robert Nagy) #286812308c7412a] - (SEMVER-MINOR) http: expose headers on an http.ClientRequest "information" event (Austin Wright) #2845938f8cd5ba1] - http: improve parser error messages (Anna Henningsen) #2848749e4d72b5a] - http2: compat req.complete (Robert Nagy) #2862762f36828be] - http2: report memory allocated by nghttp2 to V8 (Anna Henningsen) #286455b9c22710a] - http2: override authority with options (Luigi Pinca) #2858477bdbc5f0d] - (SEMVER-MINOR) inspector: add inspector.waitForDebugger() (Aleksei Koziatinskii) #284537b0b06d735] - inspector: do not spin-wait while waiting for the initial connection (Eugene Ostroukhov) #28756aba0cf33ec] - inspector: do not change async call stack depth if the worker is done (Eugene Ostroukhov) #2861366382abe29] - inspector: reduce InspectorIo API surface (Eugene Ostroukhov) #285265c100075f0] - lib: rename lib/internal/readline.js (cjihrig) #2875375c628130f] - lib: useclass ... extendsin perf_hooks.js (Anna Henningsen) #284951770bc870e] - module: increase code coverage of cjs loader (Andrey Melikhov) #278989c6791ee00] - n-api: correct bug in napi_get_last_error (Octavian Soldea) #2870244de4317cf] - n-api: make thread-safe-function calls properly (Gabriel Schulhof) #286065b5c8196c3] - path: move branch to the correct location (Ruben Bridgewater) #2855618c56df928] - path: using .relative() should not return a trailing slash (Ruben Bridgewater) #28556997531193b] - perf_hooks: add HttpRequest statistics monitoring Feature Request: Performance hooks entry for http #28445 (vmarchaud) #284862eeb44f3fa] - (SEMVER-MINOR) policy: add policy-integrity to mitigate policy tampering (Bradley Farias) #287344cb0fc3ab1] - process: refactor unhandledRejection logic (cjihrig) #28540caee9106ac] - (SEMVER-MINOR) readline: expose stream API in cursorTo() (cjihrig) #286744a7e20ff81] - (SEMVER-MINOR) readline: expose stream API in moveCursor() (cjihrig) #286740f5af44304] - (SEMVER-MINOR) readline: expose stream API in clearLine() (cjihrig) #2867417df75f5c9] - (SEMVER-MINOR) readline: expose stream API in clearScreenDown() (cjihrig) #286410383947ed7] - readline: simplify isFullWidthCodePoint() (cjihrig) #28640dc734030fc] - readline: remove IIFE in SIGCONT handler (cjihrig) #28639e0c5e7a939] - readline: use named constant for surrogate checks (cjihrig) #28638e6e98afbf2] - readline: fix position computation (Benoît Zugmeyer) #28272d611f5ad3e] - repl: fix some repl context issues (Ruben Bridgewater) #28561cbd586aa99] - repl: fix autocomplete while using .load (Ruben Bridgewater) #2860835e3f1f449] - report: modify getReport() to return an Object (Christopher Hiller) #28630302865e8b9] - src: do not include partial AsyncWrap instances in heap dump (Anna Henningsen) #28789c0f24be185] - src: makeCompiledFnEntryaBaseObject(Anna Henningsen) #287827df54988e1] - src: silence compiler warning (cjihrig) #287642839298a1e] - src: expose TraceEventHelper with NODE_EXTERN (Samuel Attard) #2872474243da707] - src: add public virtual destructor for KVStore (GauthamBanasandra) #287370b7fecaf97] - src: large pages option: FreeBSD support proposal (David Carlier) #283311f0fd1bb78] - src: add missing option parser template for the DebugOptionsParser (Samuel Attard) #285434b9d4193e1] - src: lint #defines in src/node.h (Tariq Ramlall) #285475c1d5958e0] - src: add cleanup hook for ContextifyContext (Anna Henningsen) #2863129fda66ca6] - src: simplify --debug flags (cjihrig) #28615c50e235947] - src: replace already elevated Object, Local v8 namespace (Juan José Arboleda) #286113c418d9629] - src: manage MakeContext() pointer with unique_ptr (cjihrig) #2861622daf952de] - src: clang build warning fix (David Carlier) #28480a8b094cf3b] - src: implement special member functions for classes in env.h (GauthamBanasandra) #28579c432ab1391] - src: simplify DEP0062 logic (cjihrig) #285894f035e4d84] - src: implement runtime option --no-node-snapshot for debugging (Joyee Cheung) #28567a24ab56dc5] - src: allow fatal exceptions to be enhanced (cjihrig) #28562d4113f96f5] - src: block SIGTTOU before calling tcsetattr() (Ben Noordhuis) #2853548c369b715] - src: correct json writer placement in process.report (himself65) #284338d41b07c4c] - src: remove unused using declarations in src/api (Daniel Bevenius) #285066fbad8baa4] - src: configure v8 isolate with uv_get_constrained_memory (Kelvin Jin) #27508f3f51e4187] - src: use thread_local to declare modpending (Gabriel Schulhof) #28456e610c45076] - src: remove redundant return (gengjiawen) #28189d34c2567c9] - src, tools: replace raw ptr with smart ptr (GauthamBanasandra) #285770793398b4f] - stream: add null push transform in async_iterator (David Mark Clements) #2856600b2200e03] - (SEMVER-MINOR) stream: use readableEncoding public api for child_process (ZYSzys) #28548af6fe5f4c5] - test: fix assertion argument order in test-esm-namespace (Alex Ramirez) #284747989d5c600] - test: changed function to arrow function (Harshitha KP) #2872688809a49f6] - test: propagate napi_status to JS (Octavian Soldea) #2850561db987b01] - test: use consistent test naming (Rich Trott) #28744506b50a54a] - test: make repl tests more resilient (Ruben Bridgewater) #28608af6608ca11] - test: improve variable names in pty_helper.py (Anna Henningsen) #286889b2eee12eb] - test: update hasFipsCrypto in test/common/README (Daniel Bevenius) #28507d3f51457af] - test: use openssl_is_fips instead of hasFipsCrypto (Daniel Bevenius) #28507499969db9e] - test: increase limit for network space overhead test (Ben L. Titzer) #284929f6600ac1c] - test: fix pty test hangs on aix (Ben Noordhuis) #28600b4643dd9dc] - test: add test-fs-writeFileSync-invalid-windows (Rich Trott) #28569e2adfb79b0] - test: refactor test-fs-write-sync (Gabriela Niño) #283714c333f4028] - test: change the repeat Buffer.from('blerg'); statments (Miken) #28372598037346e] - test: check getReport when error with one line stack (himself65) #28433793163e353] - test: check writeReport when error with one line stack (himself65) #28433c3311c25ff] - test: generate des rsa_cert.pfx (Caleb ツ Everett) #284714941d47212] - test: don't use deprecated crypto.fips property (Ben Noordhuis) #28509e854bfa3b1] - test: create home for test-npm-install (Daniel Bevenius) #2851013f139368f] - test: unmark test-gc-http-client-onerror flaky (Rich Trott) #28429b7731eb0e4] - test: skip pseudo-tty tests on AIX (Sam Roberts) #2854133ab37fcdb] - test: skip stringbytes-external-exceed-max on AIX (Sam Roberts) #28516f0c436ff50] - test: switch the argument order for the assertion (Ivan Villa) #2835649c533964f] - test: fix assertion argument order in test-https-agent.js (Julian Correa) #28383e4f1e909e1] - test: increase test-resource-usage.js validation (cjihrig) #28498ff432c8ef6] - test,win: cleanup exec-timeout processes (João Reis) #28723ed43880d6b] - tools: update ESLint to 6.1.0 (cjihrig) #287935eb37cccc6] - tools: remove unused pkgsrc directory (Michaël Zasso) #287839ffa5fb6b8] - tools: add coverage to ignored files (Lucas Holmquist) #28626ccb54f7a84] - tools: add markdown lint rule for 'Unix' (Rich Trott) #28619487a417dd1] - (SEMVER-MINOR) tty: expose stream API from readline methods (cjihrig) #287217b4638cee0] - vm: fix gc bug with modules and compiled functions (Gus Caplan) #28671a0e8a25721] - vm: remove usage of public util module (Karen He) #284600e2cbe6203] - worker: fix passing multiple SharedArrayBuffers at once (Anna Henningsen) #28582cbf540136f] - worker: assign missing deprecation code (James M Snell) #28395b8079f5c23] - zlib: remove usage of public util module (Karen He) #2845403de306281] - zlib: do not coalesce multiple.flush()calls (Anna Henningsen) #28520