-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2019-10-22, Version 13.0.0 (Current) #29504
Conversation
Notable changes: * TBD PR-URL: #29504
a6ecf24
to
a9fded7
Compare
CITGM (queued): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1999/ |
Results show 24 failures:
The 8 failures for serialport would be fixed by nodejs/citgm#748, but I believe will also be fixed in serialport@8 but CITGM doesn't pick that up because it's tagged The failures for zeromq might be worth the attention of the zeromq maintainers? I think I was able to replicate the problem using Node.js build from the Node.js master branch, but that was a few weeks ago and I might be misremembering. But if I'm not wrong, it might be a good idea to release a new version? (Or stop us from releasing Node.js until we back out the problematic change if that's the better path?) /ping @ronkorving @captainsafia Issue looks like this: > zeromq@5.1.0 install /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq
> node scripts/prebuild-install.js || (node scripts/preinstall.js && node-gyp rebuild)
Building libzmq for linux
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether UID '1001' is supported by ustar format... yes
checking whether GID '1001' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking whether make supports nested variables... (cached) yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking whether C compiler accepts -std=gnu11... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=gnu++11... yes
checking for a sed that does not truncate output... /bin/sed
checking whether to build with code coverage support... no
checking for a sed that does not truncate output... (cached) /bin/sed
checking for gawk... (cached) mawk
checking for pkg-config... no
checking for xmlto... no
checking for asciidoc... no
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... (cached) /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... dlltool
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -std=gnu++11 -E
checking for ld used by g++ -std=gnu++11... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ -std=gnu++11 linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ -std=gnu++11 option to produce PIC... -fPIC -DPIC
checking if g++ -std=gnu++11 PIC flag -fPIC -DPIC works... yes
checking if g++ -std=gnu++11 static flag -static works... yes
checking if g++ -std=gnu++11 supports -c -o file.o... yes
checking if g++ -std=gnu++11 supports -c -o file.o... (cached) yes
checking whether the g++ -std=gnu++11 linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for valgrind... no
checking whether the C compiler works... yes
checking whether we are using Intel C compiler... no
checking whether we are using Sun Studio C compiler... no
checking whether we are using clang C compiler... no
checking whether we are using gcc >= 4 C compiler... yes
checking whether the C++ compiler works... yes
checking whether we are using Intel C++ compiler... no
checking whether we are using Sun Studio C++ compiler... no
checking whether we are using clang C++ compiler... no
checking whether we are using gcc >= 4 C++ compiler... yes
checking whether to enable debugging information... no
checking whether to enable code coverage... no
checking if TIPC is available and supports nonblocking connect... no
checking for library containing dladdr... -ldl
checking for pthread_create in -lpthread... yes
checking for clock_gettime in -lrt... yes
checking whether C++ compiler supports -fvisibility=hidden... yes
checking whether C++ compiler supports dso visibility... yes
checking whether to build documentation... no
checking whether to install manpages... no
configure: Choosing polling system from 'kqueue epoll devpoll pollset poll select'...
configure: Using 'epoll' polling system with CLOEXEC
checking for ANSI C header files... (cached) yes
checking errno.h usability... yes
checking errno.h presence... yes
checking for errno.h... yes
checking time.h usability... yes
checking time.h presence... yes
checking for time.h... yes
checking for unistd.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking stddef.h usability... yes
checking stddef.h presence... yes
checking for stddef.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking ifaddrs.h usability... yes
checking ifaddrs.h presence... yes
checking for ifaddrs.h... yes
checking sys/uio.h usability... yes
checking sys/uio.h presence... yes
checking for sys/uio.h... yes
checking sys/eventfd.h usability... yes
checking sys/eventfd.h presence... yes
checking for sys/eventfd.h... yes
checking whether EFD_CLOEXEC is supported... yes
checking whether SO_PEERCRED is declared... yes
checking whether LOCAL_PEERCRED is declared... no
checking for stdbool.h that conforms to C99... yes
checking for _Bool... no
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for size_t... yes
checking for ssize_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking for uint32_t... yes
checking for working volatile... yes
configure: Using tweetnacl for CURVE security
checking "with_norm_ext = no"... no
checking how to enable additional warnings for C++ compiler... -Wall
checking how to turn warnings to errors in C++ compiler... -Werror
checking whether compiler supports __atomic_Xxx intrinsics... yes
checking return type of signal handlers... void
checking for perror... yes
checking for gettimeofday... yes
checking for clock_gettime... yes
checking for memset... yes
checking for socket... yes
checking for getifaddrs... yes
checking for freeifaddrs... yes
checking for fork... yes
checking for posix_memalign... yes
checking for mkdtemp... yes
checking alloca.h usability... yes
checking alloca.h presence... yes
checking for alloca.h... yes
checking whether SOCK_CLOEXEC is supported... yes
checking whether SO_KEEPALIVE is supported... yes
checking whether TCP_KEEPCNT is supported... yes
checking whether TCP_KEEPIDLE is supported... yes
checking whether TCP_KEEPINTVL is supported... yes
checking whether TCP_KEEPALIVE is supported... no
checking for ./.git... no
configure: Building stable and legacy API (no draft API)
checking for LIBUNWIND... no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/libzmq.pc
config.status: creating doc/Makefile
config.status: creating builds/Makefile
config.status: creating builds/msvc/Makefile
config.status: creating src/platform.hpp
config.status: executing depfiles commands
config.status: executing libtool commands
Making all in doc
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2'
CXX src/src_libzmq_la-address.lo
CXX src/src_libzmq_la-client.lo
CXX src/src_libzmq_la-clock.lo
CXX src/src_libzmq_la-ctx.lo
CXX src/src_libzmq_la-curve_client.lo
CXX src/src_libzmq_la-curve_server.lo
CXX src/src_libzmq_la-dealer.lo
CXX src/src_libzmq_la-devpoll.lo
CXX src/src_libzmq_la-dgram.lo
CXX src/src_libzmq_la-dish.lo
CXX src/src_libzmq_la-dist.lo
CXX src/src_libzmq_la-epoll.lo
CXX src/src_libzmq_la-err.lo
CXX src/src_libzmq_la-fq.lo
CXX src/src_libzmq_la-gather.lo
CXX src/src_libzmq_la-gssapi_mechanism_base.lo
CXX src/src_libzmq_la-gssapi_client.lo
CXX src/src_libzmq_la-gssapi_server.lo
CXX src/src_libzmq_la-io_object.lo
CXX src/src_libzmq_la-io_thread.lo
CXX src/src_libzmq_la-ip.lo
CXX src/src_libzmq_la-ipc_address.lo
CXX src/src_libzmq_la-ipc_connecter.lo
CXX src/src_libzmq_la-ipc_listener.lo
CXX src/src_libzmq_la-kqueue.lo
CXX src/src_libzmq_la-lb.lo
CXX src/src_libzmq_la-mailbox.lo
CXX src/src_libzmq_la-mailbox_safe.lo
CXX src/src_libzmq_la-mechanism.lo
CXX src/src_libzmq_la-metadata.lo
CXX src/src_libzmq_la-msg.lo
CXX src/src_libzmq_la-mtrie.lo
CXX src/src_libzmq_la-norm_engine.lo
CXX src/src_libzmq_la-null_mechanism.lo
CXX src/src_libzmq_la-object.lo
CXX src/src_libzmq_la-options.lo
CXX src/src_libzmq_la-own.lo
CXX src/src_libzmq_la-pair.lo
CXX src/src_libzmq_la-pgm_receiver.lo
CXX src/src_libzmq_la-pgm_sender.lo
CXX src/src_libzmq_la-pgm_socket.lo
CXX src/src_libzmq_la-pipe.lo
CXX src/src_libzmq_la-plain_client.lo
CXX src/src_libzmq_la-plain_server.lo
CXX src/src_libzmq_la-poll.lo
CXX src/src_libzmq_la-poller_base.lo
CXX src/src_libzmq_la-pollset.lo
CXX src/src_libzmq_la-precompiled.lo
CXX src/src_libzmq_la-proxy.lo
CXX src/src_libzmq_la-pub.lo
CXX src/src_libzmq_la-pull.lo
CXX src/src_libzmq_la-push.lo
CXX src/src_libzmq_la-radio.lo
CXX src/src_libzmq_la-random.lo
CXX src/src_libzmq_la-raw_decoder.lo
CXX src/src_libzmq_la-raw_encoder.lo
CXX src/src_libzmq_la-reaper.lo
CXX src/src_libzmq_la-rep.lo
CXX src/src_libzmq_la-req.lo
CXX src/src_libzmq_la-router.lo
CXX src/src_libzmq_la-scatter.lo
CXX src/src_libzmq_la-select.lo
CXX src/src_libzmq_la-server.lo
CXX src/src_libzmq_la-session_base.lo
CXX src/src_libzmq_la-signaler.lo
CXX src/src_libzmq_la-socket_base.lo
CXX src/src_libzmq_la-socks.lo
CXX src/src_libzmq_la-socks_connecter.lo
CXX src/src_libzmq_la-stream.lo
CXX src/src_libzmq_la-stream_engine.lo
CXX src/src_libzmq_la-sub.lo
CXX src/src_libzmq_la-tcp.lo
CXX src/src_libzmq_la-tcp_address.lo
CXX src/src_libzmq_la-tcp_connecter.lo
CXX src/src_libzmq_la-tcp_listener.lo
CXX src/src_libzmq_la-thread.lo
CXX src/src_libzmq_la-timers.lo
CXX src/src_libzmq_la-tipc_address.lo
CXX src/src_libzmq_la-tipc_connecter.lo
CXX src/src_libzmq_la-tipc_listener.lo
CXX src/src_libzmq_la-trie.lo
CXX src/src_libzmq_la-udp_address.lo
CXX src/src_libzmq_la-udp_engine.lo
CXX src/src_libzmq_la-v1_decoder.lo
CXX src/src_libzmq_la-v2_decoder.lo
CXX src/src_libzmq_la-v1_encoder.lo
CXX src/src_libzmq_la-v2_encoder.lo
CXX src/src_libzmq_la-vmci.lo
CXX src/src_libzmq_la-vmci_address.lo
CXX src/src_libzmq_la-vmci_connecter.lo
CXX src/src_libzmq_la-vmci_listener.lo
CXX src/src_libzmq_la-xpub.lo
CXX src/src_libzmq_la-xsub.lo
CXX src/src_libzmq_la-zmq.lo
CXX src/src_libzmq_la-zmq_utils.lo
CXX src/src_libzmq_la-decoder_allocators.lo
CXX src/src_libzmq_la-socket_poller.lo
CC src/src_libzmq_la-tweetnacl.lo
CXX tools/curve_keygen.o
CXX perf/local_lat.o
CXX perf/remote_lat.o
CXX perf/local_thr.o
CXX perf/inproc_lat.o
CXX perf/remote_thr.o
CXX perf/inproc_thr.o
CXXLD src/libzmq.la
CXXLD tools/curve_keygen
CXXLD perf/local_lat
CXXLD perf/remote_lat
CXXLD perf/local_thr
CXXLD perf/remote_thr
CXXLD perf/inproc_lat
CXXLD perf/inproc_thr
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2'
Making install in doc
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2/doc'
make[2]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2/doc'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2/doc'
make[1]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2'
make[2]: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2'
/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib'
/bin/bash ./libtool --mode=install /usr/bin/install -c src/libzmq.la '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib'
libtool: install: /usr/bin/install -c src/.libs/libzmq.lai /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib/libzmq.la
libtool: install: /usr/bin/install -c src/.libs/libzmq.a /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib/libzmq.a
libtool: install: chmod 644 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib/libzmq.a
libtool: install: ranlib /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib/libzmq.a
libtool: finish: PATH="/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/npm/bin/node-gyp-bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/citgm/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/citgm/lib/package-manager/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/.bin:/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/bin:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/sbin" ldconfig -n /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib
----------------------------------------------------------------------
Libraries have been installed in:
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib
If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
- add LIBDIR to the `LD_LIBRARY_PATH' environment variable
during execution
- add LIBDIR to the `LD_RUN_PATH' environment variable
during linking
- use the `-Wl,-rpath -Wl,LIBDIR' linker flag
- have your system administrator add LIBDIR to `/etc/ld.so.conf'
See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/bin'
/bin/bash ./libtool --mode=install /usr/bin/install -c tools/curve_keygen '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/bin'
libtool: install: /usr/bin/install -c tools/curve_keygen /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/bin/curve_keygen
/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/include'
/usr/bin/install -c -m 644 include/zmq.h include/zmq_utils.h '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/include'
/bin/mkdir -p '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib/pkgconfig'
/usr/bin/install -c -m 644 src/libzmq.pc '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/scripts/../zmq/lib/pkgconfig'
make[2]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2'
make[1]: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/zmq/zeromq-4.2.2'
Succesfully build libzmq on Mon Sep 16 2019 07:53:59 GMT+0000 (Coordinated Universal Time)
make: Entering directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/build'
CXX(target) Release/obj.target/zmq/binding.o
zmq.target.mk:109: recipe for target 'Release/obj.target/zmq/binding.o' failed
make: Leaving directory '/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq/build'
configure: WARNING: Cannot find libunwind
../binding.cc: In member function void zmq::Socket::NotifyReadReady():
../binding.cc:399:75: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated (declared at ../node_modules/nan/nan.h:1024) [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 0, NULL);
^
../binding.cc: In member function void zmq::Socket::NotifySendReady():
../binding.cc:407:75: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated (declared at ../node_modules/nan/nan.h:1024) [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 0, NULL);
^
../binding.cc: In member function void zmq::Socket::MonitorEvent(uint16_t, int32_t, char*):
../binding.cc:458:73: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated (declared at ../node_modules/nan/nan.h:1024) [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 4, argv);
^
../binding.cc: In member function void zmq::Socket::MonitorError(const char*):
../binding.cc:473:73: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated (declared at ../node_modules/nan/nan.h:1024) [-Wdeprecated-declarations]
Nan::MakeCallback(this->handle(), callback_v.As<Function>(), 1, argv);
^
../binding.cc: In static member function static void zmq::Socket::UV_BindAsyncAfter(uv_work_t*):
../binding.cc:814:70: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated (declared at ../node_modules/nan/nan.h:1024) [-Wdeprecated-declarations]
Nan::MakeCallback(Nan::GetCurrentContext()->Global(), cb, 1, argv);
^
../binding.cc: In static member function static void zmq::Socket::UV_UnbindAsyncAfter(uv_work_t*):
../binding.cc:893:70: warning: v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*) is deprecated (declared at ../node_modules/nan/nan.h:1024) [-Wdeprecated-declarations]
Nan::MakeCallback(Nan::GetCurrentContext()->Global(), cb, 1, argv);
^
../binding.cc: In static member function static Nan::NAN_METHOD_RETURN_TYPE zmq::Socket::Sendv(Nan::NAN_METHOD_ARGS_TYPE):
../binding.cc:1300:39: error: no matching function for call to v8::Array::Get(uint32_t&)
Local<Object> buf = batch->Get(i).As<Object>();
^
../binding.cc:1300:39: note: candidates are:
In file included from ../binding.cc:24:0:
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3374:57: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3374:57: note: candidate expects 2 arguments, 1 provided
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3377:57: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3377:57: note: candidate expects 2 arguments, 1 provided
../binding.cc:1300:50: error: expected primary-expression before > token
Local<Object> buf = batch->Get(i).As<Object>();
^
../binding.cc:1300:52: error: expected primary-expression before ) token
Local<Object> buf = batch->Get(i).As<Object>();
^
../binding.cc:1301:48: error: no matching function for call to v8::Array::Get(uint32_t)
Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
^
../binding.cc:1301:48: note: candidates are:
In file included from ../binding.cc:24:0:
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3374:57: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, v8::Local<v8::Value>)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3374:57: note: candidate expects 2 arguments, 1 provided
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3377:57: note: v8::MaybeLocal<v8::Value> v8::Object::Get(v8::Local<v8::Context>, uint32_t)
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
^
/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/node/deps/v8/include/v8.h:3377:57: note: candidate expects 2 arguments, 1 provided
../binding.cc:1301:59: error: expected primary-expression before > token
Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
^
../binding.cc:1301:61: error: expected primary-expression before ) token
Local<Number> flagsObj = batch->Get(i + 1).As<Number>();
^
make: *** [Release/obj.target/zmq/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:196:23)
gyp ERR! stack at ChildProcess.emit (events.js:209:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 3.16.0-6-amd64
gyp ERR! command "/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/bin/node" "/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/smoker/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/403e9ecf-0f0e-41ce-9705-195a738b4013/zeromq
gyp ERR! node -v v13.0.0
gyp ERR! node-gyp -v v5.0.3
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! zeromq@5.1.0 install: `node scripts/prebuild-install.js || (node scripts/preinstall.js && node-gyp rebuild)`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the zeromq@5.1.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/npm_cache/_logs/2019-09-16T07_54_02_069Z-debug.log |
Just pushed another beta of serialport@8.0.1 and I'm soliciting user feedback. |
For the |
Notable changes: * TBD PR-URL: #29504
a9fded7
to
c768a3b
Compare
c768a3b
to
5839935
Compare
Notable changes: * TBD PR-URL: #29504
5839935
to
b6d6761
Compare
For the torrent-stream failures in CITGM: It's a flaky test in torrent-stream but the bug might be in Node.js of course. It seems to be a race condition between servers that ends up keeping the event loop open so the test never completes. It's this test. I'm able to reproduce locally by running /ping @mafintosh @ralphtheninja @nodejs/citgm |
This should probably be pretty easy to bisect given a bit of time for compiling a bunch of times. I can replicate the problem in Node.js 12.5.0 but not in Node.js 12.4.0. |
I did the bisect and will open a separate issue. |
This was the comment for zeromq @rolftimmermans has a next generation version here that is on the roadmap to be merged back to master! @rolftimmermans is the N-API version ready and will it help resolve the failures here? |
The issue with
|
@BethGriggs: 461bf36 was reverted in 0796f0e and should probably not be included in the list. |
Notable changes: * TBD PR-URL: #29504
b6d6761
to
a1890c1
Compare
Notable changes: - **assert**: - do not repeat .throws() code (Ruben Bridgewater) [#28263](#28263) - wrap validation function errors (Ruben Bridgewater) [#28263](#28263) - fix generatedMessage property (Ruben Bridgewater) [#28263](#28263) - improve class instance errors (Ruben Bridgewater) [#28263](#28263) - **benchmark**: - use test/common/tmpdir consistently (João Reis) [#28858](#28858) - **build**: - make full-icu the default for releases (Richard Lau) [#29887](#29887) - update minimum Xcode version for macOS (Michael Dawson) [#29622](#29622) - **child_process**: - runtime deprecate \_channel (cjihrig) [#27949](#27949) - simplify spawn argument parsing (cjihrig) [#27854](#27854) - **console**: - display timeEnd with suitable time unit (Xavier Stouder) [#29251](#29251) - **deps**: - patch V8 to 7.8.279.14 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.12 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.10 (Myles Borins) [#29694](#29694) - update V8's postmortem script (cjihrig) [#29694](#29694) - V8: cherry-pick 716875d (Myles Borins) [#29694](#29694) - update V8 to 7.8.279.9 (Myles Borins) [#29694](#29694) - V8: cherry-pick b33af60 (Michaël Zasso) [#28016](#28016) - update V8 to 7.6.303.28 (Michaël Zasso) [#28016](#28016) - **domain**: - error handler runs outside of its domain (Julien Gilli) [#26211](#26211) - **fs**: - make FSWatcher.start private (Lucas Holmquist) [#29905](#29905) - add runtime deprecate for file stream open() (Robert Nagy) [#29061](#29061) - allow int64 offset in fs.write/writeSync/fd.write (Zach Bjornson) [#26572](#26572) - use IsSafeJsInt instead of IsNumber for ftruncate (Zach Bjornson) [#26572](#26572) - allow int64 offset in fs.read/readSync/fd.read (Zach Bjornson) [#26572](#26572) - close file descriptor of promisified truncate (João Reis) [#28858](#28858) - **http**: - do not emit end after aborted (Robert Nagy) [#27984](#27984) - don't emit 'data' after 'error' (Robert Nagy) [#28711](#28711) - remove legacy parser (Anna Henningsen) [#29589](#29589) - throw if 'host' agent header is not a string value (Giorgos Ntemiris) [#29568](#29568) - replace superfluous connection property with getter/setter (Robert Nagy) [#29015](#29015) - fix test where aborted should not be emitted (Robert Nagy) [#20077](#20077) - remove default 'timeout' listener on upgrade (Luigi Pinca) [#26030](#26030) - **http, http2**: - remove default server timeout (Ali Ijaz Sheikh) [#27558](#27558) - **http2**: - remove security revert flags (Anna Henningsen) [#29141](#29141) - remove callback-based padding (Anna Henningsen) [#29144](#29144) - **lib**: - rename validateInteger to validateSafeInteger (Zach Bjornson) [#26572](#26572) - correct error.errno to always be numeric (Joyee Cheung) [#28140](#28140) - no need to strip BOM or shebang for scripts (Refael Ackermann) [#27375](#27375) - rework logic of stripping BOM+Shebang from commonjs (Gus Caplan) [#27768](#27768) - **module**: - runtime deprecate createRequireFromPath() (cjihrig) [#27951](#27951) - **readline**: - error on falsy values for callback (Sam Roberts) [#28109](#28109) - **repl**: - close file descriptor of history file (João Reis) [#28858](#28858) - **src**: - bring 425 status code name into accordance with RFC 8470 (Sergei Osipov) [#29880](#29880) - update NODE\_MODULE\_VERSION to 79 (Myles Borins) [#29694](#29694) - update NODE\_MODULE\_VERSION to 78 (Michaël Zasso) [#28918](#28918) - add error codes to errors thrown in C++ (Yaniv Friedensohn) [#27700](#27700) - use non-deprecated overload of V8::SetFlagsFromString (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 77 (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 74 (Refael Ackermann) [#27375](#27375) - make process.env.TZ setter clear tz cache (Ben Noordhuis) [#20026](#20026) - enable V8's WASM trap handlers (Gus Caplan) [#27246](#27246) - **stream**: - throw unhandled error for readable with autoDestroy (Robert Nagy) [#29806](#29806) - always invoke callback before emitting error (Robert Nagy) [#29293](#29293) - invoke callback before emitting error always (Robert Nagy) [#29293](#29293) - do not flush destroyed writable (Robert Nagy) [#29028](#29028) - don't emit finish on error (Robert Nagy) [#28979](#28979) - disallow stream methods on finished stream (Robert Nagy) [#28687](#28687) - do not emit after 'error' (Robert Nagy) [#28708](#28708) - fix destroy() behavior (Robert Nagy) [#29058](#29058) - simplify `.pipe()` and `.unpipe()` in Readable (Weijia Wang) [#28583](#28583) - **tools**: - patch V8 to run on older XCode versions (Ujjwal Sharma) [#29694](#29694) - update V8 gypfiles (Michaël Zasso) [#29694](#29694) - support full-icu by default (Steven R. Loomis) [#29522](#29522) - **util**: validate formatWithOptions inspectOptions (Ruben Bridgewater) [#29824](#29824) PR-URL: #29504
@targos, done - PTAL |
Suggestion for the notable changes: diff --git a/doc/changelogs/CHANGELOG_V13.md b/doc/changelogs/CHANGELOG_V13.md
index b3c1a1450a..5b80e644e0 100644
--- a/doc/changelogs/CHANGELOG_V13.md
+++ b/doc/changelogs/CHANGELOG_V13.md
@@ -35,80 +35,67 @@
### Notable Changes
* **assert**:
- * do not repeat .throws() code (Ruben Bridgewater) [#28263](https://github.com/nodejs/node/pull/28263)
- * wrap validation function errors (Ruben Bridgewater) [#28263](https://github.com/nodejs/node/pull/28263)
- * fix generatedMessage property (Ruben Bridgewater) [#28263](https://github.com/nodejs/node/pull/28263)
- * improve class instance errors (Ruben Bridgewater) [#28263](https://github.com/nodejs/node/pull/28263)
-* **benchmark**: use test/common/tmpdir consistently (João Reis) [#28858](https://github.com/nodejs/node/pull/28858)
+ * If the validation function passed to `assert.throws()` or `assert.rejects()`
+ returns a value other than `true`, an assertion error will be thrown instead
+ of the original error to highlight the progamming mistake (Ruben Bridgewater) [#28263](https://github.com/nodejs/node/pull/28263).
+ * If a constructor function is passed to validate the instance of errors
+ thrown in `assert.throws()` or `assert.reject()`, an assertion error will be
+ thrown instead of the original error (Ruben Bridgewater) [#28263](https://github.com/nodejs/node/pull/28263).
* **build**:
- * make full-icu the default for releases (Richard Lau) [#29887](https://github.com/nodejs/node/pull/29887)
- * update minimum Xcode version for macOS (Michael Dawson) [#29622](https://github.com/nodejs/node/pull/29622)
+ * Node.js releases are now built with default full-icu support. This means
+ that all locales supported by ICU are now included and Intl-related APIs may
+ return different values than before (Richard Lau) [#29887](https://github.com/nodejs/node/pull/29887).
+ * The minimum Xcode version supported for macOS was increased to 10. It is
+ still possible to build Node.js with Xcode 8 but this may no longer be the
+ case in a future v13.x release (Michael Dawson) [#29622](https://github.com/nodejs/node/pull/29622).
* **child_process**:
- * runtime deprecate \_channel (cjihrig) [#27949](https://github.com/nodejs/node/pull/27949)
- * simplify spawn argument parsing (cjihrig) [#27854](https://github.com/nodejs/node/pull/27854)
-* **console**: display timeEnd with suitable time unit (Xavier Stouder) [#29251](https://github.com/nodejs/node/pull/29251)
+ * `ChildProcess._channel` (DEP0129) is now a Runtime deprecation (cjihrig) [#27949](https://github.com/nodejs/node/pull/27949).
+* **console**:
+ * The output `console.timeEnd()` and `console.timeLog()` will now
+ automatically select a suitable time unit instead of always using
+ milliseconds (Xavier Stouder) [#29251](https://github.com/nodejs/node/pull/29251).
* **deps**:
- * patch V8 to 7.8.279.14 (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694)
- * patch V8 to 7.8.279.12 (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694)
- * patch V8 to 7.8.279.10 (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694)
- * update V8's postmortem script (cjihrig) [#29694](https://github.com/nodejs/node/pull/29694)
- * V8: cherry-pick 716875d (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694)
- * update V8 to 7.8.279.9 (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694)
- * V8: cherry-pick b33af60 (Michaël Zasso) [#28016](https://github.com/nodejs/node/pull/28016)
- * update V8 to 7.6.303.28 (Michaël Zasso) [#28016](https://github.com/nodejs/node/pull/28016)
-* **domain**: error handler runs outside of its domain (Julien Gilli) [#26211](https://github.com/nodejs/node/pull/26211)
+ * The V8 engine was updated to version 7.8. This includes performance
+ improvements to object destructuring, memory usage and WebAssembly startup
+ time (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694).
+* **domain**:
+ * The domain's error handler is now executed with the active domain set to the
+ domain's parent to prevent inner recursion (Julien Gilli) [#26211](https://github.com/nodejs/node/pull/26211).
* **fs**:
- * make FSWatcher.start private (Lucas Holmquist) [#29905](https://github.com/nodejs/node/pull/29905)
- * add runtime deprecate for file stream open() (Robert Nagy) [#29061](https://github.com/nodejs/node/pull/29061)
- * allow int64 offset in fs.write/writeSync/fd.write (Zach Bjornson) [#26572](https://github.com/nodejs/node/pull/26572)
- * use IsSafeJsInt instead of IsNumber for ftruncate (Zach Bjornson) [#26572](https://github.com/nodejs/node/pull/26572)
- * allow int64 offset in fs.read/readSync/fd.read (Zach Bjornson) [#26572](https://github.com/nodejs/node/pull/26572)
- * close file descriptor of promisified truncate (João Reis) [#28858](https://github.com/nodejs/node/pull/28858)
+ * The undocumented method `FSWatcher.prototype.start()` was removed (Lucas Holmquist) [#29905](https://github.com/nodejs/node/pull/29905).
+ * Calling the `open()` method on a `ReadStream` or `WriteStream` now emits a
+ runtime deprecation warning. The methods are supposed to be internal and
+ should not be called by user code (Robert Nagy) [#29061](https://github.com/nodejs/node/pull/29061).
+ * `fs.read/write`, `fs.readSync/writeSync` and `fd.read/write` now accept any
+ safe integer as their `offset` parameter. The value of `offset` is also no
+ longer coerced, so a valid type must be passed to the functions (Zach Bjornson) [#26572](https://github.com/nodejs/node/pull/26572).
* **http**:
- * do not emit end after aborted (Robert Nagy) [#27984](https://github.com/nodejs/node/pull/27984)
- * don't emit 'data' after 'error' (Robert Nagy) [#28711](https://github.com/nodejs/node/pull/28711)
- * remove legacy parser (Anna Henningsen) [#29589](https://github.com/nodejs/node/pull/29589)
- * throw if 'host' agent header is not a string value (Giorgos Ntemiris) [#29568](https://github.com/nodejs/node/pull/29568)
- * replace superfluous connection property with getter/setter (Robert Nagy) [#29015](https://github.com/nodejs/node/pull/29015)
- * fix test where aborted should not be emitted (Robert Nagy) [#20077](https://github.com/nodejs/node/pull/20077)
- * remove default 'timeout' listener on upgrade (Luigi Pinca) [#26030](https://github.com/nodejs/node/pull/26030)
-* **http, http2**: remove default server timeout (Ali Ijaz Sheikh) [#27558](https://github.com/nodejs/node/pull/27558)
-* **http2**:
- * remove security revert flags (Anna Henningsen) [#29141](https://github.com/nodejs/node/pull/29141)
- * remove callback-based padding (Anna Henningsen) [#29144](https://github.com/nodejs/node/pull/29144)
+ * Aborted requests no longer emit the `end` or `error` events after `aborted`
+ (Robert Nagy) [#27984](https://github.com/nodejs/node/pull/27984), [#20077](https://github.com/nodejs/node/pull/20077).
+ * Data will no longer be emitted after a socket error (Robert Nagy) [#28711](https://github.com/nodejs/node/pull/28711).
+ * The legacy HTTP parser (previously available under the
+ `--http-parser=legacy` flag) was removed (Anna Henningsen) [#29589](https://github.com/nodejs/node/pull/29589).
+ * The `host` option for HTTP requests is now validated to be a string value (Giorgos Ntemiris) [#29568](https://github.com/nodejs/node/pull/29568).
+ * The `request.connection` and `response.connection` properties are now
+ runtime deprecated. The equivalent `request.socket` and `response.socket`
+ should be used instead (Robert Nagy) [#29015](https://github.com/nodejs/node/pull/29015).
+* **http, http2**:
+ * The default server timeout was removed (Ali Ijaz Sheikh) [#27558](https://github.com/nodejs/node/pull/27558).
+ * Brought 425 status code name into accordance with RFC 8470. The name changed
+ from "Unordered Collection" to "Too Early" (Sergei Osipov) [#29880](https://github.com/nodejs/node/pull/29880).
* **lib**:
- * rename validateInteger to validateSafeInteger (Zach Bjornson) [#26572](https://github.com/nodejs/node/pull/26572)
- * correct error.errno to always be numeric (Joyee Cheung) [#28140](https://github.com/nodejs/node/pull/28140)
- * no need to strip BOM or shebang for scripts (Refael Ackermann) [#27375](https://github.com/nodejs/node/pull/27375)
- * rework logic of stripping BOM+Shebang from commonjs (Gus Caplan) [#27768](https://github.com/nodejs/node/pull/27768)
-* **module**: runtime deprecate createRequireFromPath() (cjihrig) [#27951](https://github.com/nodejs/node/pull/27951)
-* **readline**: error on falsy values for callback (Sam Roberts) [#28109](https://github.com/nodejs/node/pull/28109)
-* **repl**: close file descriptor of history file (João Reis) [#28858](https://github.com/nodejs/node/pull/28858)
+ * The `error.errno` property will now always be a number. To get the string
+ value, use `error.code` instead (Joyee Cheung) [#28140](https://github.com/nodejs/node/pull/28140).
+* **module**:
+ * `module.createRequireFromPath()` is deprecated. Use `module.createRequire()`
+ instead (cjihrig) [#27951](https://github.com/nodejs/node/pull/27951).
* **src**:
- * bring 425 status code name into accordance with RFC 8470 (Sergei Osipov) [#29880](https://github.com/nodejs/node/pull/29880)
- * update NODE\_MODULE\_VERSION to 79 (Myles Borins) [#29694](https://github.com/nodejs/node/pull/29694)
- * update NODE\_MODULE\_VERSION to 78 (Michaël Zasso) [#28918](https://github.com/nodejs/node/pull/28918)
- * add error codes to errors thrown in C++ (Yaniv Friedensohn) [#27700](https://github.com/nodejs/node/pull/27700)
- * use non-deprecated overload of V8::SetFlagsFromString (Michaël Zasso) [#28016](https://github.com/nodejs/node/pull/28016)
- * update NODE\_MODULE\_VERSION to 77 (Michaël Zasso) [#28016](https://github.com/nodejs/node/pull/28016)
- * update NODE\_MODULE\_VERSION to 74 (Refael Ackermann) [#27375](https://github.com/nodejs/node/pull/27375)
- * make process.env.TZ setter clear tz cache (Ben Noordhuis) [#20026](https://github.com/nodejs/node/pull/20026)
- * enable V8's WASM trap handlers (Gus Caplan) [#27246](https://github.com/nodejs/node/pull/27246)
+ * Changing the value of `process.env.TZ` will now clear the tz cache. This
+ affects the default time zone used by methods such as
+ `Date.prototype.toString` (Ben Noordhuis) [#20026](https://github.com/nodejs/node/pull/20026).
* **stream**:
- * throw unhandled error for readable with autoDestroy (Robert Nagy) [#29806](https://github.com/nodejs/node/pull/29806)
- * always invoke callback before emitting error (Robert Nagy) [#29293](https://github.com/nodejs/node/pull/29293)
- * invoke callback before emitting error always (Robert Nagy) [#29293](https://github.com/nodejs/node/pull/29293)
- * do not flush destroyed writable (Robert Nagy) [#29028](https://github.com/nodejs/node/pull/29028)
- * don't emit finish on error (Robert Nagy) [#28979](https://github.com/nodejs/node/pull/28979)
- * disallow stream methods on finished stream (Robert Nagy) [#28687](https://github.com/nodejs/node/pull/28687)
- * do not emit after 'error' (Robert Nagy) [#28708](https://github.com/nodejs/node/pull/28708)
- * fix destroy() behavior (Robert Nagy) [#29058](https://github.com/nodejs/node/pull/29058)
- * simplify `.pipe()` and `.unpipe()` in Readable (Weijia Wang) [#28583](https://github.com/nodejs/node/pull/28583)
-* **tools**:
- * patch V8 to run on older XCode versions (Ujjwal Sharma) [#29694](https://github.com/nodejs/node/pull/29694)
- * update V8 gypfiles (Michaël Zasso) [#29694](https://github.com/nodejs/node/pull/29694)
- * support full-icu by default (Steven R. Loomis) [#29522](https://github.com/nodejs/node/pull/29522)
-* **util**: validate formatWithOptions inspectOptions (Ruben Bridgewater) [#29824](https://github.com/nodejs/node/pull/29824)
+ * The timing and behavior of streams was consolidated for a number of edge
+ cases. Please look at the individual commits below for more information.
### Semver-Major Commits
|
87f07ca
to
a6920a8
Compare
@targos, pulled the notable changes in - thank you for putting those together! |
a6920a8
to
d72e3d2
Compare
The deprecation for |
Notable changes: * assert: * If the validation function passed to `assert.throws()` or `assert.rejects()` returns a value other than `true`, an assertion error will be thrown instead of the original error to highlight the programming mistake (Ruben Bridgewater). #28263 * If a constructor function is passed to validate the instance of errors thrown in `assert.throws()` or `assert.reject()`, an assertion error will be thrown instead of the original error (Ruben Bridgewater). #28263 * build: * Node.js releases are now built with default full-icu support. This means that all locales supported by ICU are now included and Intl-related APIs may return different values than before (Richard Lau). #29887 * The minimum Xcode version supported for macOS was increased to 10. It is still possible to build Node.js with Xcode 8 but this may no longer be the case in a future v13.x release (Michael Dawson). #29622 * child_process: * `ChildProcess._channel` (DEP0129) is now a Runtime deprecation (cjihrig). #27949 * console: * The output `console.timeEnd()` and `console.timeLog()` will now automatically select a suitable time unit instead of always using milliseconds (Xavier Stouder). #29251 * deps: * The V8 engine was updated to version 7.8. This includes performance improvements to object destructuring, memory usage and WebAssembly startup time (Myles Borins). #29694) * domain: * The domain's error handler is now executed with the active domain set to the domain's parent to prevent inner recursion (Julien Gilli). #26211 * fs: * The undocumented method `FSWatcher.prototype.start()` was removed (Lucas Holmquist). #29905 * Calling the `open()` method on a `ReadStream` or `WriteStream` now emits a runtime deprecation warning. The methods are supposed to be internal and should not be called by user code (Robert Nagy). #29061 * `fs.read/write`, `fs.readSync/writeSync` and `fd.read/write` now accept any safe integer as their `offset` parameter. The value of `offset` is also no longer coerced, so a valid type must be passed to the functions (Zach Bjornson). #26572 * http: * Aborted requests no longer emit the `end` or `error` events after `aborted` (Robert Nagy). #27984 #20077 * Data will no longer be emitted after a socket error (Robert Nagy). #28711 * The legacy HTTP parser (previously available under the `--http-parser=legacy` flag) was removed (Anna Henningsen). #29589 * The `host` option for HTTP requests is now validated to be a string value (Giorgos Ntemiris). #29568 * The `request.connection` and `response.connection` properties are now runtime deprecated. The equivalent `request.socket` and `response.socket` should be used instead (Robert Nagy). #29015 * http, http2: * The default server timeout was removed (Ali Ijaz Sheikh). #27558 * Brought 425 status code name into accordance with RFC 8470. The name changed from "Unordered Collection" to "Too Early" (Sergei Osipov). #29880 * lib: * The `error.errno` property will now always be a number. To get the string value, use `error.code` instead (Joyee Cheung). #28140 * module: * `module.createRequireFromPath()` is deprecated. Use `module.createRequire()` instead (cjihrig). #27951 * src: * Changing the value of `process.env.TZ` will now clear the tz cache. This affects the default time zone used by methods such as `Date.prototype.toString` (Ben Noordhuis). #20026 * stream: * The timing and behavior of streams was consolidated for a number of edge cases. Please look at the individual commits below for more information. PR-URL: #29504
d72e3d2
to
111e59b
Compare
Notable changes: * assert: * If the validation function passed to `assert.throws()` or `assert.rejects()` returns a value other than `true`, an assertion error will be thrown instead of the original error to highlight the programming mistake (Ruben Bridgewater). #28263 * If a constructor function is passed to validate the instance of errors thrown in `assert.throws()` or `assert.reject()`, an assertion error will be thrown instead of the original error (Ruben Bridgewater). #28263 * build: * Node.js releases are now built with default full-icu support. This means that all locales supported by ICU are now included and Intl-related APIs may return different values than before (Richard Lau). #29887 * The minimum Xcode version supported for macOS was increased to 10. It is still possible to build Node.js with Xcode 8 but this may no longer be the case in a future v13.x release (Michael Dawson). #29622 * child_process: * `ChildProcess._channel` (DEP0129) is now a Runtime deprecation (cjihrig). #27949 * console: * The output `console.timeEnd()` and `console.timeLog()` will now automatically select a suitable time unit instead of always using milliseconds (Xavier Stouder). #29251 * deps: * The V8 engine was updated to version 7.8. This includes performance improvements to object destructuring, memory usage and WebAssembly startup time (Myles Borins). #29694) * domain: * The domain's error handler is now executed with the active domain set to the domain's parent to prevent inner recursion (Julien Gilli). #26211 * fs: * The undocumented method `FSWatcher.prototype.start()` was removed (Lucas Holmquist). #29905 * Calling the `open()` method on a `ReadStream` or `WriteStream` now emits a runtime deprecation warning. The methods are supposed to be internal and should not be called by user code (Robert Nagy). #29061 * `fs.read/write`, `fs.readSync/writeSync` and `fd.read/write` now accept any safe integer as their `offset` parameter. The value of `offset` is also no longer coerced, so a valid type must be passed to the functions (Zach Bjornson). #26572 * http: * Aborted requests no longer emit the `end` or `error` events after `aborted` (Robert Nagy). #27984 #20077 * Data will no longer be emitted after a socket error (Robert Nagy). #28711 * The legacy HTTP parser (previously available under the `--http-parser=legacy` flag) was removed (Anna Henningsen). #29589 * The `host` option for HTTP requests is now validated to be a string value (Giorgos Ntemiris). #29568 * The `request.connection` and `response.connection` properties are now runtime deprecated. The equivalent `request.socket` and `response.socket` should be used instead (Robert Nagy). #29015 * http, http2: * The default server timeout was removed (Ali Ijaz Sheikh). #27558 * Brought 425 status code name into accordance with RFC 8470. The name changed from "Unordered Collection" to "Too Early" (Sergei Osipov). #29880 * lib: * The `error.errno` property will now always be a number. To get the string value, use `error.code` instead (Joyee Cheung). #28140 * module: * `module.createRequireFromPath()` is deprecated. Use `module.createRequire()` instead (cjihrig). #27951 * src: * Changing the value of `process.env.TZ` will now clear the tz cache. This affects the default time zone used by methods such as `Date.prototype.toString` (Ben Noordhuis). #20026 * stream: * The timing and behavior of streams was consolidated for a number of edge cases. Please look at the individual commits below for more information. PR-URL: #29504
I realize now that we forgot to coordinate with npm :(
|
@targos, what needs to happen for that to be resolved? |
npm/cli#269 and then @ljharb said he would update npm in node. |
2019-10-22, Version 13.0.0 (Current), @BethGriggs
Notable Changes
assert.throws()
orassert.rejects()
returns a value other than
true
, an assertion error will be thrown insteadof the original error to highlight the programming mistake (Ruben Bridgewater) #28263.
thrown in
assert.throws()
orassert.reject()
, an assertion error will bethrown instead of the original error (Ruben Bridgewater) #28263.
that all locales supported by ICU are now included and Intl-related APIs may
return different values than before (Richard Lau) #29887.
still possible to build Node.js with Xcode 8 but this may no longer be the
case in a future v13.x release (Michael Dawson) #29622.
ChildProcess._channel
(DEP0129) is now a Runtime deprecation (cjihrig) #27949.console.timeEnd()
andconsole.timeLog()
will nowautomatically select a suitable time unit instead of always using
milliseconds (Xavier Stouder) #29251.
improvements to object destructuring, memory usage and WebAssembly startup
time (Myles Borins) #29694.
domain's parent to prevent inner recursion (Julien Gilli) #26211.
FSWatcher.prototype.start()
was removed (Lucas Holmquist) #29905.open()
method on aReadStream
orWriteStream
now emits aruntime deprecation warning. The methods are supposed to be internal and
should not be called by user code (Robert Nagy) #29061.
fs.read/write
,fs.readSync/writeSync
andfd.read/write
now accept anysafe integer as their
offset
parameter. The value ofoffset
is also nolonger coerced, so a valid type must be passed to the functions (Zach Bjornson) #26572.
end
orerror
events afteraborted
(Robert Nagy) #27984, #20077.
--http-parser=legacy
flag) was removed (Anna Henningsen) #29589.host
option for HTTP requests is now validated to be a string value (Giorgos Ntemiris) #29568.request.connection
andresponse.connection
properties are nowruntime deprecated. The equivalent
request.socket
andresponse.socket
should be used instead (Robert Nagy) #29015.
from "Unordered Collection" to "Too Early" (Sergei Osipov) #29880.
error.errno
property will now always be a number. To get the stringvalue, use
error.code
instead (Joyee Cheung) #28140.module.createRequireFromPath()
is deprecated. Usemodule.createRequire()
instead (cjihrig) #27951.
process.env.TZ
will now clear the tz cache. Thisaffects the default time zone used by methods such as
Date.prototype.toString
(Ben Noordhuis) #20026.cases. Please look at the individual commits below for more information.
Semver-Major Commits
5981fb7faa
] - (SEMVER-MAJOR) assert: fix line number calculation after V8 upgrade (Michaël Zasso) #2969448d1ea5e7f
] - (SEMVER-MAJOR) assert: special handle identical error names in instance checks (Ruben Bridgewater) #2826397c52ca5dc
] - (SEMVER-MAJOR) assert: add more information to AssertionErrors (Ruben Bridgewater) #282635700cd17dd
] - (SEMVER-MAJOR) assert: do not repeat .throws() code (Ruben Bridgewater) #28263d47b6786c9
] - (SEMVER-MAJOR) assert: wrap validation function errors (Ruben Bridgewater) #282630b3242c3ce
] - (SEMVER-MAJOR) assert: fix generatedMessage property (Ruben Bridgewater) #28263ace3f16917
] - (SEMVER-MAJOR) assert: improve class instance errors (Ruben Bridgewater) #282630376b5b7ba
] - (SEMVER-MAJOR) benchmark: use test/common/tmpdir consistently (João Reis) #288584885e50f7e
] - (SEMVER-MAJOR) build: make full-icu the default for releases (Richard Lau) #2988760a3bd93ce
] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Myles Borins) #296949f830f37da
] - (SEMVER-MAJOR) build: update minimum Xcode version for macOS (Michael Dawson) #2962266eaeac1df
] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #28016d05668d688
] - (SEMVER-MAJOR) child_process: runtime deprecate _channel (cjihrig) #279494f9cd2770a
] - (SEMVER-MAJOR) child_process: simplify spawn argument parsing (cjihrig) #2785466043e1812
] - (SEMVER-MAJOR) console: display timeEnd with suitable time unit (Xavier Stouder) #2925180f2b67367
] - (SEMVER-MAJOR) deps: patch V8 to 7.8.279.14 (Myles Borins) #29694eeafb263f4
] - (SEMVER-MAJOR) deps: patch V8 to 7.8.279.12 (Myles Borins) #29694ddfc3b0a76
] - (SEMVER-MAJOR) deps: patch V8 to 7.8.279.10 (Myles Borins) #296948d05991d10
] - (SEMVER-MAJOR) deps: update V8's postmortem script (cjihrig) #29694858602445b
] - (SEMVER-MAJOR) deps: V8: cherry-pick 716875d (Myles Borins) #29694f7f6c928c1
] - (SEMVER-MAJOR) deps: update V8 to 7.8.279.9 (Myles Borins) #2969484d3243ce9
] - (SEMVER-MAJOR) deps: V8: cherry-pick b33af60 (Michaël Zasso) #280162dcc3665ab
] - (SEMVER-MAJOR) deps: update V8 to 7.6.303.28 (Michaël Zasso) #28016eef1b5aa0f
] - (SEMVER-MAJOR) doc: makeAssertionError
a link (Ruben Bridgewater) #282638fd7184959
] - (SEMVER-MAJOR) doc: update assert.throws() examples (Ruben Bridgewater) #2826380d9b1c712
] - (SEMVER-MAJOR) doc: wrap long line (cjihrig) #2795143a5170858
] - (SEMVER-MAJOR) domain: error handler runs outside of its domain (Julien Gilli) #262117eacb74389
] - (SEMVER-MAJOR) fs: make FSWatcher.start private (Lucas Holmquist) #29905773769df60
] - (SEMVER-MAJOR) fs: add runtime deprecate for file stream open() (Robert Nagy) #290615e3b4d6ed9
] - (SEMVER-MAJOR) fs: allow int64 offset in fs.write/writeSync/fd.write (Zach Bjornson) #26572a3c0014e73
] - (SEMVER-MAJOR) fs: use IsSafeJsInt instead of IsNumber for ftruncate (Zach Bjornson) #265720bbda5e5ae
] - (SEMVER-MAJOR) fs: allow int64 offset in fs.read/readSync/fd.read (Zach Bjornson) #26572eadc3850fe
] - (SEMVER-MAJOR) fs: close file descriptor of promisified truncate (João Reis) #288585f80df8820
] - (SEMVER-MAJOR) http: do not emit end after aborted (Robert Nagy) #27984e573c39b88
] - (SEMVER-MAJOR) http: don't emit 'data' after 'error' (Robert Nagy) #28711ac59dc42ed
] - (SEMVER-MAJOR) http: remove legacy parser (Anna Henningsen) #295892daf883a18
] - (SEMVER-MAJOR) http: throw if 'host' agent header is not a string value (Giorgos Ntemiris) #295680daec61b9b
] - (SEMVER-MAJOR) http: replace superfluous connection property with getter/setter (Robert Nagy) #29015461bf36d70
] - (SEMVER-MAJOR) http: fix test where aborted should not be emitted (Robert Nagy) #20077d5577f0395
] - (SEMVER-MAJOR) http: remove default 'timeout' listener on upgrade (Luigi Pinca) #26030c30ef3cbd2
] - (SEMVER-MAJOR) http, http2: remove default server timeout (Ali Ijaz Sheikh) #275584e782c9deb
] - (SEMVER-MAJOR) http2: remove security revert flags (Anna Henningsen) #2914141637a530e
] - (SEMVER-MAJOR) http2: remove callback-based padding (Anna Henningsen) #2914491a4cb7175
] - (SEMVER-MAJOR) lib: rename validateInteger to validateSafeInteger (Zach Bjornson) #265721432065e9d
] - (SEMVER-MAJOR) lib: correct error.errno to always be numeric (Joyee Cheung) #28140702331be90
] - (SEMVER-MAJOR) lib: no need to strip BOM or shebang for scripts (Refael Ackermann) #27375e2c0c0c680
] - (SEMVER-MAJOR) lib: rework logic of stripping BOM+Shebang from commonjs (Gus Caplan) #2776814701e539c
] - (SEMVER-MAJOR) module: runtime deprecate createRequireFromPath() (cjihrig) #2795104633eeeb9
] - (SEMVER-MAJOR) readline: error on falsy values for callback (Sam Roberts) #281093eea43af07
] - (SEMVER-MAJOR) repl: close file descriptor of history file (João Reis) #28858458a38c904
] - (SEMVER-MAJOR) src: bring 425 status code name into accordance with RFC 8470 (Sergei Osipov) #298807fcc1f7047
] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 79 (Myles Borins) #296944b7be335b9
] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 78 (Michaël Zasso) #28918a0e2c6d284
] - (SEMVER-MAJOR) src: add error codes to errors thrown in C++ (Yaniv Friedensohn) #2770094e980c9d3
] - (SEMVER-MAJOR) src: use non-deprecated overload of V8::SetFlagsFromString (Michaël Zasso) #28016655e0dc01a
] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 77 (Michaël Zasso) #28016e3cd79ef8e
] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 74 (Refael Ackermann) #27375eba348b6ae
] - (SEMVER-MAJOR) src: make process.env.TZ setter clear tz cache (Ben Noordhuis) #20026f2061930c8
] - (SEMVER-MAJOR) src: enable V8's WASM trap handlers (Gus Caplan) #27246f8f6a21580
] - (SEMVER-MAJOR) stream: throw unhandled error for readable with autoDestroy (Robert Nagy) #29806f663b31cc2
] - (SEMVER-MAJOR) stream: always invoke callback before emitting error (Robert Nagy) #29293aa32e13968
] - (SEMVER-MAJOR) stream: do not flush destroyed writable (Robert Nagy) #29028ba3be578d8
] - (SEMVER-MAJOR) stream: don't emit finish on error (Robert Nagy) #28979db706da235
] - (SEMVER-MAJOR) stream: disallow stream methods on finished stream (Robert Nagy) #28687188896ea3e
] - (SEMVER-MAJOR) stream: do not emit after 'error' (Robert Nagy) #287084a2bd69db9
] - (SEMVER-MAJOR) stream: fix destroy() behavior (Robert Nagy) #29058824dc576db
] - (SEMVER-MAJOR) stream: simplify.pipe()
and.unpipe()
in Readable (Weijia Wang) #285838ef68e66d0
] - (SEMVER-MAJOR) test: clean tmpdir on process exit (João Reis) #28858d3f20a4725
] - (SEMVER-MAJOR) test: use unique tmpdirs for each test (João Reis) #28858174723354e
] - (SEMVER-MAJOR) tools: patch V8 to run on older XCode versions (Ujjwal Sharma) #296941676502318
] - (SEMVER-MAJOR) tools: update V8 gypfiles (Michaël Zasso) #296941a25e901b7
] - (SEMVER-MAJOR) tools: support full-icu by default (Steven R. Loomis) #295222664dacf7e
] - (SEMVER-MAJOR) util: validate formatWithOptions inspectOptions (Ruben Bridgewater) #29824