http: handle array in host prop #29568

gntem · 2019-09-15T19:42:39Z

submodule: http

handle passing array in host prop of agent headers

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

mscdex

I think we should just throw if typeof hostHeader !== 'string'. The Host header is special and cannot have multiple values (RFC 7230 states such requests should be rejected), so I think it's best to avoid confusion by not allowing anything other than what we expect/can send.

jasnell · 2019-09-16T17:54:37Z

Definitely agree with @mscdex

lib/_http_agent.js

test/parallel/test-http-client-headers-host-array.js

submodule: http handle passing array in host prop of agent headers

gntem · 2019-09-17T06:55:18Z

Definitely agree with @mscdex

Yes, it makes more sense to follow the RFC.

jasnell · 2019-09-17T15:49:54Z

semver major because of the addition of the new throw

lpinca · 2019-09-17T19:14:19Z

test/parallel/test-http-client-headers-host-array.js

+const assert = require('assert');
+const http = require('http');
+
+{


Nit: this block is not needed?

I prefer we keep individual tests in block scopes, even if there's only one test case in the test file. It's not necessary but it keeps everything consistent with test files where they are useful, and it makes the test file more easily-extensible and friendly-for-beginners. Need to add a new test case? Hey, put it in some brackets and look at the brackets elsewhere in the test file.

In my opinion it only hinders readability when there is only one test case. It's one more unneeded level of indentation. Anyway I don't mind, it is a nit.

Trott · 2019-09-17T23:25:34Z

@mscdex It appears that your comment has been addressed. Would you agree?

nodejs-github-bot · 2019-09-17T23:26:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25524/

Trott · 2019-09-18T03:47:49Z

CITGM (queued): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2002/

Trott · 2019-09-18T13:10:24Z

Landed in 2daf883

If the 'host' agent header is an array or other non-string value, throw. PR-URL: nodejs#29568 Fixes: nodejs#29408 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes: - **assert**: - do not repeat .throws() code (Ruben Bridgewater) [#28263](#28263) - wrap validation function errors (Ruben Bridgewater) [#28263](#28263) - fix generatedMessage property (Ruben Bridgewater) [#28263](#28263) - improve class instance errors (Ruben Bridgewater) [#28263](#28263) - **benchmark**: - use test/common/tmpdir consistently (João Reis) [#28858](#28858) - **build**: - make full-icu the default for releases (Richard Lau) [#29887](#29887) - update minimum Xcode version for macOS (Michael Dawson) [#29622](#29622) - **child_process**: - runtime deprecate \_channel (cjihrig) [#27949](#27949) - simplify spawn argument parsing (cjihrig) [#27854](#27854) - **console**: - display timeEnd with suitable time unit (Xavier Stouder) [#29251](#29251) - **deps**: - patch V8 to 7.8.279.14 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.12 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.10 (Myles Borins) [#29694](#29694) - update V8's postmortem script (cjihrig) [#29694](#29694) - V8: cherry-pick 716875d (Myles Borins) [#29694](#29694) - update V8 to 7.8.279.9 (Myles Borins) [#29694](#29694) - V8: cherry-pick b33af60 (Michaël Zasso) [#28016](#28016) - update V8 to 7.6.303.28 (Michaël Zasso) [#28016](#28016) - **domain**: - error handler runs outside of its domain (Julien Gilli) [#26211](#26211) - **fs**: - make FSWatcher.start private (Lucas Holmquist) [#29905](#29905) - add runtime deprecate for file stream open() (Robert Nagy) [#29061](#29061) - allow int64 offset in fs.write/writeSync/fd.write (Zach Bjornson) [#26572](#26572) - use IsSafeJsInt instead of IsNumber for ftruncate (Zach Bjornson) [#26572](#26572) - allow int64 offset in fs.read/readSync/fd.read (Zach Bjornson) [#26572](#26572) - close file descriptor of promisified truncate (João Reis) [#28858](#28858) - **http**: - do not emit end after aborted (Robert Nagy) [#27984](#27984) - don't emit 'data' after 'error' (Robert Nagy) [#28711](#28711) - remove legacy parser (Anna Henningsen) [#29589](#29589) - throw if 'host' agent header is not a string value (Giorgos Ntemiris) [#29568](#29568) - replace superfluous connection property with getter/setter (Robert Nagy) [#29015](#29015) - fix test where aborted should not be emitted (Robert Nagy) [#20077](#20077) - remove default 'timeout' listener on upgrade (Luigi Pinca) [#26030](#26030) - **http, http2**: - remove default server timeout (Ali Ijaz Sheikh) [#27558](#27558) - **http2**: - remove security revert flags (Anna Henningsen) [#29141](#29141) - remove callback-based padding (Anna Henningsen) [#29144](#29144) - **lib**: - rename validateInteger to validateSafeInteger (Zach Bjornson) [#26572](#26572) - correct error.errno to always be numeric (Joyee Cheung) [#28140](#28140) - no need to strip BOM or shebang for scripts (Refael Ackermann) [#27375](#27375) - rework logic of stripping BOM+Shebang from commonjs (Gus Caplan) [#27768](#27768) - **module**: - runtime deprecate createRequireFromPath() (cjihrig) [#27951](#27951) - **readline**: - error on falsy values for callback (Sam Roberts) [#28109](#28109) - **repl**: - close file descriptor of history file (João Reis) [#28858](#28858) - **src**: - bring 425 status code name into accordance with RFC 8470 (Sergei Osipov) [#29880](#29880) - update NODE\_MODULE\_VERSION to 79 (Myles Borins) [#29694](#29694) - update NODE\_MODULE\_VERSION to 78 (Michaël Zasso) [#28918](#28918) - add error codes to errors thrown in C++ (Yaniv Friedensohn) [#27700](#27700) - use non-deprecated overload of V8::SetFlagsFromString (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 77 (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 74 (Refael Ackermann) [#27375](#27375) - make process.env.TZ setter clear tz cache (Ben Noordhuis) [#20026](#20026) - enable V8's WASM trap handlers (Gus Caplan) [#27246](#27246) - **stream**: - throw unhandled error for readable with autoDestroy (Robert Nagy) [#29806](#29806) - always invoke callback before emitting error (Robert Nagy) [#29293](#29293) - invoke callback before emitting error always (Robert Nagy) [#29293](#29293) - do not flush destroyed writable (Robert Nagy) [#29028](#29028) - don't emit finish on error (Robert Nagy) [#28979](#28979) - disallow stream methods on finished stream (Robert Nagy) [#28687](#28687) - do not emit after 'error' (Robert Nagy) [#28708](#28708) - fix destroy() behavior (Robert Nagy) [#29058](#29058) - simplify `.pipe()` and `.unpipe()` in Readable (Weijia Wang) [#28583](#28583) - **tools**: - patch V8 to run on older XCode versions (Ujjwal Sharma) [#29694](#29694) - update V8 gypfiles (Michaël Zasso) [#29694](#29694) - support full-icu by default (Steven R. Loomis) [#29522](#29522) - **util**: validate formatWithOptions inspectOptions (Ruben Bridgewater) [#29824](#29824) PR-URL: #29504

Notable changes: * assert: * If the validation function passed to `assert.throws()` or `assert.rejects()` returns a value other than `true`, an assertion error will be thrown instead of the original error to highlight the programming mistake (Ruben Bridgewater). #28263 * If a constructor function is passed to validate the instance of errors thrown in `assert.throws()` or `assert.reject()`, an assertion error will be thrown instead of the original error (Ruben Bridgewater). #28263 * build: * Node.js releases are now built with default full-icu support. This means that all locales supported by ICU are now included and Intl-related APIs may return different values than before (Richard Lau). #29887 * The minimum Xcode version supported for macOS was increased to 10. It is still possible to build Node.js with Xcode 8 but this may no longer be the case in a future v13.x release (Michael Dawson). #29622 * child_process: * `ChildProcess._channel` (DEP0129) is now a Runtime deprecation (cjihrig). #27949 * console: * The output `console.timeEnd()` and `console.timeLog()` will now automatically select a suitable time unit instead of always using milliseconds (Xavier Stouder). #29251 * deps: * The V8 engine was updated to version 7.8. This includes performance improvements to object destructuring, memory usage and WebAssembly startup time (Myles Borins). #29694) * domain: * The domain's error handler is now executed with the active domain set to the domain's parent to prevent inner recursion (Julien Gilli). #26211 * fs: * The undocumented method `FSWatcher.prototype.start()` was removed (Lucas Holmquist). #29905 * Calling the `open()` method on a `ReadStream` or `WriteStream` now emits a runtime deprecation warning. The methods are supposed to be internal and should not be called by user code (Robert Nagy). #29061 * `fs.read/write`, `fs.readSync/writeSync` and `fd.read/write` now accept any safe integer as their `offset` parameter. The value of `offset` is also no longer coerced, so a valid type must be passed to the functions (Zach Bjornson). #26572 * http: * Aborted requests no longer emit the `end` or `error` events after `aborted` (Robert Nagy). #27984 #20077 * Data will no longer be emitted after a socket error (Robert Nagy). #28711 * The legacy HTTP parser (previously available under the `--http-parser=legacy` flag) was removed (Anna Henningsen). #29589 * The `host` option for HTTP requests is now validated to be a string value (Giorgos Ntemiris). #29568 * The `request.connection` and `response.connection` properties are now runtime deprecated. The equivalent `request.socket` and `response.socket` should be used instead (Robert Nagy). #29015 * http, http2: * The default server timeout was removed (Ali Ijaz Sheikh). #27558 * Brought 425 status code name into accordance with RFC 8470. The name changed from "Unordered Collection" to "Too Early" (Sergei Osipov). #29880 * lib: * The `error.errno` property will now always be a number. To get the string value, use `error.code` instead (Joyee Cheung). #28140 * module: * `module.createRequireFromPath()` is deprecated. Use `module.createRequire()` instead (cjihrig). #27951 * src: * Changing the value of `process.env.TZ` will now clear the tz cache. This affects the default time zone used by methods such as `Date.prototype.toString` (Ben Noordhuis). #20026 * stream: * The timing and behavior of streams was consolidated for a number of edge cases. Please look at the individual commits below for more information. PR-URL: #29504

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Sep 15, 2019

gntem changed the title ~~http: handle arrrays in host prop~~ http: handle array in host prop Sep 15, 2019

mscdex previously requested changes Sep 15, 2019

View reviewed changes

gntem force-pushed the http-agent-accept-first-element-ifarray branch from 49c7472 to e9469c9 Compare September 16, 2019 18:53

jasnell reviewed Sep 16, 2019

View reviewed changes

lib/_http_agent.js Outdated Show resolved Hide resolved

jasnell reviewed Sep 16, 2019

View reviewed changes

lib/_http_agent.js Outdated Show resolved Hide resolved

jasnell reviewed Sep 16, 2019

View reviewed changes

test/parallel/test-http-client-headers-host-array.js Outdated Show resolved Hide resolved

jasnell reviewed Sep 16, 2019

View reviewed changes

test/parallel/test-http-client-headers-host-array.js Outdated Show resolved Hide resolved

http: handle arrrays in host prop

474a66a

submodule: http handle passing array in host prop of agent headers

gntem force-pushed the http-agent-accept-first-element-ifarray branch from e9469c9 to 474a66a Compare September 17, 2019 06:53

jasnell approved these changes Sep 17, 2019

View reviewed changes

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 17, 2019

Trott force-pushed the master branch from 1ecc406 to 49cf67e Compare September 17, 2019 16:50

lpinca approved these changes Sep 17, 2019

View reviewed changes

Trott approved these changes Sep 18, 2019

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2019

Trott closed this Sep 18, 2019

BethGriggs mentioned this pull request Sep 25, 2019

2019-10-22, Version 13.0.0 (Current) #29504

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: handle array in host prop #29568

http: handle array in host prop #29568

gntem commented Sep 15, 2019 •

edited

Loading

mscdex left a comment •

edited

Loading

jasnell commented Sep 16, 2019

gntem commented Sep 17, 2019

jasnell commented Sep 17, 2019

lpinca Sep 17, 2019

Trott Sep 17, 2019

lpinca Sep 18, 2019

Trott commented Sep 17, 2019

nodejs-github-bot commented Sep 17, 2019

Trott commented Sep 18, 2019

Trott commented Sep 18, 2019

http: handle array in host prop #29568

http: handle array in host prop #29568

Conversation

gntem commented Sep 15, 2019 • edited Loading

Checklist

mscdex left a comment • edited Loading

Choose a reason for hiding this comment

jasnell commented Sep 16, 2019

gntem commented Sep 17, 2019

jasnell commented Sep 17, 2019

lpinca Sep 17, 2019

Choose a reason for hiding this comment

Trott Sep 17, 2019

Choose a reason for hiding this comment

lpinca Sep 18, 2019

Choose a reason for hiding this comment

Trott commented Sep 17, 2019

nodejs-github-bot commented Sep 17, 2019

Trott commented Sep 18, 2019

Trott commented Sep 18, 2019

gntem commented Sep 15, 2019 •

edited

Loading

mscdex left a comment •

edited

Loading