-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix URLs to CPU/Heap profilers in inspector #29710
Conversation
[Chrome DevTools Protocol Viewer]: https://chromedevtools.github.io/devtools-protocol/v8/ | ||
[Heap Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/HeapProfiler | ||
[CPU Profiler]: https://chromedevtools.github.io/devtools-protocol/tot/Profiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second look "tot" stays for tip of the tree while "v8" points to v8-inspector (node) so I think the original is more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked again and looks like problem in uBlock Origin. At morning today I received text "404" on page and tot
worked. Now I received 404 vs docs. Checked Firefox in incognito with adblocker and sometimes 404, sometimes all fine. Checked in Chrome in incognito (adblocker disabled) and old links works perfect all time.
I think I should close it, no changes required.
Thank you @lpinca
Checklist