Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix URLs to CPU/Heap profilers in inspector #29710

Closed
wants to merge 1 commit into from
Closed

doc: fix URLs to CPU/Heap profilers in inspector #29710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/inspector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,6 @@ session.post('HeapProfiler.takeHeapSnapshot', null, (err, r) => {

[`'Debugger.paused'`]: https://chromedevtools.github.io/devtools-protocol/v8/Debugger#event-paused
[`session.connect()`]: #inspector_session_connect
[CPU Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/Profiler
[Chrome DevTools Protocol Viewer]: https://chromedevtools.github.io/devtools-protocol/v8/
[Heap Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/HeapProfiler
[CPU Profiler]: https://chromedevtools.github.io/devtools-protocol/tot/Profiler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look "tot" stays for tip of the tree while "v8" points to v8-inspector (node) so I think the original is more appropriate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked again and looks like problem in uBlock Origin. At morning today I received text "404" on page and tot worked. Now I received 404 vs docs. Checked Firefox in incognito with adblocker and sometimes 404, sometimes all fine. Checked in Chrome in incognito (adblocker disabled) and old links works perfect all time.
I think I should close it, no changes required.
Screenshot from 2019-09-26 22-11-30

Thank you @lpinca

[Heap Profiler]: https://chromedevtools.github.io/devtools-protocol/tot/HeapProfiler