Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] net: treat ENOTCONN at shutdown as success #29968

Closed
wants to merge 1 commit into from
Closed

[v10.x] net: treat ENOTCONN at shutdown as success #29968

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Only trivial conflicts (process.binding() vs internalBinding()).

While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315
PR-URL: #29912

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
net: treat ENOTCONN at shutdown as success
1566f68 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: nodejs#26315

PR-URL: nodejs#29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added net Issues and PRs related to the net subsystem. v10.x labels Oct 14, 2019
This was referenced Oct 14, 2019
Merged
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 14, 2019 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/26012/ ✅
[CI failures are those identified in #29977]

devnexen
devnexen approved these changes Oct 14, 2019
View reviewed changes
lib/net.js Show resolved Hide resolved
BethGriggs pushed a commit that referenced this pull request Oct 16, 2019
@addaleax @BethGriggs
net: treat ENOTCONN at shutdown as success
69bf5b7 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

Backport-PR-URL: #29968
PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs
Copy link
Member

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @BethGriggs @devnexen