Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: treat ENOTCONN at shutdown as success #29912

Closed
wants to merge 1 commit into from
Closed

net: treat ENOTCONN at shutdown as success #29912

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
net: treat ENOTCONN at shutdown as success
4f13510 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: nodejs#26315
@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Oct 10, 2019
@addaleax addaleax mentioned this pull request Oct 10, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25937/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25967/

@addaleax addaleax added the review wanted PRs that need reviews. label Oct 11, 2019
@addaleax
Copy link
Member Author

@nodejs/collaborators This could use a review or two.

jasnell
jasnell approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there anything reasonable that can be included in the docs about this?

@addaleax
Copy link
Member Author

@jasnell I wouldn’t know how or what to document. This kind of just makes behaviour be what it should be in the first place.

@jasnell
Copy link
Member

jasnell commented Oct 11, 2019

Yeah, that's kind of what I expected.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed review wanted PRs that need reviews. labels Oct 11, 2019
@addaleax
Copy link
Member Author

Landed in 1447a79

@addaleax addaleax closed this Oct 12, 2019
addaleax added a commit that referenced this pull request Oct 12, 2019
@addaleax
net: treat ENOTCONN at shutdown as success
1447a79 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax deleted the shutdown-enotconn branch October 12, 2019 01:09
addaleax added a commit to addaleax/node that referenced this pull request Oct 14, 2019
@addaleax
net: treat ENOTCONN at shutdown as success
1566f68 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: nodejs#26315

PR-URL: nodejs#29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 14, 2019
Closed
Merged
BethGriggs pushed a commit that referenced this pull request Oct 16, 2019
@addaleax @BethGriggs
net: treat ENOTCONN at shutdown as success
69bf5b7 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

Backport-PR-URL: #29968
PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2019
Merged
addaleax added a commit that referenced this pull request Oct 25, 2019
@addaleax
net: treat ENOTCONN at shutdown as success
da58301 
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shutdown ENOTCONN on TLS.Socket._final
5 participants
@addaleax @nodejs-github-bot @jasnell @lpinca @BethGriggs