src: internalize per-isolate string properties #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanashworth
added
the
c++
|
LGTM. |
|
Nice. LGTM. |
Speeds up property lookups a little and it creates the string in the old space straight away. It's a little easier on the garbage collector because it doesn't have to track eternalized strings in the new space. PR-URL: nodejs#3060 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Internalized strings are created in the old space and that is where they eventually would end up anyway when created as normal strings. PR-URL: nodejs#3060 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
bnoordhuis
force-pushed
the
internalize-strings
branch
from
e9d62ec
to
212c9c0
Compare
bnoordhuis
added a commit
that referenced
this pull request
Sep 30, 2015
Speeds up property lookups a little and it creates the string in the old space straight away. It's a little easier on the garbage collector because it doesn't have to track eternalized strings in the new space. PR-URL: #3060 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
bnoordhuis
added a commit
that referenced
this pull request
Sep 30, 2015
Internalized strings are created in the old space and that is where they eventually would end up anyway when created as normal strings. PR-URL: #3060 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This was referenced Sep 30, 2015
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up property lookups a little and it creates the string in the
old space straight away. It's a little easier on the garbage collector
because it doesn't have to track eternalized strings in the new space.
R=@trevnorris?
There are more places the comment above applies to. I started with the most obvious ones.