Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: internalize per-isolate string properties #3060

Merged
merged 2 commits into from
Sep 26, 2015
Merged

src: internalize per-isolate string properties #3060

merged 2 commits into from
Sep 26, 2015

Commits on Sep 26, 2015

  1. src: internalize per-isolate string properties 

    Speeds up property lookups a little and it creates the string in the
old space straight away.  It's a little easier on the garbage collector
because it doesn't have to track eternalized strings in the new space.

PR-URL: nodejs#3060
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    590ee58 View commit details
    Browse the repository at this point in the history

  2. src: internalize binding function property names 

    Internalized strings are created in the old space and that is where they
eventually would end up anyway when created as normal strings.

PR-URL: nodejs#3060
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    212c9c0 View commit details
    Browse the repository at this point in the history