Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enable backtrace when V8 is built for PPC and S390x #32113

Closed
wants to merge 2 commits into from
Closed

build: enable backtrace when V8 is built for PPC and S390x #32113

wants to merge 2 commits into from

Conversation

mmarchini
Copy link
Contributor

Refs: nodejs/node-v8#119

Cherry-picked from canary-base

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@mmarchini mmarchini requested a review from targos March 6, 2020 00:38
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Mar 6, 2020
@sam-github
Copy link
Contributor

cc: @nodejs/platform-ppc @nodejs/platform-s390

@sam-github sam-github added ppc Issues and PRs related to the Power architecture. s390 Issues and PRs related to the s390 architecture. labels Mar 6, 2020
@mmarchini mmarchini mentioned this pull request Mar 6, 2020
Closed
15 tasks
bnoordhuis
bnoordhuis approved these changes Mar 6, 2020
View reviewed changes
common.gypi Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member

mhdawson commented Mar 6, 2020

@miladfarca can you take a look as well?

@miladfarca
Copy link
Contributor

Changes lgtm.

mhdawson
mhdawson approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmarchini @bnoordhuis
fixup! build: enable backtrace when V8 is built for PPC and S390x
a2254ea 
Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 8, 2020 •
edited by mmarchini
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29621/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2921/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29627/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29628/

mmarchini pushed a commit that referenced this pull request Mar 8, 2020
@targos @mmarchini
build: enable backtrace when V8 is built for PPC and S390x
c49286b 
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@mmarchini
Copy link
Contributor Author

Landed in c49286b

@mmarchini mmarchini closed this Mar 8, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@targos @MylesBorins
build: enable backtrace when V8 is built for PPC and S390x
7c739aa 
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
@targos @codebytere
build: enable backtrace when V8 is built for PPC and S390x
0406881 
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@targos @codebytere
build: enable backtrace when V8 is built for PPC and S390x
8249c3b 
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
@targos @codebytere
build: enable backtrace when V8 is built for PPC and S390x
8dc416b 
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@targos @codebytere
build: enable backtrace when V8 is built for PPC and S390x
8a0b0a7 
Refs: nodejs/node-v8#119

PR-URL: #32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere added a commit to electron/electron that referenced this pull request Apr 13, 2020
@codebytere
Fixup smis patch
71d0853 
nodejs/node#32113
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Oct 5, 2020
@targos @richardlau
build: enable backtrace when V8 is built for PPC and S390x
020ba1a 
Refs: nodejs/node-v8#119

PR-URL: nodejs#32113
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Oct 5, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miladfarca miladfarca miladfarca approved these changes

@mhdawson mhdawson mhdawson approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. ppc Issues and PRs related to the Power architecture. s390 Issues and PRs related to the s390 architecture. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mmarchini @sam-github @mhdawson @miladfarca @nodejs-github-bot @bnoordhuis @addaleax @targos