Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 8.1 #32116

Closed
wants to merge 24 commits into from
Closed

deps: update V8 to 8.1 #32116

wants to merge 24 commits into from

Conversation

mmarchini
Copy link
Contributor

@mmarchini mmarchini commented Mar 6, 2020

Chrome release date: Mar 17th, 2020.

There's one outstanding issue on 8.0 (nodejs/node-v8#120), but it might not be worth blocking the upgrade because of that (we're unlikely to see that issue outside very specific, synthetic test cases).

Depends on:

Current failing tests and builds:

  • sequential/test-inspector-break-when-eval is flaky (likely the same as nodejs/node-v8#120)
    • Child process is crashing with SIGSEGV, so it's likely the same issue.
  • Removed MemoryMeasurement::Request::= being called (only Windows is complaining)
  • ASAN build is broken on CI (skip failures deps: update V8 to 8.1 #32116 (comment))

Flaky tests (possibly introduced here):

Flaky tests (seen before)

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Mar 6, 2020
@mmarchini mmarchini changed the title [WIP] deps: update V8 to 8.0 [WIP] deps: update V8 to 8.1 Mar 6, 2020
@nodejs-github-bot

This comment has been minimized.

@gengjiawen

This comment has been minimized.

@gengjiawen

This comment has been minimized.

@Flarna
Copy link
Member

Flarna commented Mar 6, 2020

@mmarchini I expect this is preparation for Node.js 14.
Or is it planned to move 13.x also further than 7.9?

@targos

This comment has been minimized.

@mmarchini
Copy link
Contributor Author

@gengjiawen thanks, I cherry picked that pull request as well.

@Flarna my main goal is to upgrade master so we don't fall too behind from V8, if we can get it working on time it should make the cut for v14. AFAIK there was no planning/roadmap of V8 version for v13.x, and I believe it will stay on 7.9 (but if someone successfully backports 8.0 or 8.1 to v13.x before April/May, I don't think collaborators would block it).

@targos yes, most errors we're seeing right now are related to the MemoryMeasurement API which we started using on Node.js a couple weeks ago. I'll investigate further today, should be able to fix at least one of the errors we're getting on node-v8 as well.

@nodejs-github-bot

This comment has been minimized.

@gengjiawen

This comment has been minimized.

@mmarchini

This comment has been minimized.

@gengjiawen

This comment has been minimized.

@gengjiawen

This comment has been minimized.

@mmarchini

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@targos

This comment has been minimized.

@targos targos linked an issue Mar 7, 2020 that may be closed by this pull request
@mmarchini

This comment has been minimized.

@targos

This comment has been minimized.

@targos

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 1, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 2, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 3, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to targos/node that referenced this pull request Oct 3, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Oct 4, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 4, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 5, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 6, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 7, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 8, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 9, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 10, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to targos/node that referenced this pull request Oct 10, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Oct 11, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Oct 11, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 11, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 12, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 13, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 14, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 15, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 16, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 17, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 18, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 19, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 20, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 21, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 22, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 23, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 24, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Oct 25, 2022
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs/node#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V8 release v8.0