-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: workaround for gclient python3 issues #32140
Conversation
gclient doesn't support Python 3 yet. To workaround that problem, add an enviroment variable to override the Python version used by ./configure. Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
cc @nodejs/python |
Do we really need to rely on gclient? If it was a production worthy tool, surely it would have been upgraded by now. |
Just looking at a recent gclient commit, it seems that Python 3 is now supported? |
Yes, gclient is the only supported way to build V8. The alternative would be for us to maintain gyp files for V8 tests as well, which is not worth it.
Oh, nice. Python 3 support is behind an environment variable apparently. Let me test locally (but I think it never failed locally for me, so maybe there's also a problem in our CI, in which case I would rather land this to unbreak the CI and investigate the issue further later). |
V8 CI for this PR: https://ci.nodejs.org/job/node-test-commit-v8-linux/2928/ V8 CI with V8 CI on canary-base with |
I was just able to run |
Still failing, even though gclient doesn't complain about Python 3 with the environment variable set.
I'm running one with I think there's something else wrong in our CI. But investigating it will probably take time, so I'm still in favor of landing this PR to unbreak our CI. |
gclient doesn't support Python 3 yet. To workaround that problem, add an enviroment variable to override the Python version used by ./configure. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: #32140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Landed in de8fab9 |
gclient doesn't support Python 3 yet. To workaround that problem, add an enviroment variable to override the Python version used by ./configure. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: #32140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
gclient doesn't support Python 3 yet. To workaround that problem, add an
enviroment variable to override the Python version used by ./configure.
Signed-off-by: Matheus Marchini mmarchini@netflix.com
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes