Platform updates for Node.js 14 #32812

richardlau · 2020-04-13T11:45:22Z

doc: remove SmartOS from official binaries
Based on feedback from Joyent, the SmartOS builds are largely unusable
without bundling all of the libraries used to build the binary so are
being dropped starting from Node.js 14. We will still test SmartOS in
the CI.
doc: update Centos/RHEL releases use devtoolset-8

cc @nodejs/build @nodejs/platform-smartos @nodejs/releasers

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Based on feedback from Joyent, the SmartOS builds are largely unusable without bundling all of the libraries used to build the binary so are being dropped starting from Node.js 14. We will still test SmartOS in the CI. Signed-off-by: Richard Lau <riclau@uk.ibm.com>

richardlau · 2020-04-13T13:29:46Z

I think the semver-major cutoff for Node.js 14 has already passed so this will need @nodejs/tsc approval to go into 14.x. (I recommend this does go into 14.x to accurately reflect the releases and how they are built.)

mcollina

lgtm

richardlau · 2020-04-13T14:13:43Z

BUILDING.md

 | linux-arm64           | CentOS 7 with devtoolset-6 / GCC 6                                       |
 | linux-armv7l          | Cross-compiled on Ubuntu 16.04 x64 with [custom GCC toolchain](https://github.com/rvagg/rpi-newer-crosstools)   |


@sam-github @rvagg where are we re. the arm builds?

Last night's daily built and passed on gcc 8: https://ci.nodejs.org/job/node-test-commit-arm/30719/nodes=centos7-arm64-gcc8/consoleFull I'm not familiar enough with arm architecture variants to comment much past that.

https://ci.nodejs.org/job/node-cross-compile/28583/nodes=cross-compiler-armv7-gcc-6/ is the fanned build, it uses ubuntu 16.04 and gcc 6.

The difference between node-test-commit-arm and node-test-commit-arm-fanned is not clear from the names -- it looks like the "fanned" is an implementation optimization, but the architectures are different? Maybe fanned is armv7l, and non-fanned is arm64?

Been thinking a bit more on this. I don't think we should switch to gcc8 for the armv7 binaries unless there's a reason V8 will force that on us. The only reason we can get away with that on the centos7 builds is because of devtoolset libc magic which we don't get outside of devtoolset.

But we are going to have to deal with the Ubuntu 16.04 cross compiler machines. I think you should change that to 18.04 here but it needs the work to be done - initially just adding 3 new cross compilers to CI (2 ci, 1 release) and maybe migrating the older ones across if we can prove stability of the binaries. I guess this is all on me! What's our timeline with 14?

Updated cross compiler machine to Ubuntu 18.04. Current timeline as I understand it is that @BethGriggs was planning a final update/rc build this week after v13.13.0 goes out (so that the changelog for 14.0.0 can be generated as a diff in commits to it) with the release planned for next week (21 April 2020).

In terms of timeline for v14.x, I'm going to integrate the last set of functional changes today and start finalising the changelog. But, I can easily integrate documentation PR's like these up until ~Monday 20th April. Release planned to go out 21st April.

BUILDING.md

rvagg · 2020-04-14T00:33:38Z

Pulling part of my inline comment out for visibility: is there any reason GCC 6 would get us into trouble over the life of v14? We're not likely to hit C++ language limtations soon with V8 are we? @targos perhaps?

addaleax · 2020-04-14T00:35:11Z

@rvagg I wouldn’t expect any complications from using GCC 6.

(And fwiw, I still use it on one of my machines for building Node.js currently.)

Releases built on Centos/RHEL have been updated to use devtoolset-8. Signed-off-by: Richard Lau <riclau@uk.ibm.com>

Update cross compiler machine for Linux armv7 to Ubuntu 18.04. Signed-off-by: Richard Lau <riclau@uk.ibm.com>

targos · 2020-04-14T08:49:50Z

@rvagg My answer about GCC 6 was:

Chromium doesn't support C++17 yet, so I think GCC 6 is still OK.

sam-github · 2020-04-15T19:05:16Z

Landed in d699fdd...f22a9ca

Based on feedback from Joyent, the SmartOS builds are largely unusable without bundling all of the libraries used to build the binary so are being dropped starting from Node.js 14. We will still test SmartOS in the CI. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32812 Refs: nodejs/build#2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Releases built on Centos/RHEL have been updated to use devtoolset-8. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32812 Refs: nodejs/build#2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Update cross compiler machine for Linux armv7 to Ubuntu 18.04. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32812 Refs: nodejs/build#2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Based on feedback from Joyent, the SmartOS builds are largely unusable without bundling all of the libraries used to build the binary so are being dropped starting from Node.js 14. We will still test SmartOS in the CI. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32812 Refs: nodejs/build#2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Releases built on Centos/RHEL have been updated to use devtoolset-8. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32812 Refs: nodejs/build#2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Update cross compiler machine for Linux armv7 to Ubuntu 18.04. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32812 Refs: nodejs/build#2168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

- (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](#31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) - src: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](#30782) It is possible that this change will impact some native addons using `ArrayBuffer`. - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](#32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. - [#30786](#30786) - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](#32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](#32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](#31553) - module: remove experimental modules warning (Guy Bedford) [#31974](#31974) PR-URL: #32181

Deprecations: - (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](#31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) ECMAScript Modules - Experimental Warning Removal: - module: remove experimental modules warning (Guy Bedford) [#31974](#31974) In Node.js 13 we removed the need to include the --experimental-modules flag, but when running EcmaScript Modules in Node.js, this would still result in a warning ExperimentalWarning: The ESM module loader is experimental. As of Node.js 14 there is no longer this warning when using ESM in Node.js. However, the ESM implementation in Node.js remains experimental. As per our stability index: “The feature is not subject to Semantic Versioning rules. Non-backward compatible changes or removal may occur in any future release.” Users should be cautious when using the feature in production environments. Please keep in mind that the implementation of ESM in Node.js differs from the developer experience you might be familiar with. Most transpilation workflows support features such as optional file extensions or JSON modules that the Node.js ESM implementation does not support. It is highly likely that modules from transpiled environments will require a certain degree of refactoring to work in Node.js. It is worth mentioning that many of our design decisions were made with two primary goals. Spec compliance and Web Compatibility. It is our belief that the current implementation offers a future proof model to authoring ESM modules that paves the path to Universal JavaScript. Please read more in our documentation. The ESM implementation in Node.js is still experimental but we do believe that we are getting very close to being able to call ESM in Node.js “stable”. Removing the warning is a huge step in that direction. Migrate to new V8 ArrayBuffer API: - src: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](#30782) It is possible that this change will impact some native addons using `ArrayBuffer`. Toolchain and Compiler Upgrades: - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](#32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. Native addons are only broken if they interact with `std::shared_ptr`. This is expected to be fixed in a later version of Node.js 14. - [#30786](#30786) Update to V8 8.1: - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) Other Notable Changes: - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](#32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](#32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](#31553) PR-URL: #32181

Deprecations: - (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) [#31166](#31166) - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) [#28396](#28396) - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) [#31164](#31164) - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) [#31167](#31167) - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell)[#31169](#31169) - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) [#32116](#32116) - (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL (James M Snell) [#31165](#31165) - (SEMVER-MINOR) doc: deprecate process.mainModule (Antoine du HAMEL) [#32232](#32232) - (SEMVER-MINOR) doc: deprecate process.umask() with no arguments (Colin Ihrig) [#32499](#32499) ECMAScript Modules - Experimental Warning Removal: - module: remove experimental modules warning (Guy Bedford) [#31974](#31974) In Node.js 13 we removed the need to include the --experimental-modules flag, but when running EcmaScript Modules in Node.js, this would still result in a warning ExperimentalWarning: The ESM module loader is experimental. As of Node.js 14 there is no longer this warning when using ESM in Node.js. However, the ESM implementation in Node.js remains experimental. As per our stability index: “The feature is not subject to Semantic Versioning rules. Non-backward compatible changes or removal may occur in any future release.” Users should be cautious when using the feature in production environments. Please keep in mind that the implementation of ESM in Node.js differs from the developer experience you might be familiar with. Most transpilation workflows support features such as optional file extensions or JSON modules that the Node.js ESM implementation does not support. It is highly likely that modules from transpiled environments will require a certain degree of refactoring to work in Node.js. It is worth mentioning that many of our design decisions were made with two primary goals. Spec compliance and Web Compatibility. It is our belief that the current implementation offers a future proof model to authoring ESM modules that paves the path to Universal JavaScript. Please read more in our documentation. The ESM implementation in Node.js is still experimental but we do believe that we are getting very close to being able to call ESM in Node.js “stable”. Removing the warning is a huge step in that direction. New V8 ArrayBuffer API: * **src**: migrate to new V8 ArrayBuffer API (Thang Tran) [#30782](#30782) Multiple ArrayBuffers pointing to the same base address are no longer allowed by V8. This may impact native addons. Toolchain and Compiler Upgrades: - (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x (AshCripps)[#32454](#32454) - (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8 (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) doc: remove SmartOS from official binaries (Richard Lau) [#32812](#32812) - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) [#31954](#31954) It is expected that there will be an ABI mismatch on ARM between the Node.js binary and native addons. Native addons are only broken if they interact with `std::shared_ptr`. This is expected to be fixed in a later version of Node.js 14. - [#30786](#30786) Update to V8 8.1: - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) [#32116](#32116) Other Notable Changes: - cli, report: move --report-on-fatalerror to stable (Colin Ihrig) [#32496](#32496) - deps: upgrade to libuv 1.37.0 (Colin Ihrig) [#32866](#32866) - fs: add fs/promises alias module (Gus Caplan) [#31553](#31553) PR-URL: #32181

richardlau added semver-major PRs that contain breaking changes and should be released in the next major version. notable-change PRs with changes that should be highlighted in changelogs. labels Apr 13, 2020

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 13, 2020

richardlau added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Apr 13, 2020

cjihrig approved these changes Apr 13, 2020

View reviewed changes

richardlau mentioned this pull request Apr 13, 2020

Platform requirements for Node.js 14 nodejs/build#2168

Closed

8 tasks

mcollina approved these changes Apr 13, 2020

View reviewed changes

richardlau commented Apr 13, 2020

View reviewed changes

BethGriggs approved these changes Apr 13, 2020

View reviewed changes

sam-github reviewed Apr 13, 2020

View reviewed changes

BUILDING.md Outdated Show resolved Hide resolved

richardlau added 2 commits April 14, 2020 04:36

doc: update Centos/RHEL releases use devtoolset-8

27bd7d8

Releases built on Centos/RHEL have been updated to use devtoolset-8. Signed-off-by: Richard Lau <riclau@uk.ibm.com>

doc: update cross compiler machine for Linux armv7

6ba4f7e

Update cross compiler machine for Linux armv7 to Ubuntu 18.04. Signed-off-by: Richard Lau <riclau@uk.ibm.com>

richardlau force-pushed the building branch from df4a32b to 6ba4f7e Compare April 14, 2020 08:40

gengjiawen approved these changes Apr 14, 2020

View reviewed changes

sam-github approved these changes Apr 14, 2020

View reviewed changes

jasnell approved these changes Apr 15, 2020

View reviewed changes

sam-github closed this Apr 15, 2020

BethGriggs mentioned this pull request Apr 20, 2020

2020-04-21, Version 14.0.0 (Current) #32181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Platform updates for Node.js 14 #32812

Platform updates for Node.js 14 #32812

richardlau commented Apr 13, 2020

richardlau commented Apr 13, 2020

mcollina left a comment

richardlau Apr 13, 2020

sam-github Apr 13, 2020

rvagg Apr 14, 2020

richardlau Apr 14, 2020

BethGriggs Apr 14, 2020

rvagg commented Apr 14, 2020

addaleax commented Apr 14, 2020

targos commented Apr 14, 2020

sam-github commented Apr 15, 2020

		\| linux-arm64 \| CentOS 7 with devtoolset-6 / GCC 6 \|
		\| linux-armv7l \| Cross-compiled on Ubuntu 16.04 x64 with [custom GCC toolchain](https://github.com/rvagg/rpi-newer-crosstools) \|

Platform updates for Node.js 14 #32812

Platform updates for Node.js 14 #32812

Conversation

richardlau commented Apr 13, 2020

Checklist

richardlau commented Apr 13, 2020

mcollina left a comment

Choose a reason for hiding this comment

richardlau Apr 13, 2020

Choose a reason for hiding this comment

sam-github Apr 13, 2020

Choose a reason for hiding this comment

rvagg Apr 14, 2020

Choose a reason for hiding this comment

richardlau Apr 14, 2020

Choose a reason for hiding this comment

BethGriggs Apr 14, 2020

Choose a reason for hiding this comment

rvagg commented Apr 14, 2020

addaleax commented Apr 14, 2020

targos commented Apr 14, 2020

sam-github commented Apr 15, 2020