-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update icu to include tzdata2020a #33362
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
@codebytere thanks, i am testing it now.. |
By the way: I landed #30364 thanks @apaprocki |
LGTM
and also:
|
srl295
approved these changes
May 19, 2020
failures don't seem relevant, but not sure.
|
@srl295 it's not related - it's an issue caused by a buildflag interacting with this commit |
Landed in ed9be3a |
codebytere
added a commit
that referenced
this pull request
May 19, 2020
PR-URL: #33362 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
codebytere
added a commit
that referenced
this pull request
May 21, 2020
PR-URL: #33362 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
This will need a backport to land on v12.x |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nodejs/Release#576.
Updates
source/data/in/icudt66l.dat
file with updated binary time zone data files corresponding to new IANA tzdata releases in unicode-org/icu@a951ab5.I followed the steps in #30364, but as i have not done this before I'd appreciate a confirmation that i did it correctly if possible.
cc @apaprocki @targos @srl295
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes