Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update icu to include tzdata2020a #33362

Closed
wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 12, 2020

Closes nodejs/Release#576.

Updates source/data/in/icudt66l.dat file with updated binary time zone data files corresponding to new IANA tzdata releases in unicode-org/icu@a951ab5.

I followed the steps in #30364, but as i have not done this before I'd appreciate a confirmation that i did it correctly if possible.

cc @apaprocki @targos @srl295

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@codebytere codebytere requested review from srl295 and targos May 12, 2020 01:32
@bricss bricss mentioned this pull request May 18, 2020
@codebytere
Copy link
Member Author

@srl295 @targos rebased and updated, PTAL when you can!

@srl295
Copy link
Member

srl295 commented May 19, 2020

@codebytere thanks, i am testing it now..

@srl295
Copy link
Member

srl295 commented May 19, 2020

By the way: I landed #30364 thanks @apaprocki

@srl295
Copy link
Member

srl295 commented May 19, 2020

LGTM

> process.versions.tz
'2020a'

and also:

# Node v12.16.3
$ env TZ='Africa/Casablanca' node -p "new Date('2020-05-26T00:00:00.000Z').toLocaleString()"
5/26/2020, 1:00:00 AM

# this PR
$ env TZ='Africa/Casablanca' ./out/Release/node -p "new Date('2020-05-26T00:00:00.000Z').toLocaleString()"
5/26/2020, 12:00:00 AM

@nodejs-github-bot
Copy link
Collaborator

@srl295
Copy link
Member

srl295 commented May 19, 2020

failures don't seem relevant, but not sure.

21:32:17   ...
21:32:17 ok 3010 pseudo-tty/test-tty-wrap
21:32:17   ---
21:32:17   duration_ms: 0.151
21:32:17   ...
21:32:17 make[1]: *** [Makefile:532: test-ci] Error 1
21:32:17 make: *** [Makefile:561: run-ci] Error 2
21:32:17 Build step 'Conditional steps (multiple)' marked build as failure
21:32:17 All downstream projects complete!
21:32:17 Performing Post build task...
21:32:17 Match found for : : True

@codebytere
Copy link
Member Author

@srl295 it's not related - it's an issue caused by a buildflag interacting with this commit

@codebytere
Copy link
Member Author

codebytere commented May 19, 2020

Landed in ed9be3a

@codebytere codebytere closed this May 19, 2020
codebytere added a commit that referenced this pull request May 19, 2020
PR-URL: #33362
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
@codebytere codebytere deleted the update-icu branch May 19, 2020 15:39
codebytere added a commit that referenced this pull request May 21, 2020
PR-URL: #33362
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
@targos
Copy link
Member

targos commented May 25, 2020

This will need a backport to land on v12.x

@codebytere codebytere mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imminent issue for Morocco users (tzdata2020a)
4 participants