Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.5.0 proposal #34093

Merged
merged 327 commits into from
Jun 30, 2020
Merged

v14.5.0 proposal #34093

merged 327 commits into from
Jun 30, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 28, 2020

2020-06-30, Version 14.5.0 (Current), @codebytere

Notable Changes

V8 engine is updated to version 8.3

This version includes performance improvements and now allows WebAssembly
modules to request memories up to 4GB in size.

For more information, have a look at the official V8 blog post.

Contributed by Matheus Marchini and Michaël Zasso - #33376.

Initial experimental implementation of EventTarget

This version introduces an new experimental API EventTarget, which provides a DOM interface implemented by objects that can receive events and may have listeners for them.

It is an adaptation of the Web API EventTarget.

Example Usage:

const target = getEventTargetSomehow();

target.addEventListener('foo', (event) => {
  console.log('foo event happened!');
});

Contributed by James Snell - #33556.

Semver-Minor Commits

  • [4ccaa537d4] - (SEMVER-MINOR) build: reset embedder string to "-node.0" (Michaël Zasso) #33376
  • [d194d20828] - (SEMVER-MINOR) cli: add alias for report-directory to make it consistent (AshCripps) #33587
  • [70398dbf60] - (SEMVER-MINOR) crypto: allow KeyObjects in postMessage (Tobias Nießen) #33360
  • [9b7ba87aa6] - (SEMVER-MINOR) deps: V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) #33376
  • [ce1a1ae621] - (SEMVER-MINOR) deps: V8: cherry-pick 74d50c5063b3 (Michaël Zasso) #32831
  • [aa7267a344] - (SEMVER-MINOR) deps: V8: cherry-pick e29c62b74854 (Michaël Zasso) #32831
  • [1512757a22] - (SEMVER-MINOR) deps: V8: cherry-pick 3f8dc4b2e5ba (Michaël Zasso) #32831
  • [3d9cf4bde6] - (SEMVER-MINOR) deps: V8: cherry-pick e1eac1b16c96 (Milad Farazmand) #32831
  • [cdeade308e] - (SEMVER-MINOR) deps: fix V8 8.3 on SmartOS (Colin Ihrig) #32831
  • [883840bc17] - (SEMVER-MINOR) deps: patch V8 to run on Xcode 8 (Matheus Marchini) #32831
  • [3831a541fb] - (SEMVER-MINOR) deps: V8: silence irrelevant warnings (Michaël Zasso) #32831
  • [e2fc08f216] - (SEMVER-MINOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32831
  • [74b623bd51] - (SEMVER-MINOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #32831
  • [0f5764aec2] - (SEMVER-MINOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32831
  • [be773fc3cf] - (SEMVER-MINOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #32831
  • [7aa41c6e6f] - (SEMVER-MINOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32831
  • [ce901e3906] - (SEMVER-MINOR) deps: update V8 dtrace & postmortem metadata (Colin Ihrig) #32831
  • [1123425dd1] - (SEMVER-MINOR) deps: update V8 to 8.3.110.9 (Michaël Zasso) #33376
  • [1c70b18da8] - (SEMVER-MINOR) events: initial implementation of experimental EventTarget (James M Snell) #33556
  • [cf97c56dab] - (SEMVER-MINOR) fs: implement lutimes (Maël Nison) #33399
  • [a24b8df7fb] - (SEMVER-MINOR) http: expose host and protocol on ClientRequest (wenningplus) #33803
  • [507a2ef31c] - (SEMVER-MINOR) http: add maxTotalSockets to agent class (rickyes) #33617
  • [e1e3ae1567] - (SEMVER-MINOR) http: return this from OutgoingMessage#destroy() (Colin Ihrig) #32789
  • [d87031def4] - (SEMVER-MINOR) http: return this from ClientRequest#destroy() (Colin Ihrig) #32789
  • [c7959557db] - (SEMVER-MINOR) http: return this from IncomingMessage#destroy() (Colin Ihrig) #32789
  • [a3a0c0e0fc] - (SEMVER-MINOR) http: added scheduling option to http agent (delvedor) #33278
  • [e3fd2f5a48] - (SEMVER-MINOR) http2: return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994
  • [7ccb021ffc] - (SEMVER-MINOR) http2: do not modify explicity set date headers (Pranshu Srivastava) #33160
  • [f66bb57c13] - (SEMVER-MINOR) process: add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) #33475
  • [33020256de] - (SEMVER-MINOR) src: store key data in separate class (Tobias Nießen) #33360
  • [44b9d08344] - (SEMVER-MINOR) src: add NativeKeyObject base class (Tobias Nießen) #33360
  • [13e633873e] - (SEMVER-MINOR) src: rename internal key handles to KeyObjectHandle (Tobias Nießen) #33360
  • [a3d0b0e2d7] - (SEMVER-MINOR) src: add equality operators for BaseObjectPtr (Anna Henningsen) #33772
  • [0720d1ff24] - (SEMVER-MINOR) src: introduce BaseObject base FunctionTemplate (Anna Henningsen) #33772
  • [5362fef3f5] - (SEMVER-MINOR) src: add public APIs to manage v8::TracingController (Anna Henningsen) #33850
  • [db2d1ca51b] - (SEMVER-MINOR) stream: runtime deprecate Transform._transformState (Robert Nagy) #32763
  • [b6da77756e] - (SEMVER-MINOR) test: stop testing --interpreted-frames-native-stack for s390x (Michaël Zasso) #32831
  • [5cad007408] - (SEMVER-MINOR) test: fix test-zlib-unused-weak on V8 8.2 (Matheus Marchini) #32831
  • [2c59f9bbe2] - (SEMVER-MINOR) tools: update V8 gypfiles for V8 8.3 (Michaël Zasso) #32831
  • [0ef6e0426f] - (SEMVER-MINOR) win: allow skipping the supported platform check (João Reis) #33176
  • [4e42eb5e14] - (SEMVER-MINOR) worker: add public method for marking objects as untransferable (Anna Henningsen) #33979
  • [4a37180b09] - (SEMVER-MINOR) worker: emit 'messagerror' events for failed deserialization (Anna Henningsen) #33772
  • [9692208a91] - (SEMVER-MINOR) worker: allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772
  • [eaccf842eb] - (SEMVER-MINOR) worker: allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772
  • [5b1fd10048] - (SEMVER-MINOR) worker,fs: make FileHandle transferable (Anna Henningsen) #33772
  • [c1f625fe1f] - (SEMVER-MINOR) zlib: add maxOutputLength option (unknown) #33516

Semver-Patch Commits

  • [ef05e1526a] - async_hooks: callback trampoline for MakeCallback (Stephen Belanger) #33801
  • [0eed22d6ed] - benchmark: fix EventTarget benchmark (Brian White) #34015
  • [bf56decc79] - benchmark: fix async-resource benchmark (Anna Henningsen) #33642
  • [26269be510] - benchmark: fixing http_server_for_chunky_client.js (Adrian Estrada) #33271
  • [c31d5145d9] - buffer: remove hoisted variable (Nikolai Vavilov) #33470
  • [43fd4746e9] - build: configure byte order for mips targets (Ben Noordhuis) #33898
  • [ebb2fb81fa] - build: add target specific build_type variable (Daniel Bevenius) #33925
  • [e8f7670b77] - build: add LINT_CPP_FILES to checkimports check (Daniel Bevenius) #33697
  • [1355d35a61] - build: output dots in "Build from tarball" action (Michaël Zasso) #33696
  • [153f5eda0e] - build: fix compiling addons with older versions of Node.js (Richard Lau) #33688
  • [7a4c689912] - build: fix node.gyp config (gengjiawen) #33685
  • [1f7a65529d] - build: add --v8-lite-mode flag (Maciej Kacper Jagiełło) #33541
  • [3ac05b75ca] - build: zlib build error on Windows on Arm (Richard Townsend) #33511
  • [fc032247e0] - build: fix GetCurrentThreadStackLimits error on Windows on Arm (Richard Townsend) #33511
  • [e393e879cf] - build: fix python-version selection with actions (Richard Lau) #33589
  • [8ed25eda60] - build: fix inability to detect correct python command in configure (Eli Schwartz) #32925
  • [8b887c4462] - build: fix makefile script on windows (Thomas) #33136
  • [85ce30fe57] - build: run full test suite in ASAN action (Anna Henningsen) #33170
  • [71c4d9174e] - build,win: add support for MSVC cross-compilation (Richard Townsend) #32867
  • [ac7946eb08] - build,win: add support for MSVC cross-compilation (Richard Townsend) #32867
  • [22b5ec19a2] - cli: support --experimental-top-level-await in NODE_OPTIONS (Dan Fabulich) #33495
  • [0a7f13e26b] - configure: account for CLANG_VENDOR when checking for llvm version (Nathan Blair) #33860
  • [a6a74ae1d5] - console: name console functions appropriately (Ruben Bridgewater) #33524
  • [9d24f71d45] - console: mark special console properties as non-enumerable (Ruben Bridgewater) #33524
  • [bce99867f7] - console: remove dead code (Ruben Bridgewater) #33524
  • [134ed0eea3] - crypto: fix wrong error message (Ben Bucksch) #33482
  • [5957afc31a] - deps: V8: cherry-pick 767e65f945e7 (Gus Caplan) #33859
  • [162092ea2a] - deps: V8: cherry-pick eec10a2fd8fa (Stephen Belanger) #33778
  • [499c7402b1] - deps: V8: cherry-pick 4e1bf2bc92bd (Milad Farazmand) #33702
  • [0524c7ad5d] - deps: V8: cherry-pick b5939c758924 (Milad Farazmand) #33702
  • [7ad6cfa005] - deps: V8: backport 22014de00115 (Joyee Cheung) #33300
  • [817befde11] - deps: V8: backport bb9f0c2b2fe9 (Joyee Cheung) #33300
  • [8f82692999] - deps: V8: backport ea0719b8ed08 (Joyee Cheung) #33300
  • [773d76ea04] - deps: uvwasi: cherry-pick 9e75217 (Colin Ihrig) #33521
  • [748720e7b6] - deps: V8: cherry-pick 548f6c81d424 (Dominykas Blyžė) #33484
  • [b0bce9b2a4] - deps: update node-inspect to v2.0.0 (Jan Krems) #33447
  • [ac459b34e7] - deps: V8: cherry-pick fa3e37e511ee (Anna Henningsen) #32885
  • [2bc79f5b50] - deps: V8: cherry-pick 2db93c023379 (Anna Henningsen) #32885
  • [8d47e8bf7b] - deps: update to uvwasi 0.0.9 (Colin Ihrig) #33445
  • [9d6fd4599d] - deps: upgrade to libuv 1.38.0 (Colin Ihrig) #33446
  • [33a662ad2d] - deps: update icu to include tzdata2020a (Shelley Vohr) #33362
  • [f151bde312] - (SEMVER-MINOR) dgram: allow typed arrays in .send() (Sarat Addepalli) #22413
  • [d4442b15bf] - dns: make dns.Resolver timeout configurable (Ben Noordhuis) #33472
  • [eb55d9e4b1] - dns: use ternary operator simplify statement (Wenning Zhang) #33234
  • [d61de303c9] - doc: specify maxHeaderCount alias for maxHeaderListPairs (Pranshu Srivastava) #33519
  • [4323346f5a] - doc: add allowed info strings to style guide (Derek Lewis) #34024
  • [0dbad26db4] - doc: fix lexical sorting of bottom-references in http doc (Pranshu Srivastava) #34007
  • [ec07e61f6a] - doc: clarify thread-safe function references (legendecas) #33871
  • [5a4dcfcf4c] - doc: use npm team for npm upgrades in collaborator guide (Rich Trott) #33999
  • [319707add2] - doc: correct default values in http2 docs (Rich Trott) #33997
  • [b4d0eebe7c] - doc: use a single space between sentences (Rich Trott) #33995
  • [24105a7f44] - doc: piping from async generators using pipeline() (WilliamConnatser) #33992
  • [9590d81349] - doc: revise text in dns module documentation introduction (Rich Trott) #33986
  • [ed26e8e2fb] - doc: update fs.md (Shakil-Shahadat) #33820
  • [6dc541778e] - doc: warn that tls.connect() doesn't set SNI (Alba Mendez) #33855
  • [d9c78ac270] - doc: fix lexical sorting of bottom-references in dns doc (Rich Trott) #33987
  • [98228b25af] - doc: change "GitHub Repo" to "Code repository" (Rich Trott) #33985
  • [645cd481e9] - doc: use Class: consistently (Rich Trott) #33978
  • [72e2fd315e] - doc: update WASM code sample (Pragyan Das) #33626
  • [894ec7d5c6] - doc: standardize on sentence case for headers (Rich Trott) #33889
  • [61de26a2f3] - doc: link readable._read in stream.md (Pranshu Srivastava) #33767
  • [76fe2a93a9] - doc: specify default encoding in writable.write (Pranshu Srivastava) #33765
  • [2427d6544b] - doc: move --force-context-aware option in cli.md (Daniel Bevenius) #33823
  • [fdaf0ca550] - doc: add snippet for AsyncResource and EE integration (Andrey Pechkurov) #33751
  • [8f5ac3865c] - doc: use single quotes in --tls-cipher-list (Daniel Bevenius) #33709
  • [922c13c6bb] - doc: fix misc. mislabeled code block info strings (Derek Lewis) #33548
  • [114d77e30b] - doc: standardize constructor doc header layout (Rich Trott) #33781
  • [b10d20385e] - doc: update V8 inspector example (Colin Ihrig) #33758
  • [785760448b] - doc: fix linting in doc-style-guide.md (Pranshu Srivastava) #33787
  • [2288840a8f] - doc: remove "currently" from repl.md (Rich Trott) #33756
  • [cc0f827182] - doc: remove "currently" from events.md (Rich Trott) #33756
  • [4a738e6462] - doc: remove "currently" from vm.md (Rich Trott) #33756
  • [bb29a8177f] - doc: remove "currently" from addons.md (Rich Trott) #33756
  • [f0597d9a6e] - doc: remove "currently" from util.md (Rich Trott) #33756
  • [095efac2ef] - doc: add formatting for version numbers to doc-style-guide.md (Rich Trott) #33755
  • [843ab3eb94] - doc: change "pre Node.js v0.10" to "prior to Node.js 0.10" (Rich Trott) #33754
  • [b565897996] - doc: remove default parameter value from header (Rich Trott) #33752
  • [ebf2378731] - doc: fix typo in cli.md for report-dir (AshCripps) #33725
  • [16b69818ba] - doc: remove shell dollar signs without output (Nick Schonning) #33692
  • [b3d500f949] - doc: add lint disabling comment for collaborator list (Rich Trott) #33719
  • [61bb789fa0] - doc: use consistent Default: in events (Colin Ihrig) #33678
  • [1e4edd8d75] - doc: remove "it is important" (Colin Ihrig) #33678
  • [cb8b9ec98a] - doc: fix urls to avoid redirection (sapics) #33614
  • [c184929975] - doc: improve buffer.md a tiny bit (Tom Nagle) #33547
  • [6d25b5753a] - doc: normalize Markdown code block info strings (Derek Lewis) #33542
  • [e7c3890901] - doc: normalize JavaScript code block info strings (Derek Lewis) #33531
  • [352adcb437] - doc: outline when origin is set to unhandledRejection (Ruben Bridgewater) #33530
  • [94177dae8e] - doc: add --experimental-top-level-await to man page (Colin Ihrig) #33529
  • [8e3a0d7773] - doc: update txt fandamental and ```raw code blocks (Zeke Sikelianos) #33028
  • [4cc391b495] - doc: normalize shell code block info strings (Derek Lewis) #33486
  • [24ada7acd4] - doc: normalize C code block info strings (Derek Lewis) #33507
  • [8c04e61f16] - doc: normalize Bash code block info strings (Derek Lewis) #33510
  • [7c87fc1c48] - doc: correct tls.rootCertificates to match implementation (Eric Bickle) #33313
  • [0c2b7c0adf] - doc: fix Buffer.from(object) documentation (Nikolai Vavilov) #33327
  • [de608c3124] - doc: fix typo in pathToFileURL example (Antoine du HAMEL) #33418
  • [23cf39ab78] - doc: eliminate dead space in API section's sidebar (John Gardner) #33469
  • [95e7a80cbf] - doc: mention --experimental-top-level-await flag (dfabulich) #33473
  • [64410f206e] - doc: normalize C++ code block info strings (Derek Lewis) #33483
  • [c8f79d80a4] - doc: fixed a grammatical error in path.md (Deep310) #33489
  • [500bad1103] - doc: correct CommonJS self-resolve spec (Guy Bedford) #33391
  • [4e74f050a7] - doc: fix readline key binding documentation (Ruben Bridgewater) #33361
  • [7c553cd4f6] - doc: claim ABI version 85 for Electron 11 (Shelley Vohr) #33375
  • [4cc5e9668f] - doc: document module.path (Antoine du Hamel) #33323
  • [c1fe152132] - doc: add fs.open() multiple constants example (Ethan Arrowood) #33281
  • [b02cfef510] - doc: fix typos in handle scope descriptions (Tobias Nießen) #33267
  • [d4e871424f] - doc: update function description for decipher.setAAD (Jonathan Buhacoff) #33095
  • [e2484b24cb] - doc: add comment about highWaterMark limit (Benjamin Gruenbaum) #33432
  • [b8c88891a6] - doc: clarify about the Node.js-only extensions in perf_hooks (Joyee Cheung) #33199
  • [d1efdb29b4] - doc: document ICU time zone data update process (Andrew Paprocki) #30364
  • [1d918b67ca] - doc,stream: split finish and end events into separate entries (Rich Trott) #33881
  • [af9fb5969d] - doc,tools: properly syntax highlight API ref docs (Derek Lewis) #33442
  • [122d2b5c02] - domain: remove native domain code (Stephen Belanger) #33801
  • [e060060aa2] - errors: fully inspect errors on exit (Ruben Bridgewater) #33523
  • [aca07f428e] - errors: skip fatal error highlighting on windows (Thomas) #33132
  • [50adccadc1] - esm: fix loader hooks doc annotations (Derek Lewis) #33563
  • [5bef20c2fc] - esm: share package.json cache between ESM and CJS loaders (Kirill Shatskiy) #33229
  • [828d5d22eb] - esm: doc & validate source values for formats (Bradley Farias) #32202
  • [2724514f53] - event: cancelBubble is a property (Benjamin Gruenbaum) #34015
  • [c9dec0c0f0] - event: cancelBubble is a property (Benjamin Gruenbaum) #33613
  • [0c32920a82] - events: fix add-remove-add case in EventTarget (Anna Henningsen) #34056
  • [c34f4743c4] - events: improve argument handling, start passive (James M Snell) #34015
  • [ea1a2d7bc9] - events: support dispatching event from event (James M Snell) #34015
  • [5ce153365e] - events: add event-target tests (James M Snell) #34015
  • [91b6c093b1] - events: support event handlers (Benjamin Gruenbaum) #34015
  • [b392fdd4aa] - events: expose Event statics (Benjamin Gruenbaum) #34015
  • [cd3a1429a3] - events: Handle a range of this values for dispatchEvent (Zirak) #34015
  • [aa1cb3f186] - events: fix EventTarget support (Benjamin Gruenbaum) #34015
  • [0f0f4e0c40] - events: fix depth in customInspectSymbol and clean up (Denys Otrishko) #34015
  • [6ce3293cc4] - events: use internal/validators in event_target.js (Denys Otrishko) #34015
  • [eb01214ab2] - events: use property, primordials (Benjamin Gruenbaum) #33775
  • [667195ef8f] - events: improve listeners() performance (Brian White) #33863
  • [f1b0291d82] - events: lazy load perf_hooks for EventTarget (James M Snell) #33717
  • [c291ce599c] - events: improve arrayClone performance (Brian White) #33774
  • [a3ef2b7335] - events: support useCapture boolean (Benjamin Gruenbaum) #33618
  • [2e6eceac5c] - events: set target property to null (Benjamin Gruenbaum) #33615
  • [bc2e821ccc] - events: deal with no argument case (Benjamin Gruenbaum) #33611
  • [e7bce2e03a] - events: deal with Symbol() passed to event constructor (Benjamin Gruenbaum) #33612
  • [27c90efce0] - events: variable originalListener is useless (fuxingZhang) #33596
  • [2a29ced050] - events: fix event-target enumerable keys (Benjamin Gruenbaum) #33616
  • [f3d0d3089d] - events: add tests, better toString (Benjamin Gruenbaum) #33622
  • [95cbfcec99] - fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN (Kirill Shatskiy) #33395
  • [b894df860a] - fs: fix realpath inode link caching (Denys Otrishko) #33945
  • [b280c86213] - fs: support util.promisify for fs.readv (Lucas Holmquist) #33590
  • [2c03661860] - fs: unify style in preprocessSymlinkDestination (Bartosz Sosnowski) #33496
  • [b675ea0272] - fs: replace checkPosition with validateInteger (rickyes) #33277
  • [a90b96f338] - fs: refactor the import of internalUtil (rickyes) #33296
  • [a0a61b81a5] - http: used already defined validator for boolean check (Yash Ladha) #33731
  • [6dbd63c8ba] - Revert "http: set IncomingMessage.destroyed" (Robert Nagy) #33686
  • [feb6e1ffb8] - http: don't throw on Uint8Arrays for http.ServerResponse#write (Pranshu Srivastava) #33155
  • [bcdf7e94be] - http: simplify Agent initialization (himself65) #33551
  • [c2aad813c0] - http: tidy up exposure of header validation (Osher) #33371
  • [0752d2309f] - http2: always call callback on Http2ServerResponse#end (Pranshu Srivastava) #33911
  • [d8aeafb4bf] - http2: add writable* properties to compat api (Pranshu Srivastava) #33506
  • [0b34c4fb75] - http2: add type checks for Http2ServerResponse.end (Pranshu Srivastava) #33146
  • [cc74f3c67c] - http2: use Object.create(null) for getHeaders (Pranshu Srivastava) #33188
  • [8457033d83] - http2: reuse ._onTimeout() in Http2Session and Http2Stream classes (rickyes) #33354
  • [c972ce200e] - http2: comment on usage of Object.create(null) (Pranshu Srivastava) #33183
  • [e58f14fee7] - inspector: drop 'chrome-' from inspector url (Colin Ihrig) #33758
  • [42df2baa21] - inspector: throw error when activating an already active inspector (Joyee Cheung) #33015
  • [c9489f2f23] - internal: rename error-serdes for consistency (Evan Lucas) #33793
  • [b7690da65e] - lib: improve debuglog() performance (Brian White) #32260
  • [b6ef6c8476] - lib: remove manual exception handling in queueMicrotask (Gus Caplan) #33859
  • [ec01867623] - lib: replace charCodeAt with fixed Unicode (rickyes) #32758
  • [76123b9ae7] - lib: add Int16Array primordials (Sebastien Ahkrin) #31205
  • [59d435ed4d] - lib: update TODO comments (Ruben Bridgewater) #33361
  • [e62a8b5007] - lib: update executionAsyncId/triggerAsyncId comment (Daniel Bevenius) #33396
  • [4ae4073abf] - lib,src: remove cpu profiler idle notifier (Ben Noordhuis) #34010
  • [fc7cad828b] - meta: introduce codeowners again (James M Snell) #33895
  • [b162c532d7] - meta: fix a typo in the flaky test template (Colin Ihrig) #33677
  • [148c1f1344] - meta: wrap flaky test template at 80 characters (Colin Ihrig) #33677
  • [2aa6469bea] - meta: add flaky test issue template (Ash Cripps) #33500
  • [84a5e6cec8] - module: fix error message about importing names from cjs (Fábio Santos) #33882
  • [8c9e3a9dfb] - module: remove dynamicInstantiate loader hook (Jan Krems) #33501
  • [e924439d96] - n-api: document nextTick timing in callbacks (Mathias Buus) #33804
  • [524daf89a1] - n-api: ensure scope present for finalization (Michael Dawson) #33508
  • [e83642f73d] - n-api: remove napi\_env::CallIntoModuleThrow (Gabriel Schulhof) #33570
  • [4c235b07ae] - Revert "n-api: detect deadlocks in thread-safe function" (Anna Henningsen) #33453
  • [022dcebcd8] - napi: add __wasm32__ guards (Gus Caplan) #33597
  • [164461edfd] - net: refactor check for Windows (rickyes) #33497
  • [e0b0ddd257] - querystring: fix stringify for empty array (sapics) #33918
  • [e8572e7070] - querystring: improve stringify() performance (Brian White) #33669
  • [011fe1d443] - repl: add builtinModules (Ruben Bridgewater) #33295
  • [71d6599191] - repl: simplify repl autocompletion (Ruben Bridgewater) #33450
  • [1330cfc2a9] - repl: support optional chaining during autocompletion (Ruben Bridgewater) #33450
  • [9760c6caff] - src: add errorProperties on process.report (himself65) #28426
  • [da81930b13] - src: tolerate EPERM returned from tcsetattr (patr0nus) #33944
  • [c1664a9008] - src: clang_format base_object (Yash Ladha) #33680
  • [a789474945] - src: fix ParseEncoding (sapics) #33957
  • [74f4aae22f] - src: remove unnecessary calculation in base64.h (sapics) #33839
  • [c492a2715e] - src: use ToLocal in node_os.cc (wenningplus) #33939
  • [9a52cd9cc0] - src: handle empty Maybe(Local) in node_util.cc (Anna Henningsen) #33867
  • [e1bebf13db] - src: fix FastStringKey equal operator (sapics) #33748
  • [0dd67d992e] - src: reduce scope of code cache mutex (Anna Henningsen) #33980
  • [cd0ae4007f] - src: improve indention for upd_wrap.cc (gengjiawen) #33976
  • [6014e4e0b8] - src: remove unnecessary ToLocalChecked call (Daniel Bevenius) #33902
  • [4715a41c1c] - src: simplify alignment-handling code (Anna Henningsen) #33884
  • [33cff40bb7] - src: remove ref to tools/generate_code_cache.js (Daniel Bevenius) #33825
  • [dfa0ee13ee] - src: remove unused vector include in string_bytes (Daniel Bevenius) #33824
  • [fb2b0a094b] - src: avoid unnecessary ToLocalChecked calls (Daniel Bevenius) #33824
  • [07c21d0d27] - src: reduce FileHandle size by reordering fields (Anna Henningsen) #33784
  • [83aaad7ec3] - src: do not track BaseObjects via cleanup hooks (Anna Henningsen) #33809
  • [f8dddd3416] - src: handle missing TracingController everywhere (Anna Henningsen) #33815
  • [3b71aa8029] - src: remove unused ERR\_TRANSFERRING\_EXTERNALIZED\_SHAREDARRAYBUFFER (Anna Henningsen) #33810
  • [1f996b7372] - src: simplify Reindent function in json_utils.cc (sapics) #33722
  • [cdcd76810e] - src: add "missing" bash completion options (Daniel Bevenius) #33744
  • [cc8d70531d] - src: use Check() instead of FromJust in environment (Daniel Bevenius) #33706
  • [858c6b9dfd] - src: use ToLocal in SafeGetenv (Daniel Bevenius) #33695
  • [c2f49319b7] - src: remove unnecessary ToLocalChecked call (Daniel Bevenius) #33683
  • [21f1e64737] - src: simplify format in node_file.cc (himself65) #33660
  • [c3728c6235] - src: simplify MaybeStackBuffer::capacity() (Ben Noordhuis) #33602
  • [7725ff392c] - src: remove superfluous inline keywords (James M Snell) #33291
  • [27e9cb7e85] - src: turn AllocatedBuffer into thin wrapper around v8::BackingStore (James M Snell) #33291
  • [d8f040e33d] - src: extract AllocatedBuffer from env.h (James M Snell) #33291
  • [a8824ae0a5] - src: avoid OOB read in URL parser (Anna Henningsen) #33640
  • [6ef2efe33a] - src: use MaybeLocal.ToLocal instead of IsEmpty worker (Daniel Bevenius) #33599
  • [522fbbc8d9] - src: don't use semicolon outside function (Shelley Vohr) #33592
  • [ad970996cf] - src: remove unused using declarations (Daniel Bevenius) #33268
  • [20d54f6908] - src: use MaybeLocal.ToLocal instead of IsEmpty (Daniel Bevenius) #33554
  • [5438611984] - src: use NewFromUtf8Literal in GetLinkedBinding (Daniel Bevenius) #33552
  • [a5e860cd29] - src: use const in constant args.Length() (himself65) #33555
  • [7e351f15cb] - src: use MaybeLocal::FromMaybe to return exception (Daniel Bevenius) #33514
  • [3f1c756f89] - Revert "src: fix missing extra ca in tls.rootCertificates" (Eric Bickle) #33313
  • [d1e1dbf188] - src: remove BeforeExit callback list (Ben Noordhuis) #33386
  • [ee45b78b7f] - src: use MaybeLocal.ToLocal instead of IsEmpty (Daniel Bevenius) #33457
  • [9018e92b13] - src: remove unused headers in src/util.h (Juan José Arboleda) #33070
  • [7d1d00f97a] - src: use enum for refed flag on native immediates (Anna Henningsen) #33444
  • [e8cc269ee0] - src: use symbol to store AsyncWrap resource (Anna Henningsen) #31745
  • [ab2454dec5] - src: prefer make_unique (Michael Dawson) #33378
  • [a942f7280a] - src: remove unnecessary else in base_object-inl.h (Daniel Bevenius) #33413
  • [f6227c0577] - src: reduce duplication in RegisterHandleCleanups (Daniel Bevenius) #33421
  • [f24292e106] - src: remove unused IsolateSettings variable (Daniel Bevenius) #33417
  • [308be6ca0c] - src: remove unused misc variable (Daniel Bevenius) #33417
  • [7fd0519a91] - src: add promise_resolve to SetupHooks comment (Daniel Bevenius) #33365
  • [26a3cf058d] - src,build: add --openssl-default-cipher-list (Daniel Bevenius) #33708
  • [b0fa611e68] - stream: fix the spellings (antsmartian) #33635
  • [1db0d51ab2] - stream: forward writableObjectMode (Robert Nagy) #33390
  • [2c568c80f3] - test: add non-ASCII character embedding test (Anna Henningsen) #33972
  • [d4a2ae094e] - test: add test for Http2ServerResponse#[writableCorked,cork,uncork] (Pranshu Srivastava) #33956
  • [4a61013fb2] - test: print arguments passed to mustNotCall function (Denys Otrishko) #33951
  • [1b55d90975] - test: AsyncLocalStorage works with thenables (Gerhard Stoebich) #34008
  • [195980d667] - test: account for non-node basename (Shelley Vohr) #33952
  • [90223f0a88] - test: fix typo in common/index.js (gengjiawen) #33976
  • [d427d7f905] - test: add common/udppair utility (James M Snell) #33380
  • [b8fdde400a] - Revert "test: stop testing --interpreted-frames-native-stack for s390x" (Michaël Zasso) #33794
  • [e3a53329c2] - test: temporarily exclude test on arm (Michael Dawson) #33814
  • [b6e3616911] - test: fix invalid regular expressions in case test-trace-exit (legendecas) #33769
  • [c3ac47c03d] - test: changed function to arrow function (Sagar Jadhav) #33711
  • [15eb5a3da4] - test: uv_tty_init now returns EINVAL on IBM i (Xu Meng) #33629
  • [da5e970a8c] - test: make flaky test stricter (Robert Nagy) #33539
  • [47396a42cf] - test: fix flaky test-trace-atomics-wait (Anna Henningsen) #33428
  • [eb877a4c49] - test: mark test-dgram-multicast-ssmv6-multi-process flaky (AshCripps) #33498
  • [5dca04ee8e] - tools: remove superfluous regex in tools/doc/json.js (Rich Trott) #33998
  • [1791d5727c] - tools: update remark-preset-lint-node@1.15.1 to 1.16.0 (Rich Trott) #33852
  • [01d8b91942] - tools: prevent js2c from running if nothing changed (Daniel Bevenius) #33844
  • [e837f00b4f] - tools: remove unused vector include in mkdcodecache (Daniel Bevenius) #33828
  • [800dbb6bdd] - tools: update ESLint to 7.2.0 (Colin Ihrig) #33776
  • [a14e38a6c0] - tools: remove unused using declarations code_cache (Daniel Bevenius) #33697
  • [9fb1eb09d9] - tools: update remark-preset-lint-node from 1.15.0 to 1.15.1 (Rich Trott) #33727
  • [a331a00eac] - tools: fix check-imports.py to match on word boundaries (Richard Lau) #33268
  • [9325ed9e1c] - tools: update ESLint to 7.1.0 (Colin Ihrig) #33526
  • [6dab63f36d] - tools: add docserve target (Antoine du HAMEL) #33221
  • [2384044c95] - tools,gyp: add support for MSVC cross-compilation (Richard Townsend) #32867
  • [987c927225] - util: fix width detection for DEL without ICU (Ruben Bridgewater) #33650
  • [91d0d53b59] - util: support Combining Diacritical Marks for Symbols (Ruben Bridgewater) #33650
  • [e3d53f999d] - util: gracefully handle unknown colors (Ruben Bridgewater) #33797
  • [a90c9aa858] - util: fix inspection of class instance prototypes (Ruben Bridgewater) #33449
  • [2380d90f0a] - util: mark classes while inspecting them (Ruben Bridgewater) #32332
  • [879c9322ce] - vm: allow proxy callbacks to throw (Gus Caplan) #33808
  • [af14c1f776] - wasi: allow WASI stdio to be configured (Colin Ihrig) #33544
  • [5eecea375f] - wasi: simplify WASI memory management (Colin Ihrig) #33525
  • [f98e888fdd] - wasi: refactor and enable poll_oneoff() test (Colin Ihrig) #33521
  • [6b20e8442f] - wasi: relax WebAssembly.Instance type check (Ben Noordhuis) #33431
  • [d15383253a] - wasi,worker: handle termination exception (Ben Noordhuis) #33386
  • [3f971d89a9] - win,fs: use namespaced path in absolute symlinks (Bartosz Sosnowski) #33351
  • [3520a134af] - win,msi: add arm64 config for windows msi (Dennis Ameling) #33689
  • [b79495905f] - worker: fix variable referencing in template string (Harshitha KP) #33467
  • [9c3008005d] - worker: perform initial port.unref() before preload modules (Anna Henningsen) #33455
  • [64cae13799] - worker: use _writev in internal communication (Anna Henningsen) #33454
  • [7817b875a7] - worker: fix race condition in node_messaging.cc (Anna Henningsen) #33429

codebytere added a commit that referenced this pull request Jun 28, 2020
Notable changes:

build:
  * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) #33376
cli:
  * (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) #33587
crypto:
  * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) #33360
deps:
  * (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) #33376
  * (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) #33376
dgram:
  * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) #22413
events:
  * (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) #33556
fs:
  * (SEMVER-MINOR) implement lutimes (Maël Nison) #33399
http:
  * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) #33803
  * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) #33617
  * (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278
http2:
  * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994
  * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) #33160
process:
  * (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) #33475
src:
  * (SEMVER-MINOR) store key data in separate class (Tobias Nießen) #33360
  * (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) #33360
  * (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) #33360
  * (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) #33772
  * (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) #33772
  * (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) #33850
win:
  * (SEMVER-MINOR) allow skipping the supported platform check (João Reis) #33176
worker:
  * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) #33979
  * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772
worker,fs:
  * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) #33772
zlib:
  * (SEMVER-MINOR) add `maxOutputLength` option (unknown) #33516

PR-URL: #34093
@codebytere
Copy link
Member Author

cc @targos this was a little funky becuase #33376 got marked as semver-major per label - i changed them to semver-minor in the changelog but want to double-check that was the correct thing to do

@targos
Copy link
Member

targos commented Jun 28, 2020

@codebytere. That's correct, I just usually only mark the "update V8 to x.y" commit semver-minor. The other ones are patch.

I have a few suggestions for the changelog format. I made three commits that you can see here: v14.5.0-proposal...targos:suggest

codebytere added a commit that referenced this pull request Jun 28, 2020
Notable changes:

build:
  * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) #33376
cli:
  * (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) #33587
crypto:
  * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) #33360
deps:
  * (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) #33376
  * (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) #33376
dgram:
  * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) #22413
events:
  * (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) #33556
fs:
  * (SEMVER-MINOR) implement lutimes (Maël Nison) #33399
http:
  * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) #33803
  * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) #33617
  * (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278
http2:
  * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994
  * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) #33160
process:
  * (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) #33475
src:
  * (SEMVER-MINOR) store key data in separate class (Tobias Nießen) #33360
  * (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) #33360
  * (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) #33360
  * (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) #33772
  * (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) #33772
  * (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) #33850
win:
  * (SEMVER-MINOR) allow skipping the supported platform check (João Reis) #33176
worker:
  * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) #33979
  * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772
worker,fs:
  * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) #33772
zlib:
  * (SEMVER-MINOR) add `maxOutputLength` option (unknown) #33516

PR-URL: #34093
@codebytere codebytere marked this pull request as ready for review June 30, 2020 04:19
@codebytere
Copy link
Member Author

@nodejs/releasers this should be ready for review!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2020

@devsnek
Copy link
Member

devsnek commented Jun 30, 2020

What's the cutoff for this? It would be nice if b327d33 and 022dceb were kept together.

@codebytere
Copy link
Member Author

@devsnek it's tomorrow but i can try to get it in rn :)

codebytere added a commit that referenced this pull request Jun 30, 2020
Notable changes:

build:
  * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) #33376
cli:
  * (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) #33587
crypto:
  * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) #33360
deps:
  * (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) #33376
  * (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) #33376
dgram:
  * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) #22413
events:
  * (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) #33556
fs:
  * (SEMVER-MINOR) implement lutimes (Maël Nison) #33399
http:
  * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) #33803
  * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) #33617
  * (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278
http2:
  * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994
  * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) #33160
process:
  * (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) #33475
src:
  * (SEMVER-MINOR) store key data in separate class (Tobias Nießen) #33360
  * (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) #33360
  * (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) #33360
  * (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) #33772
  * (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) #33772
  * (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) #33850
stream*:
  * runtime deprecate Transform._transformState (Robert Nagy) #32763
win:
  * (SEMVER-MINOR) allow skipping the supported platform check (João Reis) #33176
worker:
  * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) #33979
  * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772
worker,fs:
  * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) #33772
zlib:
  * (SEMVER-MINOR) add `maxOutputLength` option (unknown) #33516

PR-URL: #34093
@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

codebytere commented Jun 30, 2020

CITGM failures seem normal when comparing to existing v14.x and taking out through2 failures surfaced by @BethGriggs already but i'd love someone to confirm before I release today!

Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release commit LGTM

@BethGriggs
Copy link
Member

Ref CITGM, i'm not sure but it looks like the coffeescript failures across multiple platforms are new in v14.5.0. I tried rerunning just coffeescript to see if it was just flaky but it seems to be repeatable. I haven't tried building/testing locally yet.

v14.5.0 - https://ci.nodejs.org/job/citgm-smoker/nodes=rhel7-s390x/2403/console
v14.4.0 - https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=rhel7-s390x/859/console

Apart from coffeescript and through2, the rest of the failures look like familiar flakes.

@codebytere
Copy link
Member Author

codebytere commented Jun 30, 2020

I ran npx citgm coffeescript@2.5.1 -d out/Release/node from my proposal branch and saw no issues:

info:    coffeescript npm:   | npm install successfully completed
info:    coffeescript npm:   | test suite started  
info:    passing module(s)   |                     
info:    module name:        | coffeescript        
info:    version:            | 2.5.1               
info:    done                | The smoke test has passed.
info:    duration            | test duration: 26439ms

so i think flake...? unless i ran it wrong or something

@BethGriggs
Copy link
Member

BethGriggs commented Jun 30, 2020

🤔 I can reproduce the failure locally on macOS. But, I tested it a bit differently by cloning down the repository. The tests appear to hang on v14.5.0.

➜  coffeescript git:(master) node --version      
v14.4.0
➜  coffeescript git:(master) node ./bin/cake test                   
passed 1456 tests in 6.02 seconds 
➜  coffeescript git:(master) ~/node/out/Release/node --version      
v14.5.0
➜  coffeescript git:(master) ~/node/out/Release/node ./bin/cake test
[Hangs until interrupt]

Not sure if it is relevant, but when enabling NODE_DEBUG it shows it hanging at:

MODULE 79548: Module._load REQUEST module parent: /Users/bethgriggs/coffeescript/lib/coffeescript/index.js
MODULE 79548: load native module module
MODULE 79548: Module._load REQUEST @babel/core parent: /Users/bethgriggs/coffeescript/lib/coffeescript/index.js
MODULE 79548: Module._load REQUEST /Users/bethgriggs/coffeescript/node_modules/@babel/preset-env/lib/index.js parent: /Users/bethgriggs/coffeescript/node_modules/@babel/core/lib/config/files/plugins.js
MODULE 79548: Module._load REQUEST ./test/importing/transpile_import parent: .
MODULE 79548: RELATIVE: requested: ./test/importing/transpile_import from parent.id .
MODULE 79548: looking for ["."]

@codebytere
Copy link
Member Author

This looks suspicious: #33501

@devsnek
Copy link
Member

devsnek commented Jun 30, 2020

cc @GeoffreyBooth

@codebytere
Copy link
Member Author

codebytere commented Jun 30, 2020

Got it: 78c5c4c208 did it. I can back it out.

Derek Lewis and others added 2 commits June 30, 2020 09:33
Prior to this commit, all <pre> tags were being
highlighted as JavaScript. This has been corrected
to syntax highlight all languages appearing in the
API reference docs. This was accomplished by using
highlight.js instead of SHJS for the frontend lib.

* remove SHJS JavaScript code
* add highlight.js bundle
* fix script tags to reflect replacement
* migrate CSS to use highlight.js classes
* add appropriate documentation
* ensure api_assets README.md stays interal

Fixes: #33363

PR-URL: #33442
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
PR-URL: #33497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@GeoffreyBooth
Copy link
Member

Running CITGM takes a long time and lots of resources, which is why I think we’re not running it on all PRs?

I assume we're not charged for the GitHub Actions runs? Maybe we could add an action to run it there? (Or even multiple actions if we can split up the tests to run in parallel, like action 1 is packages A-F, etc.)

@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

codebytere commented Jun 30, 2020

@nodejs/build it looks like the macOS 10.15 tar release job failed?
https://ci-release.nodejs.org/job/iojs+release/6144/nodes=osx1015-release-tar/console

Everything looks ok otherwise: https://ci-release.nodejs.org/job/iojs+release/6144/

Rerun for tar job here: https://ci-release.nodejs.org/job/iojs+release/6145/ also failed, perhaps an infra problem? I think we're held up until we sort this unfortunately 😅

@AshCripps
Copy link
Member

@codebytere nodejs/build#2369 struck again ill take the node offline and investigate tomorrow.

@codebytere
Copy link
Member Author

codebytere commented Jun 30, 2020

@AshCripps so earliest tomorrow then? i'll update the dates on this then, ty!

@BethGriggs
Copy link
Member

BethGriggs commented Jun 30, 2020

@codebytere I think we have two machines that can run that job, it'll just take a little longer for it to complete. Rerunning now should send it to the other machine 🤞

@AshCripps
Copy link
Member

Yes we have two mac release machines so you should be able to carry on with the release

@codebytere
Copy link
Member Author

@codebytere codebytere merged commit abb5e1a into v14.x Jun 30, 2020
codebytere added a commit that referenced this pull request Jun 30, 2020
codebytere added a commit that referenced this pull request Jun 30, 2020
Notable changes:

build:
  * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) #33376
cli:
  * (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) #33587
crypto:
  * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) #33360
deps:
  * (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) #33376
  * (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) #33376
dgram:
  * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) #22413
events:
  * (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) #33556
fs:
  * (SEMVER-MINOR) implement lutimes (Maël Nison) #33399
http:
  * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) #33803
  * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) #33617
  * (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) #32789
  * (SEMVER-MINOR) added scheduling option to http agent (delvedor) #33278
http2:
  * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994
  * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) #33160
process:
  * (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) #33475
src:
  * (SEMVER-MINOR) store key data in separate class (Tobias Nießen) #33360
  * (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) #33360
  * (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) #33360
  * (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) #33772
  * (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) #33772
  * (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) #33850
stream*:
  * runtime deprecate Transform._transformState (Robert Nagy) #32763
win:
  * (SEMVER-MINOR) allow skipping the supported platform check (João Reis) #33176
worker:
  * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) #33979
  * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772
  * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772
worker,fs:
  * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) #33772
zlib:
  * (SEMVER-MINOR) add `maxOutputLength` option (unknown) #33516

PR-URL: #34093
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Jun 30, 2020
@codebytere codebytere deleted the v14.5.0-proposal branch June 30, 2020 22:39
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Jun 30, 2020
@codebytere
Copy link
Member Author

@nodejs/build anyone know how to force a website deploy? latest blog post isn't live still

@rvagg
Copy link
Member

rvagg commented Jul 1, 2020

looking at it now .. @BethGriggs said there was a problem with the 12.x release too

yorkie added a commit to alibaba/pipcook that referenced this pull request Jul 15, 2020
See nodejs/node#33501
At Node.js 14.5.0, it removes the dynamic module format, so we need to
make compatible works for the new usage with esm loader.

Node.js Release PR: nodejs/node#34093
yorkie added a commit to alibaba/pipcook that referenced this pull request Jul 15, 2020
See nodejs/node#33501
At Node.js 14.5.0, it removes the dynamic module format, so we need to
make compatible works for the new usage with esm loader.

Node.js Release PR: nodejs/node#34093
@MylesBorins MylesBorins mentioned this pull request Jul 16, 2020
gindis pushed a commit to gindis/pipcook that referenced this pull request Sep 11, 2020
See nodejs/node#33501
At Node.js 14.5.0, it removes the dynamic module format, so we need to
make compatible works for the new usage with esm loader.

Node.js Release PR: nodejs/node#34093
@targos targos mentioned this pull request Sep 22, 2020
4 tasks
@targos targos added release Issues and PRs related to Node.js releases. v14.x labels Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.