Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: AsyncLocalStorage works with thenables #34008

Closed
wants to merge 1 commit into from
Closed

test: AsyncLocalStorage works with thenables #34008

wants to merge 1 commit into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jun 22, 2020

This adds a test to verify that AsyncLocalStorage works with thenables which works since the v8 fix done in #33778.

The test is based on the samples done by @Qard in https://gist.github.com/Qard/faad53ba2368db54c95828365751d7bc

Refs: #33778

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Flarna
test: AsyncLocalStorage works with thenables
1f5d05a 
This adds a test to verify that AsyncLocalStorage works with thenables.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jun 22, 2020
Qard
Qard approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, @Flarna!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32035/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32037/

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 22, 2020
This was referenced Jun 23, 2020
Open
Open
Flarna added a commit that referenced this pull request Jun 24, 2020
@Flarna
test: AsyncLocalStorage works with thenables
a2b1b92 
This adds a test to verify that AsyncLocalStorage works with thenables.

PR-URL: #34008
Refs: #33778
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Flarna
Copy link
Member Author

Flarna commented Jun 24, 2020

Landed in a2b1b92

@Flarna Flarna closed this Jun 24, 2020
@Flarna Flarna deleted the test-thenable branch June 24, 2020 13:46
This was referenced Jun 25, 2020
Open
Open
Open
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@Flarna @codebytere
test: AsyncLocalStorage works with thenables
1b55d90 
This adds a test to verify that AsyncLocalStorage works with thenables.

PR-URL: #34008
Refs: #33778
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 28, 2020
Open
15 tasks
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@Flarna @codebytere
test: AsyncLocalStorage works with thenables
205bddb 
This adds a test to verify that AsyncLocalStorage works with thenables.

PR-URL: #34008
Refs: #33778
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Flarna Flarna mentioned this pull request Jul 14, 2020
Merged
@Flarna Flarna mentioned this pull request Aug 14, 2020
Closed
Flarna added a commit to dynatrace-oss-contrib/node that referenced this pull request Sep 23, 2020
@Flarna
test: AsyncLocalStorage works with thenables
227a637 
This adds a test to verify that AsyncLocalStorage works with thenables.

PR-URL: nodejs#34008
Refs: nodejs#33778
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 23, 2020
@Flarna @addaleax
test: AsyncLocalStorage works with thenables
232f6e1 
This adds a test to verify that AsyncLocalStorage works with thenables.

Backport-PR-URL: #34776
PR-URL: #34008
Refs: #33778
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP left review comments

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Flarna @nodejs-github-bot @Qard @jasnell @targos @HarshithaKP @addaleax