Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo and style fix #33976

Closed
wants to merge 3 commits into from
Closed

typo and style fix #33976

wants to merge 3 commits into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. labels Jun 19, 2020
@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 19, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32012/

gengjiawen added a commit that referenced this pull request Jun 22, 2020
@gengjiawen
src: improve indention for upd_wrap.cc
25413b0 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gengjiawen added a commit that referenced this pull request Jun 22, 2020
@gengjiawen
test: fix typo in common/index.js
74cd70e 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gengjiawen added a commit that referenced this pull request Jun 22, 2020
@gengjiawen
test: fix typo in test-quic-client-empty-preferred-address.js
326a79e 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gengjiawen
Copy link
Member Author

Landed in 09330fc...326a79e

@gengjiawen gengjiawen closed this Jun 22, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@gengjiawen @codebytere
src: improve indention for upd_wrap.cc
cd0ae40 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@gengjiawen @codebytere
test: fix typo in common/index.js
90223f0 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@gengjiawen @codebytere
src: improve indention for upd_wrap.cc
7381853 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@gengjiawen @codebytere
test: fix typo in common/index.js
fa8636c 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@gengjiawen @codebytere
src: improve indention for upd_wrap.cc
cd5af16 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@gengjiawen @codebytere
test: fix typo in common/index.js
9521c70 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@gengjiawen @codebytere
src: improve indention for upd_wrap.cc
6d5383d 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@gengjiawen @codebytere
test: fix typo in common/index.js
b9f8034 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@gengjiawen @codebytere
src: improve indention for upd_wrap.cc
37692b5 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@gengjiawen @codebytere
test: fix typo in common/index.js
eb4b1d6 
PR-URL: #33976
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@trivikr trivikr trivikr approved these changes

@devnexen devnexen devnexen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @nodejs-github-bot @jasnell @devnexen @trivikr @MrHeer @codebytere