Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: label v4.2.0 as LTS in changelog heading #3343

Closed
wants to merge 1 commit into from
Closed

doc: label v4.2.0 as LTS in changelog heading #3343

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 13, 2015

R=@jasnell

I'm proposing that we use (Stable), (LTS) and (Maintenance) in the headings of the CHANGELOG.

Pre v4 these labels were: (Stable) (even minor), (Unstable) (odd minor), (Maintenance) (previous even minor). grep ^##\ CHANGELOG.md to see the usage trend.

If agreed, this change needs to go on master, v4 and also on the release blog post on the website.

@jasnell
Copy link
Member

jasnell commented Oct 13, 2015

+1.

I just noticed that the date in the 4.2.0 header is wrong. It shows the
date I originally started working on the release proposal rather than the
date it was released.
On Oct 12, 2015 11:59 PM, "Rod Vagg" notifications@github.com wrote:

R=@jasnell https://github.com/jasnell

I'm proposing that we use (Stable), (LTS) and (Maintenance) in the
headings of the CHANGELOG.

Pre v4 these labels were: (Stable) (even minor), (Untable) (odd minor),
(Maintenance) (previous even minor). grep ^##\ CHANGELOG.md to see the
usage trend.

If agreed, this change needs to go on master, v4 and also on the release

blog post on the website.

You can view, comment on, or merge this pull request online at:

#3343
Commit Summary

  • doc: label v4.2.0 as LTS in changelog heading

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#3343.

@cjihrig
Copy link
Contributor

cjihrig commented Oct 13, 2015

LGTM

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Oct 13, 2015
@jasnell
Copy link
Member

jasnell commented Oct 13, 2015

LGTM

rvagg added a commit that referenced this pull request Oct 13, 2015
@rvagg @jasnell
doc: label v4.2.0 as LTS in changelog heading
4bc9d97 
Update the label for v4.2.0 to (LTS) from (Stable)

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3343
@jasnell
Copy link
Member

jasnell commented Oct 13, 2015

Landed in 4bc9d97

rvagg added a commit that referenced this pull request Oct 13, 2015
@rvagg @jasnell
doc: label v4.2.0 as LTS in changelog heading
102cb72 
Update the label for v4.2.0 to (LTS) from (Stable)

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3343
@jasnell
Copy link
Member

jasnell commented Oct 13, 2015

Landed in v4.x in 102cb72

@jasnell jasnell closed this Oct 13, 2015
This was referenced Oct 14, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rvagg @jasnell @cjihrig @mscdex @MylesBorins