doc: label v4.2.1 as LTS in changelog heading #3360
Conversation
|
LGTM |
|
Strange. I could have sworn I'd already done that. Ah well, thanks @phillipj ! LGTM |
PR-URL: #3360 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Thanks, landed in dae9fae. |
|
Are you planning to land it in v4.x also, as done with v4.2.0 / 102cb72 @silverwind? |
PR-URL: #3360 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Done in b884899. (Hope I did that right, had to modify the patch slightly so it applied) |
|
Found the cause: CHANGELOG.md on master has an empty line above the title, introduced in e4f2952. cc: @Fishrock123 |
|
In this case, I already did the v4.x backport on request: b884899. Is it generally prefered that the commiter does the backporting him/herself or should we leave it to @nodejs/release handle it? |
|
for now leave it to the @nodejs/release but that'll likely change over time as it becomes increasingly difficult, we'll have to come up with a better strategy when we end up doing lots of conflict resolution |
|
@silverwind Oops. If it's causing issues let's remove that empty line. |
|
@Fishrock123 can you put up a PR targeting master to sync the changelogs and remove that line? |
|
@silverwind Sure, do you know off-hand what isn't in sync anymore? |
Just as with #3343, v4.2.1 should probably also be marked as
LTSrather thanStable.Also what @jasnell decided when creating release blog post on new.nodejs.org/59411.
Needs to land on
masterandv4.xif it looks good