Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: introduce a triager role #34295

Closed
wants to merge 0 commits into from
Closed

doc: introduce a triager role #34295

wants to merge 0 commits into from

Conversation

gireeshpunathil
Copy link
Member

The role helps triaging issue backlogs effectively.

Fixes: #34054
Refs: nodejs/TSC#891

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 10, 2020
@Trott
Copy link
Member

Trott commented Jul 10, 2020

Optional idea, but maybe specify that someone should participate (leave comments on issues, for example) in the repository for a while before applying? I imagine we're unlikely to give the role to people we haven't seen interact in the repository. These are going to be people that will be the first to interact with new folks posting issues and PRs. We'll want to see some evidence that they understand Node.js and our process, but also that they interact with kindness and patience.

@gireeshpunathil
Copy link
Member Author

@Trott - thanks, added a phrase to that effect, PTAL!

@gireeshpunathil gireeshpunathil mentioned this pull request Jul 17, 2020
Merged
Trott
Trott approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a bunch of style suggestions, but none of them are blocking/required.

@gireeshpunathil
Copy link
Member Author

@Trott - thanks, accommodated all those style suggestions.
(I realize some of those are basic grammar stuff, which I am weak at, and need to improve!)

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2020
@Trott
Copy link
Member

Trott commented Jul 18, 2020

Do we want to update GOVERNANCE.md to mention the triager role? (It doesn't have to happen in this PR, and can even be decided at a later date.)

gireeshpunathil added a commit that referenced this pull request Jul 19, 2020
@gireeshpunathil
doc: introduce a triager role
193dfa9 
The role helps triaging issue backlogs effectively
Fixes: #34054
Refs: nodejs/TSC#891

PR-URL: #34295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member Author

landed in 193dfa9

@gireeshpunathil gireeshpunathil mentioned this pull request Jul 19, 2020
Closed
4 tasks
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@gireeshpunathil @cjihrig
doc: introduce a triager role
3a37f31 
The role helps triaging issue backlogs effectively
Fixes: #34054
Refs: nodejs/TSC#891

PR-URL: #34295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gireeshpunathil added a commit that referenced this pull request Jul 24, 2020
@gireeshpunathil
doc: mention triage in GOVERNANCE.md
adcf12c 
Refs: #34295 (comment)
PR-URL: #34426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@gireeshpunathil @MylesBorins
doc: introduce a triager role
10962c8 
The role helps triaging issue backlogs effectively
Fixes: #34054
Refs: nodejs/TSC#891

PR-URL: #34295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@gireeshpunathil @MylesBorins
doc: mention triage in GOVERNANCE.md
bbc7eea 
Refs: #34295 (comment)
PR-URL: #34426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
@richardlau richardlau mentioned this pull request Sep 11, 2020
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@gireeshpunathil @addaleax
doc: introduce a triager role
eac79ca 
The role helps triaging issue backlogs effectively
Fixes: #34054
Refs: nodejs/TSC#891

PR-URL: #34295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@gireeshpunathil @addaleax
doc: mention triage in GOVERNANCE.md
4bed175 
Refs: #34295 (comment)
PR-URL: #34426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@gireeshpunathil @addaleax
doc: introduce a triager role
0f050d4 
The role helps triaging issue backlogs effectively
Fixes: #34054
Refs: nodejs/TSC#891

PR-URL: #34295
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@gireeshpunathil @addaleax
doc: mention triage in GOVERNANCE.md
b37b3f0 
Refs: #34295 (comment)
PR-URL: #34426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: create a triage team to manage the backlog
6 participants
@gireeshpunathil @Trott @jasnell @targos @trivikr @nodejs-github-bot