Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add PoojaDurgad as a triager #35153

Closed
wants to merge 2 commits into from
Closed

Conversation

PoojaDurgad
Copy link
Contributor

I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 11, 2020
@benjamingr
Copy link
Member

Hey welcome 👋

This isn't actually our process and there is no official "triager" role.

Thanks a ton for wanting to help with this! It's appreciated.

I think a good step to help triage would be to go to the issues and try to confirm bug reports people have opened, help isolate issues and then (if you're up for it) building Node.js from source and stepping through the debugger while reproducing these issues.

There are many other ways to help with triage, everyone is allowed to do this.

If you are stuck or unsure what to do - feel free to reach out to me (my email is in the README) or other people from the project.

@richardlau
Copy link
Member

This isn't actually our process and there is no official "triager" role.

There is, it came out of the collab summit earlier this year. See

@benjamingr
Copy link
Member

huh, good to know.

Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. :)

@Trott
Copy link
Member

Trott commented Sep 13, 2020

Trying to figure out what needs to happen next.

I imagine this is blocked until we do something like create an issue-triage team (so that it isn't confused with the existing security-triage team) and add it to the node and help repos with triage permissions.

If there has already been agreement about that being the way forward, then great.

If not, then I guess this is blocked until we open an issue in the admin repo and then subsequently create the group?

Pinging people invested in triage and/or who have been involved in GitHub permissions/teams lately: @gireeshpunathil @MylesBorins @mmarchini

@gireeshpunathil
Copy link
Member

thanks @Trott , tbh, I did not think about it when proposed the triage process. my idea was that an approved triager can be added to the org, with triage level permissions. won't that work here?

@Trott
Copy link
Member

Trott commented Sep 13, 2020

thanks @Trott , tbh, I did not think about it when proposed the triage process. my idea was that an approved triager can be added to the org, with triage level permissions. won't that work here?

It looks to me like there is no org-level triage role. It is only on a per-repository basis. So I think the thing to do is create a single team, and then add that team as a triager to relevant repositories.

gireeshpunathil pushed a commit that referenced this pull request Oct 12, 2020
I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.

PR-URL: #35153
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@gireeshpunathil
Copy link
Member

landed in 18ff3c8

@gireeshpunathil
Copy link
Member

invitation sent to Pooja to join @nodejs/issue-triage team

MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.

PR-URL: #35153
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.

PR-URL: #35153
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.

PR-URL: #35153
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
I would like to apply for a triager in this project.
My motivation to become a triager is to help with the issues
in this repo and the help repo, as well as learn deeper
internals of node.js, and to eventually become a collaborator!
I hear by declare that I read and understood the project’s
Code of Conduct, and will adhere to that.

PR-URL: nodejs#35153
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants