v14.14.0 proposal #35648
Merged
v14.14.0 proposal #35648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #35397 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
PR-URL: #35397 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
PR-URL: #35397 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
PR-URL: #35397 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
PR-URL: #35529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Enforce `//` for multiline comments. Some tests mixed and matched, and at least one did so in a (to me) surprising way. PR-URL: #35485 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Use `//` for multline comments. PR-URL: #35485 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Do not crash trying to access prepareStackTrace on `undefined`. PR-URL: #35499 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: #35499 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: #35499 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: #35499 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: #35499 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
PR-URL: #35542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #35359 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #35512 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
ares_expand_name doesn't guarantee that pointer variable is initialized if return code is ARES_EBADNAME or ARES_ENOMEM. But current usage of the function in the codebase thinks otherwise. There seems to be an assumption that pointer is always initialized even though it is a local variable and we create a unique pointer soon after calling ares_expand_name. This could potentially crash the program with an invalid free pointer. I was able to crash it by poisoning the memory and some manual hooks. By moving the unique_ptr after checking the return code we can fix the problem. As the underlying function guarantees that pointer is initialized when the status is ARES_SUCCESS. PR-URL: #35502 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* better vertical alignment with text * slightly larger "key" size * remove top light area (from box-shadow) PR-URL: #35497 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #35523 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This PR introduces a new method fs.rm that provides the behaviour of rimraf when used with the recursive: true and force: true options. PR-URL: #35494 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
- change http client path assignment from to (it's more appropriate in this case). - since the inner condition is the only referencing the variable, moved the assignment to the inner condition. PR-URL: #35508 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
PR-URL: #35528 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #35455 Reviewed-By: Rich Trott <rtrott@gmail.com>
Change the one instance of the Class Property heading in our docs to Class property to match style with other headers. PR-URL: #35540 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Without this, the session is destroyed with the following error
```
Error [ERR_HTTP2_ERROR]: Protocol error
at Http2Session.onSessionInternalError (internal/http2/core.js:756:26)
Emitted 'error' event on ClientHttp2Session instance at:
at emitClose (internal/http2/core.js:1010:10)
at internal/http2/core.js:1048:7
at finish (internal/streams/writable.js:731:5)
at processTicksAndRejections (internal/process/task_queues.js:80:21) {
code: 'ERR_HTTP2_ERROR',
errno: -505
}
```
The test then calls `session.close()` which tries to write to a
destroyed socket. As a result, an unhandled `ECONNRESET` error is
emitted in the v12 release line.
PR-URL: #35482
Refs: #34859
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #35206 Refs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
- refactor the n-api matrix and add v7 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #35345 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #35226 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
added
build
4 tasks
includes: * stream: simpler and faster Readable async iterator * stream: don't destroy on async iterator success * stream: async iterator stop read if destroyed PR-URL: #34887 Refs: #34035 Refs: #35122 Refs: #35640 Refs: #34680 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
force-pushed
the
v14.14.0-proposal
branch
from
6112962
to
0ea4bd2
Compare
This comment has been minimized.
This comment has been minimized.
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) #35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) #35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: #35648
MylesBorins
force-pushed
the
v14.14.0-proposal
branch
from
0ea4bd2
to
354b6a9
Compare
MylesBorins
added a commit
that referenced
this pull request
Oct 16, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) #35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) #35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: #35648
This one shouldn't be included. This is in master only |
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 16, 2020
|
@jasnell at least marking something flaky has no effect on runtime 😅. We can open a PR to revert |
targos
added
release
ryanhc
pushed a commit
to Samsung/lwnode
that referenced
this pull request
Jun 29, 2022
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) nodejs/node#35546 doc: * add aduh95 to collaborators (Antoine du Hamel) nodejs/node#35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) nodejs/node#35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) nodejs/node#35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) nodejs/node#35512 PR-URL: nodejs/node#35648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-10-15, Version 14.14.0 (Current), @MylesBorins
Notable Changes
7e7afc5186] - crypto: update certdata to NSS 3.56 (Shelley Vohr) #355468877430530] - doc: add aduh95 to collaborators (Antoine du Hamel) #355421610728d7c] - (SEMVER-MINOR) fs: add rm method (Ian Sutherland) #354946ff152cc67] - (SEMVER-MINOR) http: allow passing array of key/val into writeHead (Robert Nagy) #3527493f947af0a] - (SEMVER-MINOR) src: expose v8::Isolate setup callbacks (Shelley Vohr) #35512Commits
16c17ddd88] - build: fix Commit Queue failure comment (Antoine du Hamel) #35599b7305284e2] - build: gitHub actions: Python 3.9 and actions/setup-python@v2 (Christian Clauss) #35521e8fcbc8318] - build: fix landed message for multiple commits in commit-queue (Denys Otrishko) #3522684c0adefa0] - build: add Commit Queue actions url to failure comment (Denys Otrishko) #352069c74d4598d] - build: fuzzer that targets node::LoadEnvironment() (davkor) #34844f552e5c251] - build: improved release lint error message (Shelley Vohr) #355237e7afc5186] - crypto: update certdata to NSS 3.56 (Shelley Vohr) #35546b8529a7104] - deps: V8: cherry-pick 3176bfd447a9 (Anna Henningsen) #356120c877762ea] - doc: document Buffer.concat may use internal pool (Andrey Pechkurov) #355416284f0dbc2] - doc: use test username instead of real (Pooja D.P) #3561178259b6519] - doc: add doc for starting ci job via label (Juan José Arboleda) #3555141d7500bf9] - doc: fix unit of size argument of readable.read (Tobias Nießen) #3505100eff4a534] - doc: add missing deprecation number (Benjamin Coe) #356309288f9d74b] - doc: harmonize YAML comments (Antoine du Hamel) #3557516f8298170] - doc: revise description of process.ppid (Pooja D.P) #35589cad86d40de] - doc: add symlink information for process.execpath (Pooja D.P) #355904025fc811d] - doc: add PoojaDurgad as a triager (Pooja D.P) #35153809cd07968] - doc: document rmdir/recursive deprecation (Benjamin Coe) #355799d1b7ac334] - doc: edit fs.md for minor style changes (Rich Trott) #35505c1bb364105] - doc: run license builder (Myles Borins) #35577970975b588] - doc: use kbd element in process doc (Rich Trott) #3558464ebbddb5f] - doc: fixup perf_hooks (Antoine du Hamel) #35527b074717af7] - doc: remove incorrect synchronous label (Colin Ihrig) #35561ddf13e0df0] - doc: make fs.rm()'s force docs consistent (Colin Ihrig) #355614164477b43] - doc: simplify wording in tracing APIs doc (Pooja D.P) #35556c865b02397] - doc: improve SIGINT error text (Rich Trott) #355587d1cdd411f] - doc: move package.import content higher (Myles Borins) #3553562755b6230] - doc: harmonize changes list ordering (Antoine du Hamel) #354548cacca0f62] - doc: changes description must end with a period (Antoine du Hamel) #3545428c94ca123] - doc: harmonize version list style in YAML comments (Antoine du Hamel) #35454b3f15b7d89] - doc: fix missing PR-URLs in YAML comments (Antoine du Hamel) #3545402bf73e239] - doc: remove outstanding YAML comment (Antoine du Hamel) #35454a5552468d2] - doc: harmonize YAML comments style in deprecations.md (Antoine du Hamel) #35454863ba4b7da] - doc: refactor the n-api matrix (Michael Dawson) #3534585dc84d1bb] - doc: use sentence case for class property (Rich Trott) #3554001c9c59c85] - doc: add history entry for exports patterns (Antoine du Hamel) #3541051b988ba0f] - doc: fix deprecation history (Antoine du Hamel) #35455328c624cdf] - doc: fix util.inspect change history (Antoine du Hamel) #35528d53cfcd9e7] - doc: improve kbd element rendering (Rich Trott) #354978877430530] - doc: add aduh95 to collaborators (Antoine du Hamel) #355428cdc59b34c] - doc: fix YAML syntax errors (Antoine du Hamel) #355293c90b1a278] - errors: support possible deletion of globalThis.Error (Michaël Zasso) #35499a3c7f8e576] - fs: rimraf should not recurse on failure (Benjamin Coe) #35566939f8e8bfa] - fs: throw rm() validation errors (Colin Ihrig) #356023a401b8695] - fs: update rm/rmdir validation messages (Colin Ihrig) #35565937fa5d292] - fs: use validateBoolean() in rm/rmdir validation (Colin Ihrig) #355651ad9aca194] - fs: remove extraneous assignments in rmdir() (Colin Ihrig) #355671fadcf2163] - fs: simplify validateRmOptions() error handling (Colin Ihrig) #355678e3b11adb3] - fs: use errno constant with ERR_FS_EISDIR (Colin Ihrig) #355631610728d7c] - (SEMVER-MINOR) fs: add rm method (Ian Sutherland) #354946ff152cc67] - (SEMVER-MINOR) http: allow passing array of key/val into writeHead (Robert Nagy) #352742f1319967c] - http: make response.setTimeout() work (Ben Noordhuis) #3491359a2cb5ebb] - inspector: do not hardcode Debugger.CallFrameId in tests (Dmitry Gozman) #35570cd0b1365ae] - lib: fix readFile flag option typo (Daniil Demidovich) #3529270927560f6] - lib: change http client path assignment (Yohanan Baruchel) #35508fa171dbb7f] - lib: use remaining typed arrays from primordials (Michaël Zasso) #354997e8fdd399f] - lib: use Number.parseFloat from primordials (Michaël Zasso) #354995d727f0308] - lib: use Number.parseInt from primordials (Michaël Zasso) #3549977f1e1ea57] - lib: use global Error constructors from primordials (Michaël Zasso) #3549930c6b3e809] - lib: replace String global with primordials (Sebastien Ahkrin) #35397ebf3900795] - lib: replace Int8Array global with primordials (Sebastien Ahkrin) #35397d6ba4ecc4d] - lib: replace Int32Array global with primordials (Sebastien Ahkrin) #35397f544f7a102] - lib: replace Float64Array global with primordials (Sebastien Ahkrin) #35397b82fc409ca] - module: cjs-module-lexer@0.4.1 big endian fix (Guy Bedford) #35634cb2f6ffd3e] - module: use Wasm CJS lexer when available (Guy Bedford) #35583c995242068] - n-api: support for object freeze/seal (Shelley Vohr) #353594d1d3f454d] - src: reduced substring calls (Yash Ladha) #348085946b1ee23] - (SEMVER-MINOR) src: move node_contextify to modern THROW_ERR_* (James M Snell) #35470541082ccd9] - (SEMVER-MINOR) src: move node_process to modern THROW_ERR* (James M Snell) #354722e67d650bb] - src: fix freeing unintialized pointer bug in ParseSoaReply (Aastha Gupta) #3550293f947af0a] - (SEMVER-MINOR) src: expose v8::Isolate setup callbacks (Shelley Vohr) #35512775af7af4f] - test: add regression test for v8.getHeapSnapshot() crash (Anna Henningsen) #356123d21792f86] - test: mark test-webcrypto-encrypt-decrypt-aes flaky (James M Snell) #355874a2ba4384b] - test: do not use the same EventEmitter instance (Luigi Pinca) #35560768529736a] - test: add ALPNProtocols option to clientOptions (Luigi Pinca) #354823a77d1e208] - test: adjust comments for upcoming lint rule (Rich Trott) #354852992d0b82c] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #35569a19b320a31] - tools: bump cpplint.py to 1.4.6 (Rich Trott) #35569bd344108eb] - Revert "tools: add missing uv_setup_argv() calls" (Beth Griggs) #35641e8434d88fe] - tools,test: enable multiline-comment-style rule in tests (Rich Trott) #35485