Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixup perf_hooks #35527

Closed
wants to merge 1 commit into from
Closed

doc: fixup perf_hooks #35527

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 6, 2020

v12.19.0 seems to have make some unintended changes to that file, this is my attempt to fix it.

cc @codebytere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Oct 6, 2020
codebytere
codebytere approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@aduh95 aduh95 force-pushed the fixup-perf_hooks-doc branch from b703357 to 321b205 Compare October 7, 2020 07:53
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2020
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2020 •
edited by aduh95
Loading

Landed in 900f28a

@github-actions github-actions bot closed this Oct 11, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 11, 2020
@aduh95 @nodejs-github-bot
doc: fixup perf_hooks
900f28a 
PR-URL: #35527
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 11, 2020
Closed
4 tasks
@aduh95 aduh95 deleted the fixup-perf_hooks-doc branch October 11, 2020 13:55
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@aduh95 @MylesBorins
doc: fixup perf_hooks
64ebbdd 
PR-URL: #35527
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
doc: fixup perf_hooks
ea46015 
PR-URL: nodejs#35527
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @codebytere @trivikr @nodejs-github-bot