Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix readFile flag option #35292

Closed
wants to merge 3 commits into from
Closed

lib: fix readFile flag option #35292

wants to merge 3 commits into from

Conversation

O4epegb
Copy link

@O4epegb O4epegb commented Sep 22, 2020 •
edited
Loading

Fixes #35290

I have not added new tests since I'm not quite understand yet how to do that, but maybe it is worth to do, I'll try later.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Sep 22, 2020
@BridgeAR
Copy link
Member

The change itself looks good to me, thanks! Would you also be so kind and add a test case? :-) There are likely a couple that could be extended (check ./test/parallel/test-fs-*.js files)

@O4epegb
Copy link
Author

O4epegb commented Sep 23, 2020 •
edited
Loading

Just added some tests, made a new file, hope it's fine

@Trott
Copy link
Member

Trott commented Sep 24, 2020

@nodejs/fs

@Trott
Copy link
Member

Trott commented Sep 26, 2020

@nodejs/collaborators This could use reviews.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
puzpuzpuz
puzpuzpuz approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Left some nits for the test.

test/parallel/test-fs-readfile-flags.js Show resolved Hide resolved
test/parallel/test-fs-readfile-flags.js Show resolved Hide resolved
test/parallel/test-fs-readfile-flags.js Show resolved Hide resolved
@puzpuzpuz
Copy link
Member

It's also better to use fs as the commit message prefix, so it becomes fs: fix readFile flag option typo

mcollina
mcollina approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@O4epegb
Copy link
Author

O4epegb commented Oct 12, 2020

Do I need to do anything else here? :)

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 12, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@O4epegb
Copy link
Author

O4epegb commented Oct 12, 2020

No sure why Jenkins has git conflicts, I don't see them locally and github also not reporting anything

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@richardlau richardlau removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@richardlau
Copy link
Member

CI is failing as 0e37fb3 is a merge commit. If you can, please rebase this PR.

@O4epegb @Trott
Update test/parallel/test-fs-readfile-flags.js
c1a52d3 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Flarna
Copy link
Member

Flarna commented Oct 13, 2020

failed tests are unrelated and addressed by #35622

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33576/

Flarna pushed a commit that referenced this pull request Oct 13, 2020
@Flarna
lib: fix readFile flag option typo
ce4ac15 
PR-URL: #35292
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@Flarna
Copy link
Member

Flarna commented Oct 13, 2020

Landed in ce4ac15

@Flarna Flarna closed this Oct 13, 2020
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@MylesBorins
lib: fix readFile flag option typo
cd0b136 
PR-URL: #35292
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
@O4epegb O4epegb mentioned this pull request Oct 19, 2020
Closed
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@joesepi
lib: fix readFile flag option typo
02a72ba 
PR-URL: nodejs#35292
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

@Flarna Flarna Flarna approved these changes

@himself65 himself65 himself65 approved these changes

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.readFile does not account file system flag 'a+' in Node 14.11