doc: add missing deprecation number #35630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
deprecations
|
I would like to fast track this change, to unblock #35562 👍 👎 |
4 tasks
richardlau
approved these changes
Oct 13, 2020
bcoe
added
the
author ready
|
@BethGriggs we should make sure we land this in the LTS release too, I believe we're okay to back port the documentation only deprecation? |
aduh95
approved these changes
Oct 13, 2020
bcoe
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in efe60a5...2cfdf28 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2020
PR-URL: #35630 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35630 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35630 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assumed that
DEP0XXXwould be replaced automatically during release, likeREPLACEME.I was wrong.I bet this happens duringgit node land, and I have an old version of the bin.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes