Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: run license builder #35577

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Oct 9, 2020

License is out of date

Created by running ./tools/license-builder.sh

License is out of date
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 9, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/community-committee
  • @nodejs/tsc

@mmarchini
Copy link
Contributor

mmarchini commented Oct 10, 2020

Wondering if we can automate that with Actions somehow (either run the tool and autocommit or linter to check for changes). Linter would probably be the easiest and least disruptive approach as the linter could run only when deps/ change.

@MylesBorins
Copy link
Contributor Author

Linter should be reasonably straight forward. Run the command and fail if there is a diff

@MylesBorins
Copy link
Contributor Author

Landed in 708c87d

MylesBorins added a commit that referenced this pull request Oct 12, 2020
License is out of date

PR-URL: #35577
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 14, 2020
License is out of date

PR-URL: #35577
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
@bnb
Copy link
Contributor

bnb commented Oct 19, 2020

@MylesBorins @mmarchini you could also have it automatically PR if there is a diff with @gr2m's create-or-update-pull-request-action: https://github.com/gr2m/create-or-update-pull-request-action

@MylesBorins
Copy link
Contributor Author

I won't haved time to dig into this for a bit if someone else wants to pick it up.

@bnb
Copy link
Contributor

bnb commented Oct 19, 2020

Already working on a PR.

@gr2m
Copy link
Contributor

gr2m commented Oct 19, 2020

holler if I can help in any way

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
License is out of date

PR-URL: nodejs#35577
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.