Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve kbd element rendering #35497

Merged
merged 1 commit into from
Oct 8, 2020
Merged

doc: improve kbd element rendering #35497

merged 1 commit into from
Oct 8, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 4, 2020

  • better vertical alignment with text
  • slightly larger "key" size
  • make top light area (from box-shadow) smaller and more subtle
Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 4, 2020
@Trott
Copy link
Member Author

Trott commented Oct 4, 2020

Before:

image

After:

image

@Trott
Copy link
Member Author

Trott commented Oct 4, 2020

Magnified before:

image

Magnified after:

image

@Trott
Copy link
Member Author

Trott commented Oct 4, 2020

@silverwind Does the light padding at the top work for you now? Do you think we should get rid of it entirely?

@silverwind
Copy link
Contributor

New white padding looks almost unnoticable and I'm not sure if it's really adding something, I'd probably get rid of it.

@Trott
Copy link
Member Author

Trott commented Oct 8, 2020

New white padding looks almost unnoticable and I'm not sure if it's really adding something, I'd probably get rid of it.

@silverwind Got rid of it.

image

@Trott
doc: improve kbd element rendering
ce84bac 
* better vertical alignment with text
* slightly larger "key" size
* remove top light area (from box-shadow)

PR-URL: nodejs#35497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 8, 2020

Landed in ce84bac

@Trott Trott merged commit ce84bac into nodejs:master Oct 8, 2020
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@Trott @BethGriggs
doc: improve kbd element rendering
d53cfcd 
* better vertical alignment with text
* slightly larger "key" size
* remove top light area (from box-shadow)

PR-URL: #35497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: improve kbd element rendering
5d176ef 
* better vertical alignment with text
* slightly larger "key" size
* remove top light area (from box-shadow)

PR-URL: nodejs#35497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the subtle branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @silverwind @jasnell @addaleax @lpinca @nodejs-github-bot