-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix inability to hover version-picker #34447
Conversation
0.25rem = height of `li` - offset for `ol.version-picker` = 1rem - 1.25rem `left` and `right` is -1 because of the border
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ping @nodejs/website
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No objections but I can't reproduce the issue on Firefox on Windows or Chrome/Safari on macOS. |
@lpinca
You can zoom the page up to 200% to see this bug for sure. In some cases it looks fine. |
Hmm. Looks like there is a problem with fonts. font-family: Lato, "Lucida Grande", "Lucida Sans Unicode", "Lucida Sans", Verdana, Tahoma, sans-serif; To fix that we need to set fixed height for the menu items. After fix: There was also bug in the mobile version witch is also fixed: |
Not opposing, but I too cannot replicate unless the width/text-size is such that the menu wraps. Chrome macOS |
I can reproduce on Firefox on Windows but only if my mouse cursor is to the right of the dropdown arrow (and left of the right edge of the drop down box). |
So I updated the code. See details here #34447 (comment) |
This seems like a huge hack overall. I'd suggest a rewrite to a |
Given the comment here and @silverwind's feedback, I've removed the author ready label. |
#34768 looks like an alternative solution. |
See this #34447 (comment)
Checklist