Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove space above version picker #34768

Closed
wants to merge 1 commit into from
Closed

doc: remove space above version picker #34768

wants to merge 1 commit into from

Conversation

Vap0r1ze
Copy link
Contributor

Fixes: #34767

Before
before

After
after

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 14, 2020
DerekNonGeneric
DerekNonGeneric approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the PR. :)

@DerekNonGeneric
Copy link
Contributor

You may be able to circumvent this UI problem by adjusting the zoom of your browser while you wait.

@richardlau
Copy link
Member

Looks like an alternative to #34768.

@richardlau richardlau mentioned this pull request Aug 14, 2020
Closed
2 tasks
@aduh95 aduh95 mentioned this pull request Aug 14, 2020
Closed
@tniessen
Copy link
Member

Looks like an alternative to #34768.

@richardlau I assume you meant #34447 ?

@DerekNonGeneric
Copy link
Contributor

That might be a useful alternative to consider, but for now, I would just add the following to the commit message when landing.

Closes: #34447

We can reinvestigate the alternative later, there's likely more to be done in this area.

@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 18, 2020
addaleax pushed a commit that referenced this pull request Aug 19, 2020
@Vap0r1ze @addaleax
doc: remove space above version picker
6f0b87d 
PR-URL: #34768
Fixes: #34767
Fixes: #34447
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

Landed in 6f0b87d, thanks for the PR!

@addaleax addaleax closed this Aug 19, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Vap0r1ze @BethGriggs
doc: remove space above version picker
1de6ba3 
PR-URL: #34768
Fixes: #34767
Fixes: #34447
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Vap0r1ze @BethGriggs
doc: remove space above version picker
5214de7 
PR-URL: #34768
Fixes: #34767
Fixes: #34447
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Vap0r1ze Vap0r1ze deleted the patch-2 branch September 14, 2020 06:32
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Vap0r1ze @addaleax
doc: remove space above version picker
022b2aa 
PR-URL: #34768
Fixes: #34767
Fixes: #34447
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Vap0r1ze @addaleax
doc: remove space above version picker
6d9e6f6 
PR-URL: #34768
Fixes: #34767
Fixes: #34447
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: unable to switch versions due to spacing
9 participants
@Vap0r1ze @DerekNonGeneric @richardlau @tniessen @addaleax @jasnell @BridgeAR @HarshithaKP @nodejs-github-bot