[v14.x backport] timers: allow timers to be used as primitives #34482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
added
timers
This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by: Bradley Farias <bradley.meck@gmail.com> Co-authored-by: Anatoli Papirovski <apapirovski@mac.com> Refs: nodejs#21152 PR-URL: nodejs#34017 Backport-PR-URL: nodejs#34482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by: Denys Otrishko <shishugi@gmail.com>
lundibundi
force-pushed
the
backport-34017-to-14
branch
from
0807dff
to
9a4ab57
Compare
MylesBorins
force-pushed
the
v14.x-staging
branch
from
1b9bfb1
to
9814a2d
Compare
ruyadorno
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
e196858
to
358b934
Compare
|
@MylesBorins was this accidentally missed from the latest v14 release or is there something else to be done here? |
danielleadams
approved these changes
Aug 4, 2020
This was referenced Aug 5, 2020
This was referenced Aug 9, 2020
Merged
This was referenced Aug 11, 2020
codebytere
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
92340c9
to
b30b518
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by: Bradley Farias <bradley.meck@gmail.com> Co-authored-by: Anatoli Papirovski <apapirovski@mac.com> Refs: #21152 Backport-PR-URL: #34482 PR-URL: #34017 Backport-PR-URL: #34482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by: Denys Otrishko <shishugi@gmail.com>
|
landed in cca0372 |
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by: Bradley Farias <bradley.meck@gmail.com> Co-authored-by: Anatoli Papirovski <apapirovski@mac.com> Refs: #21152 Backport-PR-URL: #34482 PR-URL: #34017 Backport-PR-URL: #34482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by: Denys Otrishko <shishugi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows timers to be matched to numeric Ids and therefore used
as keys of an Object, passed and stored without storing the Timer instance.
clearTimeout/clearInterval is modified to support numeric/string Ids.
Co-authored-by: Bradley Farias bradley.meck@gmail.com
Co-authored-by: Anatoli Papirovski apapirovski@mac.com
Refs: #21152
PR-URL: #34017
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Bradley Farias bradley.meck@gmail.com
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: Yongsheng Zhang zyszys98@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Signed-off-by: Denys Otrishko shishugi@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @MylesBorins