Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] timers: allow timers to be used as primitives #34482

Closed

Commits on Jul 22, 2020

  1. timers: allow timers to be used as primitives

    This allows timers to be matched to numeric Ids and therefore used
    as keys of an Object, passed and stored without storing the Timer instance.
    
    clearTimeout/clearInterval is modified to support numeric/string Ids.
    
    Co-authored-by: Bradley Farias <bradley.meck@gmail.com>
    Co-authored-by: Anatoli Papirovski <apapirovski@mac.com>
    
    Refs: nodejs#21152
    
    PR-URL: nodejs#34017
    Backport-PR-URL: nodejs#34482
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Signed-off-by: Denys Otrishko <shishugi@gmail.com>
    lundibundi committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    9a4ab57 View commit details
    Browse the repository at this point in the history