Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] Revert "http: lazy create IncomingMessage.headers" #36553

Closed
wants to merge 1 commit into from
Closed

[v14.x] Revert "http: lazy create IncomingMessage.headers" #36553

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Dec 17, 2020 •
edited
Loading

This reverts commit b58725c.

Fixes: #36550
Refs: #35281

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v14.x labels Dec 17, 2020
@BethGriggs BethGriggs changed the title Revert "http: lazy create IncomingMessage.headers" [v14.x] Revert "http: lazy create IncomingMessage.headers" Dec 17, 2020
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34991/ ✅

@BethGriggs BethGriggs mentioned this pull request Dec 17, 2020
Closed
MylesBorins
MylesBorins approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

mhdawson
mhdawson approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BethGriggs added a commit that referenced this pull request Dec 17, 2020
@BethGriggs
Revert "http: lazy create IncomingMessage.headers"
29fac46 
This reverts commit b58725c.

Fixes: #36550

PR-URL: #36553
Refs: #35281
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BethGriggs
Copy link
Member Author

Landed in 29fac46

@BethGriggs BethGriggs closed this Dec 17, 2020
BethGriggs added a commit that referenced this pull request Dec 17, 2020
@BethGriggs
Revert "http: lazy create IncomingMessage.headers"
4264d9a 
This reverts commit b58725c.

Fixes: #36550

PR-URL: #36553
Refs: #35281
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 17, 2020
Merged
@watson watson mentioned this pull request Dec 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Sep 13, 2022
Open
This was referenced Sep 13, 2022
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Sep 14, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BethGriggs @nodejs-github-bot @mcollina @MylesBorins @richardlau @mhdawson @aduh95